mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: "Jihong Min" <hurryman2212@gmail.com>,
	linux-hwmon@vger.kernel.org, linux-api@vger.kernel.org,
	"Günter Röck" <linux@roeck-us.net>
Cc: linux-doc@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	Jonathan Corbet <corbet@lwn.net>,
	Randy Dunlap <rdunlap@infradead.org>,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH 3/5] hwmon: Add a generic interface for userspace implementations
Date: Sat, 10 Oct 2026 16:50:29 +0200	[thread overview]
Message-ID: <d08d3437-c4ef-4b88-938d-71962c2f1e88@web.de> (raw)
In-Reply-To: <27071a389536dfbc35b628a50e90636ce012c21f.1791559095.git.hurryman2212@gmail.com>

…
> +++ b/drivers/hwmon/uhwmon.c
> @@ -0,0 +1,641 @@
…
> +static void uhwmon_disconnect(struct uhwmon_device *data)
> +{
> +	mutex_lock(&data->lock);
> +	data->online = false;
…
> +	mutex_unlock(&data->lock);
> +	wake_up_all(&data->wait);
> +}
…

Under which circumstances would you become interested to apply a statement
like “guard(mutex)(&data->lock);”?
https://elixir.bootlin.com/linux/v7.3-rc6/source/include/linux/mutex.h#L253

Regards,
Markus

  reply	other threads:[~2026-10-10 14:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-09 15:38 [PATCH 0/5] hwmon: Introduce uhwmon " Jihong Min
2026-10-09 15:38 ` [PATCH 1/5] hwmon: Export sensor and attribute definitions to userspace Jihong Min
2026-10-09 15:38 ` [PATCH 2/5] hwmon: Expose attribute validation and string helpers Jihong Min
2026-10-09 15:38 ` [PATCH 3/5] hwmon: Add a generic interface for userspace implementations Jihong Min
2026-10-10 14:50   ` Markus Elfring [this message]
2026-10-09 15:38 ` [PATCH 4/5] hwmon: Reject truncated attribute names Jihong Min
2026-10-09 15:38 ` [PATCH 5/5] docs: hwmon: Document the uhwmon userspace interface Jihong Min

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d08d3437-c4ef-4b88-938d-71962c2f1e88@web.de \
    --to=markus.elfring@web.de \
    --cc=corbet@lwn.net \
    --cc=hurryman2212@gmail.com \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=rdunlap@infradead.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®