From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CY7PR03CU001.outbound.protection.outlook.com (mail-westcentralusazon11010000.outbound.protection.outlook.com [40.93.198.0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74D3D373BE6 for ; Fri, 27 Mar 2026 17:09:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.198.0 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774631374; cv=fail; b=A+OGV+JFddfXTO3B4zCsdHojb+VQHxsSejYSLCCwR7p99tatw1alzH+EkVnxp80skifmfMJ14acOgb00SPZ45Xwo8PSvyPw7QAsbHc44jR4ZNK8fmxbYByOlDq/UGQMGGRPy09sygmOIHVqLwMTcVlefgoON5JRRmSAA6ka7KkI= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774631374; c=relaxed/simple; bh=s3Fe74zUVBfjNpXCs2fpKWa6Kc3v2QwXtZtGvLS+mU0=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=ByG6fh2PAx/18FkMPWwuPtCUKIzBrXY4qbe07MFrggQxqjM8eyDbEaPctKfbfoUgpbrEcXQu/niT7uxEHKWg3Sej/FGAU9V6UhKRn3PLXMp36BWHeHH+JgapJPUZQDDaNBZoPEP5UswJVoMzh0o3TQTs1umn7dLC2A0IO0zQAls= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=kmG7+Lhy; arc=fail smtp.client-ip=40.93.198.0 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="kmG7+Lhy" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=JFZxUfYmDwKrSqw2fQCFEMWIFe8ZuPIRIgX9xxUy15tbBUFVRJ58lsOu15vu3Hf0K088T3zBgzWkLGo/Vh6u5/QYeyeiz9CvFA6iD2RkMyuvrsJdTaVdyW8W40Pea7UUG/KLdVv4EoIsvqX1QP3lXvzNJsiNV8zf7GN458isIQs5++ty+cA9o3PJpu4Of2Xn8lPw6uaWLq/ZDc16mvFbHTIekC7cwuskm6Uav66S3cDmSaQEUG/JOMUZoCSVEyY9uYXU9avhnK8QwgaTWbSZtlS15HnEBZkbGLQuNI5QOoZLgdPX2DcalODCN7t4VOVEM+o7YjtTMRKw87opYDD+8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w//EZQTv4LmCSChf2sLsM8cx3KbNn+ElvALdjEr46+0=; b=ulZ9rdqlx5k2wORbHF1hlxH3nKtRcaVj99rTuI8aRQhX390+SebPS+ZATBxG2jKd6Bca9b79R8jQB2PVeq9+139VL4VVtdNdsx1tFVUUU7zoJsTqQBylwiROL7h/jpbRoQbhaWh27Lk67ITwdk+nkyk3nDZDlCRDjUuZ2HjIO+6Bjhq13ip1Nn1WdoVYMGOWtKN1y4V84CpIOgaXopiGBLEq0V9GelOGioHnpMzlkYa7Rq0wpqbWez+Jh3bfgL9JQD3mw9ErUbPklu7worPpKZmvI1mykVwbD9dXy0KypKlMtPLYUQdvFC/bVn8wg2bKg8DUNrI2RwEaE5tvsnoqQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linaro.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w//EZQTv4LmCSChf2sLsM8cx3KbNn+ElvALdjEr46+0=; b=kmG7+LhykaNcuIYIxkokl++q/86CJSN4sxU/QpDITQMj2FZQrJ+m1RztxbA7nypl92l1/7Nz3fsE/MMB9qH6BongFARb6zylM3aUuN/8ol86FQVxAZ5DDZfUWSh+3A/rrGJE2pGrsPbL563VYdDHBuQ5makJGowzRvNj5qQN93g= Received: from BL1PR13CA0118.namprd13.prod.outlook.com (2603:10b6:208:2b9::33) by CH3PR12MB9731.namprd12.prod.outlook.com (2603:10b6:610:253::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.8; Fri, 27 Mar 2026 17:09:30 +0000 Received: from BL6PEPF0001AB51.namprd04.prod.outlook.com (2603:10b6:208:2b9:cafe::5a) by BL1PR13CA0118.outlook.office365.com (2603:10b6:208:2b9::33) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9745.21 via Frontend Transport; Fri, 27 Mar 2026 17:09:30 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by BL6PEPF0001AB51.mail.protection.outlook.com (10.167.242.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.21 via Frontend Transport; Fri, 27 Mar 2026 17:09:29 +0000 Received: from satlexmb07.amd.com (10.181.42.216) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Fri, 27 Mar 2026 12:09:29 -0500 Received: from [172.31.184.125] (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server id 15.2.2562.17 via Frontend Transport; Fri, 27 Mar 2026 12:09:26 -0500 Message-ID: Date: Fri, 27 Mar 2026 22:39:25 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] sched/fair: Use sched_energy_enabled() To: Vincent Guittot CC: , , , , , , , , References: <20260327132013.2800517-1-vincent.guittot@linaro.org> <458b21f7-6640-450c-889c-d05c6b0d801e@amd.com> Content-Language: en-US From: K Prateek Nayak In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0001AB51:EE_|CH3PR12MB9731:EE_ X-MS-Office365-Filtering-Correlation-Id: 149f6c5c-0e4d-407c-fbf5-08de8c239bd8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|82310400026|376014|7416014|1800799024|56012099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: X+J4BoySakMWdrcmnNiaCStXz9FnGC8bMuh/1c9MyWjOIuxFW/5d4z9ANmGOiCT8DiU23LUlHL3lfrPdhUmTqNCYOgbcHE0yZ6eaDgPBkx8+RgpG7QEjXG9j9L+w9Kx8wJ2DQr1OC5gbCnzi9tVCznD+JQNkbDg1JwetRxE2SuBjgZKay0Au7Xy4LZaWvxC83mnqrHGoYJZHsH8TuZ1L4sQMwjxsbEnIbF/VgFZ9UMB3pN422MtAGmGQPEdI9JSk+wldgYsp+43dUl29CRbqwXzUeg5CXmrP2iDuHw5G4eu8P4oc6Rv8FhA/9wE3tB6WVVvNuLMdJdvM+IQ07XQm1yAp/HkDM91x8kqIjVV7qzrmnZs2RydjTpgVmueYGcflNkso40CtJyrP/FwKXI6AESRwDRUSYdQtcG/jC+AolBdhqg+tTzy9ofVT9hMstn539p9jDE12OEvF93x7aLqaANSI9Tn2LbLgFsLVghAuRlxxbpKwyVUNHiaXT9wcA2G9gXzuQYvMvuvv3H8qjHhlG8rL+pzMTZtLDfMndy0zQGpAqJXYAguewAcCUqpG5R5RkkmTP9tEgeJBowd4FWux+KTzZuKOu0BCjDYGvhCxS1FzxWG4rz95empjOqrlD49plefkgr334Ohza8qM1j+MZnvM7rWH/Zfh+mmJ5vfOWXDYBxPPfQuTiW2DcPkfdz9loiPVvfoKo1lQi+Mw32MN/n9nDc5+5aPmIewwnSPPSnmzx6dBe8+DYW1v4BAvS/hHDYlderoHMISriDjaENG3MQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700016)(82310400026)(376014)(7416014)(1800799024)(56012099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: P64QHizhBjBvxPmOgSWu5RZzKsx0iS8ufKeihISZf08oO11LxGfaSz4YepmxhKl143w2b5+P3XJnOItFa/PolUmtO9YvUMcf1mCqLk1HcLIlCHxvFiDdduOe5vQyf0Rx1QBOXJdONvJjmFMnNjg0gEfSUwQ5A21cw4sQ3mV1bbn0DlRzGjUm9pBOJNLoshrZuxT5W6huZPH+/N/AoLTJ0qndsGxUUkzUn/QApuCu2oflI6zYclcS+aM11Cd0D7OCfvexF7t5dY8HkIjevZh+XMBpqe8zB+mkhmcAPPRBww28Fjthr2/4/3MEKXO7hGVGPgDz1jFQ4bbY7nwqMnFHlxvIvPg4iZc08S5RxGkitmuywbsriKwJAtbxJesCSBv3p/0au8IhWa2VJxrOkBijFSvgohfytKnesTwMCtFxqLbGakF3xH6TISB8zudMtHdM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Mar 2026 17:09:29.9173 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 149f6c5c-0e4d-407c-fbf5-08de8c239bd8 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0001AB51.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB9731 Hello Vincent, On 3/27/2026 10:02 PM, Vincent Guittot wrote: >>> + if (sysctl_sched_energy_aware != sched_energy_enabled()) >> >> Quick tangential question: >> >> Since "sysctl_sched_energy_aware" is initialized to "1", if >> build_perf_domains() returns false at boot, sysctl_sched_energy_aware >> and sched_energy_enabled() will go out of sync and reading >> "/proc/sys/kernel/sched_energy_aware" will still show "1" despite EAS >> being disabled. >> >> Is that okay? > > Isn't the call to sched_is_eas_possible() there to prevent this case ? Ah! pd_init() can never fail (expect for -ENOMEME) I somehow thought there was more to it. Sorry for the noise. >> >> Some sysctls like numa_balancing will show 0 if disabled (by user or >> due to lack of NUMA) reflecting the real state of system. Should >> sched_energy_aware do the same? -- Thanks and Regards, Prateek