From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.168.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793089711; b=hLzbY1EbI+Sg+k55/z+mNlcPeMrQH7FU/8s2/zlQDSXCLrlM22HyZRsV/l0Zh51dKmVJ tr1Hv+vDDWyPPzl4ZkswB42WqZEP2mruyKlTTwr8BwzKT58K0kFrFxTTrTUjOfiVWtrlT yoTAMCfZKr1PaacNXXugB9a8Mmo32Fc7HC7TNEEtJ54mT9NVYtKOvSqSbsP8N5+9IE+1R a41tcy7u1ublQZt6hf3MED0ebnJRKNmrasvA9YJCsHSmRhPWyfoCT7YPztT1y+YekvbP+ 5zkJmm11N8Hgi7CfnX2621IHuSG6TC9QjoZxyKSPLgxa+RoyQ8gv711GnXFKPGrXenA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793089711; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:Message-ID: Date:MIME-Version:User-Agent:Subject:To:Cc:References: Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:X-Proofpoint-Spam-Info:X-Authority-Analysis: X-Proofpoint-ORIG-GUID:X-Proofpoint-Spam-Details-Enc: X-Proofpoint-GUID:X-Proofpoint-Virus-Version: X-Proofpoint-Spam-Details; bh=+lO09KkTAsM7ProbM/oc2Ec9Kk1EVdkd8GU8zKqLcjw=; b=QRkVsOd+nUS9sfBApuQ5dhckUPg+O0BSH/eW5tNOVIALHNNLuElozi6hyzsK3yHqjx3/ f8MAQ8KKY7+GxnkvBtUThp+KNvwfILlaCmVYu99n9/3pl1VcYA+5FoeFgQex8nkZYQJUs OL2c8bD4Td2La1RrXCTNSbxWYmXgBsjV5/RjXS6cY0lLxG72ACJan34Zvzn1c8qfxqE78 kVzOjfdDoYrzUxFIsp1qSawb1mKkIstRHK9Bc/tYLFuZXYH1w9sWtAk2JwBdnQWmuFtqX U6sUrH0WvXDKHGzfjqdxPTuPRCFzJtH3R3dDTAn8R2AlsBWLgWaqSzrF5yRSDtfbW2w== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=GlbFyay7; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=cOKkjIOE; arc=none smtp.remote-ip=205.220.168.131 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3124606A321 for ; Tue, 27 Oct 2026 08:28:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org B3124606A321 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=GlbFyay7; dkim=pass (2048-bit key, unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=cOKkjIOE Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69R5ZJxS3950119 for ; Tue, 27 Oct 2026 08:28:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= +lO09KkTAsM7ProbM/oc2Ec9Kk1EVdkd8GU8zKqLcjw=; b=GlbFyay7dsKQ9ONj Lj/uYjVSZ75LQTwtVnw+tCNv/wTfopqDcEJ0yjqd4xxymac5LTN/wtZ9c37sqrdz m+RqgmI5dkYJAg8JyyJx3Nt45q5KKCWIpZSC4T6co91RCnRsnojpe7MXpAwqtfL5 w4bgb4COYr3OeDyJ7lDoeXtlslqt8s+Z6H9iq1dlbTNW6pyg0xeQRWLBvXnHfHTn 6DQf8YRnKb+TuuRFKS5UQI9q/oKzOjrlNj3cjyBbFIjCo6VgVOeP1ufuUT5diUem rClYF2XWK0ldpygT74Q/Ta2X9WMC53IPT7ngtN3b4Ky+jq3R6YODlrHxnjetmOgG A+BPlA== Received: from mail-dl1-f69.google.com (mail-dl1-f69.google.com [74.125.82.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hjb54jugc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 27 Oct 2026 08:28:29 +0000 (GMT) Received: by mail-dl1-f69.google.com with SMTP id a92af1059eb24-1663fb7e005so5393368c88.0 for ; Tue, 27 Oct 2026 01:28:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1793089709; x=1793694509; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=+lO09KkTAsM7ProbM/oc2Ec9Kk1EVdkd8GU8zKqLcjw=; b=cOKkjIOECaLzaqzzbCElC/reN3ZRiJ2LMz8/Q9jrv992ZG17jhW5epqYdN5g/kOEjN 7yMBimWU6rN2+rtY+871NjsWTSI3SrV9OVsJmPiXXltW5E0uEQvhHeEu1rkS6xnx4z/C J+auHE9W5dfgFsnaLbjbz3g4wTeuUrip4d83/XXyW2nGWuDPIMHhqc9UrY2jwEQI8dAT 6oJbw/VW127ZN7HrCwrlyk6YGN5NWCFq/PYeiyqMFgD3dWEyVPlQYma1ZwrwNhro9YCl oNulmnttgMAw1QWi9Lhcbgc9jNrgHtlwovAdYG4MgNYdlhEyRD41TF7e8EqoiyuOZ4/g Rkqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793089709; x=1793694509; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=+lO09KkTAsM7ProbM/oc2Ec9Kk1EVdkd8GU8zKqLcjw=; b=CqqthgceMlC+DQgC8GC1hVRiWwT7EMKbpB/laVRC4S2ViAuycay5gKld/N9JRjQOl5 9axoeiKMJBGxz/IzRR0e/o9Ba3FX6Q5T8DZJ0XNEthY7o4eBIaLWv+9fTyvmfxbAg0E+ JFpVeu/Z/YJckW+mFCjvAzGYZ575ZdjKnbUZvlr0nEdR1S98OIYnpgtQ1BncGfeO+OZ/ 3uUWS7WPUWo7fETlIzU0SgK6OGIC0X9eH54kfEjhuRfyPnmePCUD7uUYgdYADBpKZSeX ai+rFI/ycpyc/jB319zXniJnHoVJSW7HmDfSs+1l3/7uEenaG1elCG2Z+YBD5cUAvhP7 WrDw== X-Forwarded-Encrypted: i=1; AKwUvBxIdvdyniFJZNPPB1e4vwlqCu9mM90D7O6WSXO+abx57BomODvKRuQqu95cT/yHJ37qEF/hVHHngSmbUT8=@vger.kernel.org X-Gm-Message-State: AFq9FYKP0PKhXjbH4CUl5923lckRsmuP9nee3jozoJ8FvfmvfCuMvVo/ qqr+zEx065ALImmQaH57I30NSCJRQGr4IR4Vfi63yYzYqsAO17qtVCZsxmgVgNlwUDkt+c1++Yh wXIZY7lxOmRHyPHqqmQxmdtYx3uWz2HquyVjjFvEVUez1VB4V17XG5Bb/9pPEdta/3P8= X-Gm-Gg: AYBFou1/rP+yPwY8ZeqMJw6afrzupxjsvzn/mCnrN2jVf3rsKYcWTPfnLNHNWnK+ISc H45pK6W6ZAQ+ZfQ6DZQcElDTCoWvEo1LRExBhnVehXTmFdPgR1h+ujPnPcQrki0A1/lRDFBghcc yHXmoSEmBrrU46Vlzsw7jIJhtVrnjSaIubAHdRQK29aG9auXpdfLM3dZbW8oaeE+cwUt+xJICkZ ncwWp4Xa6EpB0UuPcpVfxMqwwiWwC+8LbemAiz/0sv9Veakw1g6sU/2vBCkfCR7TrqxqvEH1x6C H6zPSRdinvkySYUMLaJPX/xuSsqhgRfNwrgBiWyY1UN3ghUANK1JtS0tzCfbRQsRFqhWr+obDm9 H6d0IZfIb5LcccNPndRN1hSVu5qUIX1+xIZCq X-Received: by 2002:a05:7022:e10:b0:14b:cf58:ce15 with SMTP id a92af1059eb24-199377d8c81mr19690496c88.43.1793089708925; Tue, 27 Oct 2026 01:28:28 -0700 (PDT) X-Received: by 2002:a05:7022:e10:b0:14b:cf58:ce15 with SMTP id a92af1059eb24-199377d8c81mr19690386c88.43.1793089708019; Tue, 27 Oct 2026 01:28:28 -0700 (PDT) Received: from [10.217.241.81] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-198a249c331sm65866768c88.17.2026.10.27.01.28.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Oct 2026 01:28:27 -0700 (PDT) Message-ID: Date: Tue, 27 Oct 2026 13:58:21 +0530 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] arm64: dts: qcom: lemans: Add Draco EVK board To: Dmitry Baryshkov Cc: Bjorn Andersson , Konrad Dybcio , Abel Vesa , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Richard Cochran , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Vishnu Saini , Khalid Faisal Ansari , Ajinkya Inchure , Anuj Tripathi References: <20261019-lemans-draco-final-changes-bringup-v1-0-dcabe94f1074@oss.qualcomm.com> <20261019-lemans-draco-final-changes-bringup-v1-3-dcabe94f1074@oss.qualcomm.com> <3btrmmavq65lp7rwmdx76qjvaseaoa55xdibdli2izujusebhw@fkrtjiqsnvnt> Content-Language: en-US From: Gopikishan Thawre In-Reply-To: <3btrmmavq65lp7rwmdx76qjvaseaoa55xdibdli2izujusebhw@fkrtjiqsnvnt> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYxMDI3MDAzMyBTYWx0ZWRfX3eHRnR2YsjYM dDvlohrd1vO3sj2uGliawO3lr/vS+NMnJoYZ4mrNF3kUbmD2M1ChTTL30bcHviHP8JFRJfDKQRA 3Y6/PhMdy5Y4irc885W5zDTiuyDEEZA= X-Authority-Analysis: v=2.4 cv=bsnZl0ai c=1 sm=1 tr=0 ts=6ae060ae cx=c_pps a=kVLUcbK0zfr7ocalXnG1qA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=jkk_kXO6dKdktKeh6coA:9 a=QEXdDO2ut3YA:10 a=vr4QvYf-bLy2KjpDp97w:22 X-Proofpoint-ORIG-GUID: fjr6UBCW9Sb4F5bVpdwCpl-knDhq_QKB X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDI3MDAzMyBTYWx0ZWRfXyO3VRmqdf1zn gvgdrtbqRel+QdKKAL55x8VbA6WchO4tMP8I9JF7D8WT8ZjfVSwfWpzlMvOAsbZNwBOj1JK9EqH jRU6Uiod7KlzBlA5FMVQJ9tyu5Y+ry2c0ZmOXhQHsHGX9ZhDkjAfI+iwjMQ7IShfVLQqNa6eBHi eLJ/wbOZ/Lrw3r9+j8rMXHArbdup9qbJvT7ImGNSsaYZ+ChVvZED5wLwyMzYT/3rDA8gMwrWnxe oc7P6HErMffpUdzkBdM1CVSsbJDiTXh416G6APbbKjnStxeRoGPPPA4EucueKkrlXWZASHmcckN 3jRYdU2pwg6euKfAyVHEzLfAVQZzbli/kyNB8hOHjmyGUekTlMPPQxNzZMh3RZ6X5+cbmF+jyPT axs1wGkjr9HwlwxdlmBvKKxzHYbMnF0NnVdLA1XicnyJUAqii3e90kRiFLhDrH37KpPEx3SwwRA 8DNfTaq1VrCMZXMpuxw== X-Proofpoint-GUID: fjr6UBCW9Sb4F5bVpdwCpl-knDhq_QKB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-10-27_02,2026-10-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 spamscore=0 malwarescore=0 lowpriorityscore=0 clxscore=1015 phishscore=0 suspectscore=0 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610190000 definitions=main-2610270033 On 10/19/2026 5:35 PM, Dmitry Baryshkov wrote: > On Mon, Oct 19, 2026 at 03:57:34PM +0530, Gopikishan Thawre wrote: >> Add the device tree for the LeMans Draco EVK platform which combines >> the LeMans Draco EVK SoM and Draco carrier board. >> >> This device tree adds board-specific peripheral configuration on top >> of the SoM, including: >> >> - I2C GPIO expanders (TCA6416/PCA9534) on i2c2 and i2c18 >> - EEPROM with MAC address nvmem layout on i2c18 >> - Native DisplayPort output (DP0-DP3) >> - Dual Ethernet (ethernet0/ethernet1) with HSGMII PHY over SerDes >> - ST33HTPM TPM over SPI16 >> - AMC6821 fan controller on i2c4 >> >> Co-developed-by: Vishnu Saini >> Signed-off-by: Vishnu Saini >> Co-developed-by: Khalid Faisal Ansari >> Signed-off-by: Khalid Faisal Ansari >> Co-developed-by: Ajinkya Inchure >> Signed-off-by: Ajinkya Inchure >> Co-developed-by: Anuj Tripathi >> Signed-off-by: Anuj Tripathi >> Signed-off-by: Gopikishan Thawre >> --- >> arch/arm64/boot/dts/qcom/Makefile | 5 + >> arch/arm64/boot/dts/qcom/lemans-draco-evk.dts | 543 ++++++++++++++++++++++++++ >> 2 files changed, 548 insertions(+) >> >> + >> +&i2c2 { >> + status = "okay"; >> + >> + expander0: gpio@20 { >> + compatible = "ti,tca6416"; >> + reg = <0x20>; >> + #gpio-cells = <2>; >> + gpio-controller; >> + }; >> + >> + expander1: gpio@21 { >> + compatible = "ti,tca6416"; >> + reg = <0x21>; >> + #gpio-cells = <2>; >> + gpio-controller; >> + }; >> + >> + expander2: gpio@22 { >> + compatible = "ti,tca6416"; >> + reg = <0x22>; >> + #gpio-cells = <2>; >> + gpio-controller; >> + }; >> + >> + expander3: gpio@23 { >> + compatible = "ti,tca6416"; >> + reg = <0x23>; >> + #gpio-cells = <2>; >> + gpio-controller; >> + }; >> + >> + expander4: gpio@38 { >> + compatible = "nxp,pca9534"; >> + reg = <0x38>; >> + #gpio-cells = <2>; >> + gpio-controller; >> + }; >> +}; >> + >> +&tlmm { > > Please make sure to sort your DT file. You have 'tlmm' node between > 'i2c2' and 'i2c18'. > >> + >> + dp2_hot_plug_det: dp2-hot-plug-det-state { >> + pins = "gpio104"; >> + function = "edp2_hot"; >> + bias-disable; >> + }; >> + >> + dp3_hot_plug_det: dp3-hot-plug-det-state { >> + pins = "gpio103"; >> + function = "edp3_hot"; >> + bias-disable; >> + }; >> + >> + ethernet0_default: ethernet0-default-state { >> + ethernet0_mdc: ethernet0-mdc-pins { >> + pins = "gpio8"; >> + function = "emac0_mdc"; >> + drive-strength = <16>; >> + bias-pull-up; >> + }; >> + >> + ethernet0_mdio: ethernet0-mdio-pins { >> + pins = "gpio9"; >> + function = "emac0_mdio"; >> + drive-strength = <16>; >> + bias-pull-up; >> + }; >> + }; >> + >> + ethernet1_default: ethernet1-default-state { >> + ethernet1_mdc: ethernet1-mdc-pins { >> + pins = "gpio20"; >> + function = "emac1_mdc"; >> + drive-strength = <16>; >> + bias-pull-up; >> + }; >> + >> + ethernet1_mdio: ethernet1-mdio-pins { >> + pins = "gpio21"; >> + function = "emac1_mdio"; >> + drive-strength = <16>; >> + bias-pull-up; >> + }; >> + }; >> + >> +}; >> + >> +&i2c18 { >> + status = "okay"; >> + >> + expander5: gpio@3c { >> + compatible = "nxp,pca9534"; >> + reg = <0x3c>; >> + #gpio-cells = <2>; >> + gpio-controller; >> + }; >> + >> + eeprom@50 { >> + compatible = "giantec,gt24c256c", "atmel,24c256"; >> + reg = <0x50>; >> + pagesize = <64>; >> + >> + nvmem-layout { >> + compatible = "fixed-layout"; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + >> + mac_addr0: mac-addr@0 { >> + reg = <0x0 0x6>; >> + }; >> + >> + mac_addr1: mac-addr@6 { >> + reg = <0x6 0x6>; >> + }; >> + }; >> + }; >> +}; >> + >> +&i2c4 { > > More of the nodes in the wrong order. Please go through the whole file. Thanks for the review. The entire DT file will be sorted alphabetically in v2. Best regards, Gopikishan > >> + status = "okay"; >> + >> + fan_controller: fan@1a { >> + compatible = "ti,amc6821"; >> + reg = <0x1a>; >> + #pwm-cells = <2>; >> + >> + fan { >> + pwms = <&fan_controller 40000 PWM_POLARITY_INVERTED>; >> + }; >> + }; >> +}; >> + >