From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 663E13D47B7 for ; Thu, 11 Jun 2026 10:43:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781174597; cv=none; b=hRQbL4w3wH4DScwD4Ji6SNViMzxbjvGSA3Sr9NQJbsUyAQUiujlZvtL4voVFMuiicXuS+DVk1bBCNItI89Qq5NvAKLbJEVnAsVxZYc2c0rieSOUnzXuXHjCEV8bbAW1u7GypjSVssOt2j0LClV0yqp3sFj0uEbZAFc2yXbx6hX4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781174597; c=relaxed/simple; bh=zmNw8D5zWNdKNVzgv5ao0F5vgRAQeg0ZOCSSRFKMbzI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QnsxKGND7M0WwtoCzG3nZG1EVg/xgt1RzU7QO1fJf0n6o86bjcAUkf8D98JkPy/113lBYP4ZA60T0uwv4gHRJWr7RsnpiWQ6+CJ7g/dz1mQkw+JlbpZKq1m+QYwjyr0yJoRHm4SWShSSmrg0uNfyaW6ZxJR9d8P2HnvAYHunVBQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZYyu8GuP; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RjL5FUiV; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZYyu8GuP"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RjL5FUiV" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65BA1gA9169237 for ; Thu, 11 Jun 2026 10:43:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= kSoVFawRRZBWzshRPZGQRk+ptUMUxsYND+WmlIf6M1c=; b=ZYyu8GuPzXmQwecG /46W6j0yy8QoY2yaWBVkoaYJXyPoCqSUqqpO9TuoSDJRCjod0KVPEiyxxZa8WL9n uu4bLqwh3zjurJHH9r5RW92S7yGrOoJk/5e3RtqHKzAGop7yjCzuBmwue5yBKy42 p53S98jB4FJQz8l0J/XujeMMqHfOOoHPNsh6o4XdLKq+TKZUeA3u8qxE2urYwpsC 7CYjLJXCNO9soKoPQxaM818l78Mo0jkNUmaSd/bcwy8F01lpGgy+BqMyFh8Yw5Ta 7Tmmt30KqitKhXN78BxlzEznoPwUibWyEw6A9/qEUye7fig7M0ZwNc/gyMxBPK+y CyP1yQ== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eqe6ub052-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 11 Jun 2026 10:43:15 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2bf0b7425bbso147908005ad.0 for ; Thu, 11 Jun 2026 03:43:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781174594; x=1781779394; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kSoVFawRRZBWzshRPZGQRk+ptUMUxsYND+WmlIf6M1c=; b=RjL5FUiVqvr7WLuaqrZ9pv3fTyXWxAGxNZn+S95u/meMehKhLOipxdTx8X9RjNfGqB PWS6wpSazkPY88r1c0NAXyJ6vCtX98tPSA9ifYlgPmlqP3eAuv1FehK/a9fj0mSlorhX DO1H/wcuUC3qaoEU45/sl4lOHh9ITzTMGGQKTga7GM9fu/99rOgnvtAWJN6WHLzU+mot XZaPL/x44jDJKlbI+yf3GGi4fSVJgq8NlZBDlPMbMqo2ISoAPB/p9Z8dLppeRr9JVi8o LJ+9w39OJZTlVG8D53DrWZTrwMMTs8S3BSszGv0gYDTIO/ULAH6MYlAfhlwjGuKu62kA uXMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781174594; x=1781779394; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kSoVFawRRZBWzshRPZGQRk+ptUMUxsYND+WmlIf6M1c=; b=B3k7ADJ2wpjyzWORRBz79kC9lChtCXDgbfYdhLH3QR6h4aV6oQdH3rjQ8fOWeHZUZZ 8f/RIdrMRqEwSCl3hffHsjv/ROdVN7NWfoG7yJVvKdiFaGqXslGHJ5fl4IerNwO1BlqY 739R4UbDBWX+2n1r6Qnv4t6s8L3NlAUiEP48ZlFxxDRF1RJg0AsVGGOkAnTzQUiR7r1q 2/Oq44MwSswkj+l1Nd1g73G+EssB++zrjjZuN7bDn2b/6BDabLpWKmlCpmFnUzC9XDD+ y19++eG3IJUBIrDOBCVczA2NQZeurJZmZjqa/BcOBCQCQcA1XwtCeW5mMuyquDj9r98i v2Ug== X-Forwarded-Encrypted: i=1; AFNElJ88W6SUpY3voJHwDHgjUd4JMPqUSyvOb3vPbQyAKa34DcauIPJFIEAsu/u1ohSMrqOM30/j37mGT7d3ZA0=@vger.kernel.org X-Gm-Message-State: AOJu0YzqQqL886JBbiW/8yPHpRWV11DU2SQosnJnIU1hU8wewXRRZ6Az wT/VKbGTklOiuc/cqMqHOfCapK2+hSQgSEeHlUezDfxa5A0F/vAOCRaapfNo49u4YcziGTprHNe ddMlykeadbcnv3kLrgfaBCYsweOHFDMY+oWTfIODLqkw4vOXzKGdTRCdbwg1N8R1R9bk= X-Gm-Gg: Acq92OEBwx9Stuv74XqeAH2niZ3bcYQq3LTdZg7PHpfFWzH6TqlywFYJ0qoWIWEY3Yj uAD3TFx3LzPKU4jmQXm6roqCUmt2oxOkPJzb0q64oWqwj4GN9KrohpqcvvTt3qG13AorX+cXj1w geTGiLpG3hnJa/rNrELb42or42W8AEY/3lHVdHqD2PbLnges72RCQ8qBBl/3w1cJRYxCvrW1WRt Wx5e/VmV36wv5riFWv+HiXethhP6ORzlHnMUQzryfPbqmI5+z7DR8eNGGeOsQxV57ebcInMqU2i 0bXJVFCUeeUXccR2QGCTQ3PpxYenpEr0+oz/KNUilOUV03s/LAOPz3THzeL0HZuV6D5rwk4XjUT zCigG/k1X6EvLW1pwmcIxkFDmB1RUUZrHvyhPbvnMdEoRczidKwzUpTpFuIaZqBC4 X-Received: by 2002:a17:902:c40d:b0:2c1:4d9:c8db with SMTP id d9443c01a7336-2c2f51c94d1mr25512275ad.37.1781174594278; Thu, 11 Jun 2026 03:43:14 -0700 (PDT) X-Received: by 2002:a17:902:c40d:b0:2c1:4d9:c8db with SMTP id d9443c01a7336-2c2f51c94d1mr25511865ad.37.1781174593840; Thu, 11 Jun 2026 03:43:13 -0700 (PDT) Received: from [10.217.217.28] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c164f84335sm273881735ad.19.2026.06.11.03.43.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jun 2026 03:43:13 -0700 (PDT) Message-ID: Date: Thu, 11 Jun 2026 16:13:07 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] iio: adc: qcom-spmi-adc5-gen3: Share SDAM0 IRQ with ADC_TM auxiliary driver To: Andy Shevchenko , Jonathan Cameron Cc: David Lechner , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Amit Kucheria , Thara Gopinath , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , linux-arm-msm@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Kamal Wadhwa , David Collins , Anjelique Melendez , Neil Armstrong , Stephan Gerhold References: <20260526-gen3_adc_tm-v2-0-702fbac919ac@oss.qualcomm.com> <20260526-gen3_adc_tm-v2-1-702fbac919ac@oss.qualcomm.com> <20260604114630.23ca427a@jic23-huawei> Content-Language: en-US From: Jishnu Prakash In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNjExMDEwNyBTYWx0ZWRfX85eF/5/KIUky JJMk8bymOC+S+LX/rH389uNZSfAOZBafVVuSzs9/HMD4TZ97EMLVXQL8AC7CxZQUbFOaqXChDY5 yKGQe8w1cMjvzDcVTCVz7MmKxtZJ8Ow= X-Authority-Analysis: v=2.4 cv=atOCzyZV c=1 sm=1 tr=0 ts=6a2a9143 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=QyXUC8HyAAAA:8 a=8gGmNC2uT6na8rc2OTkA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjExMDEwNyBTYWx0ZWRfXzcIPw0xx7krv AhmU40TfkyHBn232IMaHHTLWJ+dJqSEjXIOHWaW6UtXGXavFjRFmHi2pWVzwAtU72pmTXa7dJ4s EXgCRJ099MtdRmfHqe5Tj1z55merLt7nIK8k7/HpYvLhDmYvnxp3D26PPprycNwlv3Y5JYNOSOq MlOWUHZWsVjksdIdl6OfRHv9MV2rorbbhGamq08Yi2QKlMggQBl3riWVzjB+BLsjan5GewGve9T ggmymGx/LPWyB6S8FMDbM4gl34zH3aHIZbvimB2Ge+OauPbV13WaTStKCkI9D35Hqxm6/b/s5Wd WIvbxhFek2vHGIHLpPbE03yo34ELuVFOG3urL+18CMbJxf1eWnUDz1azdo1I1fHIrgK7rJTGrIc e5g0R7PN2DHdDN43p/iMbIkP4zA35+MSK9QQZ5FXv5MMZUPI2r2/NHtkgv53zgX4UNAcJIqK/2Y ixxjzItAkxlu13VZW6g== X-Proofpoint-GUID: Fy_7oHcLkobWnZ2tVXPnTe4YxJGrzTrq X-Proofpoint-ORIG-GUID: Fy_7oHcLkobWnZ2tVXPnTe4YxJGrzTrq X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-11_02,2026-06-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 impostorscore=0 bulkscore=0 clxscore=1015 spamscore=0 malwarescore=0 phishscore=0 priorityscore=1501 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606110107 On 6/4/2026 8:14 PM, Andy Shevchenko wrote: > On Thu, Jun 04, 2026 at 11:46:30AM +0100, Jonathan Cameron wrote: >> On Wed, 3 Jun 2026 02:35:20 +0300 >> Andy Shevchenko wrote: >>> On Tue, May 26, 2026 at 04:26:09PM +0530, Jishnu Prakash wrote: > > ... > >>>> + ret = devm_request_threaded_irq(dev, adc->dev_data.base[ADC5_GEN3_VADC_SDAM].irq, >>>> + NULL, adc5_gen3_isr, IRQF_ONESHOT | IRQF_SHARED, >>>> + adc->dev_data.base[ADC5_GEN3_VADC_SDAM].irq_name, >>>> + adc); >>>> if (ret) >>>> return dev_err_probe(dev, ret, >>>> "Failed to request SDAM%d irq\n", >>> >>> Also add a patch to drop this duplicate message. >> >> There is another thread going on this. It might not be duplicate >> if -EPROBE_DEFER is returned. The message won't be printed but it >> will be logged for helping debug deferred probe reasons. > > Yes, and I explained that it is duplicated as long as I understand current > code base. Hi Jonathan, Andy, After I checked for Andy's first comment, my understanding was that devm_request_threaded_irq would internally call dev_err_probe in case of an error, so this dev_err_probe print above would not be needed. Please let me know if it's better to keep or remove this print. And if I make the change, shall I add it in a separate patch before or after this patch in the next series? Thanks, Jishnu > >> So maybe we have been a little too energetic in removing these. > > Or maybe sashiko consumed a bit of LSD :-) >