From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EEBEE2DFA25 for ; Wed, 24 Dec 2025 15:50:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766591448; cv=none; b=APn2o1PE2juSkH5JvC8P8L9/MquZqlOawicSjq1mWR+87r/aTCBehN/aHVcbaoqqEZXTGNzeBhh48wHr1Q36d9HNv5DuBMdwX1Oi9tt72w1oqkAcgdZ5cT4pmI+gUG/RC5Qvu4mPUX6Ztf21DQuuA5Z8QZ1sKepIW5n7gL6GSpI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766591448; c=relaxed/simple; bh=/Ea/rB3LN0HquXeha074nkqVsH9FSf9jy6TvycaFmXw=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=S/nh2CMp7X7dXcke0DH2oWcIpllqjqfIHghNz614H16U7y2gHrN7lMXFzp9yoSKOlMmzyKLfWUmr7FDmQqIsMvqUxc1EswXEB+1YvutY+0Ppfni2KGhYp07Aahp8MUvjNeG2nuZK9Q2ItuOqj0ORirgvq0+bTiRoWkrr0gDjt54= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ndufresne.ca; spf=pass smtp.mailfrom=ndufresne.ca; dkim=pass (2048-bit key) header.d=ndufresne-ca.20230601.gappssmtp.com header.i=@ndufresne-ca.20230601.gappssmtp.com header.b=RDssSKy/; arc=none smtp.client-ip=209.85.160.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ndufresne.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ndufresne.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ndufresne-ca.20230601.gappssmtp.com header.i=@ndufresne-ca.20230601.gappssmtp.com header.b="RDssSKy/" Received: by mail-qt1-f178.google.com with SMTP id d75a77b69052e-4f34c5f2f98so68096641cf.1 for ; Wed, 24 Dec 2025 07:50:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ndufresne-ca.20230601.gappssmtp.com; s=20230601; t=1766591445; x=1767196245; darn=vger.kernel.org; h=mime-version:user-agent:autocrypt:references:in-reply-to:date:cc:to :from:subject:message-id:from:to:cc:subject:date:message-id:reply-to; bh=QSdmNzll22GS36dUZyYftlYEWLa006on7/6Z+DJM0ag=; b=RDssSKy/kYmRqnScBofubBXEBWJJj8L+z1l+lE8b2gOFS7cJhQt6lDCKlDpkj4RR6T Fe3ururyLgTIo3HDz2Y8oaSAPWa36OL0RfwWy/w2AsGzSHlpQtdLmGHxu8YCOV/91HH9 iu2oZgzqe52V5ZW4D5ZW/zklcS9jFEfZpGMGjBvxmQ6XwWIhGgcrKhUouOD1wTBWqOTC 2FsfYZMh7N+oOpE7b/fzdIdY/MmVsYAY6flRi/6njE80aYieVG2arObQWEhImjxhf0Ry g8Y3cXg6vAukk69x02st0+aKmcgYj2VYavqjwKPV3DkDTXHr0CysIHcuvaa/+uzlvWK3 Q6Jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766591445; x=1767196245; h=mime-version:user-agent:autocrypt:references:in-reply-to:date:cc:to :from:subject:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QSdmNzll22GS36dUZyYftlYEWLa006on7/6Z+DJM0ag=; b=hX29DEQ0RH/QW7TGU7NhX9CJN6j9OyT6tKnnkK9ZHzFovLFYPFRhjlOog+4hsct68a 1I0xdR54M1AujVM0PklTYxnc9aDFvmhTIjwvEydE5wWgnXs38NS73IM9AQSEzoS/43MP wUBVFsLgEV1wGe4iAn5v2uHhSoOJt3wZCjl83aSPiXilpQhVRVymhLorJy7ynXmW8hXF rtOsEABwAHCVbMaD/I6pAAfFALcZIGGyD4mJv1afCTSCOlOHHc8AqmE8rO9DZbAIa4JQ feOkiXwVCJJaeGd6ddVhDu7v8II2JtGSJ2GgOjlYJR7P2Pf7ROhjxAJ0aCy9KYJLWLPk 0fZg== X-Forwarded-Encrypted: i=1; AJvYcCWIsqsPiqebdBg0WSBmuHS76umvDRZu1sqjx3gxwnbhGU65P7gYhpZNbG1hdhdvw5rRniBuPIProRKgFDY=@vger.kernel.org X-Gm-Message-State: AOJu0YwCcPasV4PJkjeTYX/T+D20Rm79KJQ1rsHY8kyipmJFzORzvmIS 64RCETtKGvwIOh2vZLnLZoctK+241nVQPS3Kby0iUuxkSF0wz+DJQZiI0CwohTuX7Y0= X-Gm-Gg: AY/fxX4ODmZtX7GOh7WgbMSVHHyGMdhUTdzbHhLda8+/uT9Js5pln8bwvYrXjfsCwj5 vRatjQFUmMSAHcugRpfRu2uEf6sJgumBzuQ3LiqIPlkHPUyIg1p5l92C78cgVO38yZsERh5CjKv jGp5SVnIPiaZ+Ca5HbVmHezxdM3NIvMV7xzoWVtA47zLlcrnBMdDPy6DGMf7cywORcS/js2P2Xe 2LX3Wnrb4TgaRr0e6rjPHlVV5joeldvXV+ZJXiqLNxEAnsyG9IiW8xcMBPil9uY7x6gGRtCvNU6 v00iOMPyF56tzaO6doNes0GR2hNexpol2wHbxYYAZn5dPLmlFKz4ia5DrGvompT7tDqFkhY/L9U bqaAxRFGrxsRYJmLc8EBWae+a+dLY325beINMZV50DpOUZeZZtt+5i2IfKhowtqb5B+HuUQ7OoL CbJKyNdMLPggKiLh12 X-Google-Smtp-Source: AGHT+IHFpvl7atlI/XfDElSp1cFHnazASDvVJwr4LLKxB3XCrMdiPROiP2O9X2LigLf12PzE9tOSRw== X-Received: by 2002:a05:622a:4013:b0:4ee:4a8b:d9ed with SMTP id d75a77b69052e-4f4abda9f56mr233284001cf.58.1766591444898; Wed, 24 Dec 2025 07:50:44 -0800 (PST) Received: from ?IPv6:2606:6d00:17:7b4b::c41? ([2606:6d00:17:7b4b::c41]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4f4ac62d53dsm127169351cf.19.2025.12.24.07.50.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Dec 2025 07:50:44 -0800 (PST) Message-ID: Subject: Re: [PATCH v2 15/22] media: rockchip: rga: share the interrupt when an external iommu is used From: Nicolas Dufresne To: Sven =?ISO-8859-1?Q?P=FCschel?= , Jacob Chen , Ezequiel Garcia , Mauro Carvalho Chehab , Heiko Stuebner , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Michael Olbrich Date: Wed, 24 Dec 2025 10:50:42 -0500 In-Reply-To: <20251203-spu-rga3-v2-15-989a67947f71@pengutronix.de> References: <20251203-spu-rga3-v2-0-989a67947f71@pengutronix.de> <20251203-spu-rga3-v2-15-989a67947f71@pengutronix.de> Autocrypt: addr=nicolas@ndufresne.ca; prefer-encrypt=mutual; keydata=mDMEaCN2ixYJKwYBBAHaRw8BAQdAM0EHepTful3JOIzcPv6ekHOenE1u0vDG1gdHFrChD /e0J05pY29sYXMgRHVmcmVzbmUgPG5pY29sYXNAbmR1ZnJlc25lLmNhPoicBBMWCgBEAhsDBQsJCA cCAiICBhUKCQgLAgQWAgMBAh4HAheABQkJZfd1FiEE7w1SgRXEw8IaBG8S2UGUUSlgcvQFAmibrjo CGQEACgkQ2UGUUSlgcvQlQwD/RjpU1SZYcKG6pnfnQ8ivgtTkGDRUJ8gP3fK7+XUjRNIA/iXfhXMN abIWxO2oCXKf3TdD7aQ4070KO6zSxIcxgNQFtDFOaWNvbGFzIER1ZnJlc25lIDxuaWNvbGFzLmR1Z nJlc25lQGNvbGxhYm9yYS5jb20+iJkEExYKAEECGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4 AWIQTvDVKBFcTDwhoEbxLZQZRRKWBy9AUCaCyyxgUJCWX3dQAKCRDZQZRRKWBy9ARJAP96pFmLffZ smBUpkyVBfFAf+zq6BJt769R0al3kHvUKdgD9G7KAHuioxD2v6SX7idpIazjzx8b8rfzwTWyOQWHC AAS0LU5pY29sYXMgRHVmcmVzbmUgPG5pY29sYXMuZHVmcmVzbmVAZ21haWwuY29tPoiZBBMWCgBBF iEE7w1SgRXEw8IaBG8S2UGUUSlgcvQFAmibrGYCGwMFCQll93UFCwkIBwICIgIGFQoJCAsCBBYCAw ECHgcCF4AACgkQ2UGUUSlgcvRObgD/YnQjfi4+L8f4fI7p1pPMTwRTcaRdy6aqkKEmKsCArzQBAK8 bRLv9QjuqsE6oQZra/RB4widZPvphs78H0P6NmpIJ Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-6E1pOz363AUSc4hyqasF" User-Agent: Evolution 3.58.2 (3.58.2-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 --=-6E1pOz363AUSc4hyqasF Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Le mercredi 03 d=C3=A9cembre 2025 =C3=A0 16:52 +0100, Sven P=C3=BCschel a = =C3=A9crit=C2=A0: > From: Michael Olbrich >=20 > The RGA3 and the corresponding iommu share the interrupt. So in that > case, request a shared interrupt so that the iommu driver can request > it as well. >=20 > Signed-off-by: Michael Olbrich > Signed-off-by: Sven P=C3=BCschel Reviewed-by: Nicolas Dufresne > --- > =C2=A0drivers/media/platform/rockchip/rga/rga.c | 3 ++- > =C2=A01 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/media/platform/rockchip/rga/rga.c > b/drivers/media/platform/rockchip/rga/rga.c > index f28ec88c186fa..1bfc4021f4a7b 100644 > --- a/drivers/media/platform/rockchip/rga/rga.c > +++ b/drivers/media/platform/rockchip/rga/rga.c > @@ -718,7 +718,8 @@ static int rga_probe(struct platform_device *pdev) > =C2=A0 goto err_put_clk; > =C2=A0 } > =C2=A0 > - ret =3D devm_request_irq(rga->dev, irq, rga_isr, 0, > + ret =3D devm_request_irq(rga->dev, irq, rga_isr, > + =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 rga_has_internal_iommu(rga) ? 0 = : IRQF_SHARED, > =C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 dev_name(rga->dev), rga); > =C2=A0 if (ret < 0) { > =C2=A0 dev_err(rga->dev, "failed to request irq\n"); --=-6E1pOz363AUSc4hyqasF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTvDVKBFcTDwhoEbxLZQZRRKWBy9AUCaUwL0gAKCRDZQZRRKWBy 9LU3APkBQSKkig2rWR6l9nTBHBKlDlfrlSgOBpfmOmasl3/xlwD/f5YFD3P7hHgs 8Jh8k6G/iOd6tWyXItvEbDbD2Trhzgs= =KLzg -----END PGP SIGNATURE----- --=-6E1pOz363AUSc4hyqasF--