From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Josua Mayer <josua@solid-run.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Johannes Berg <johannes@sipsolutions.net>,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: net: rfkill-gpio: add reset-gpio property
Date: Tue, 19 Mar 2024 11:25:59 +0100 [thread overview]
Message-ID: <d096d9ea-39db-4a15-9c4d-ae228db970cb@linaro.org> (raw)
In-Reply-To: <20240319-rfkill-reset-gpio-binding-v1-1-a0e3f1767c87@solid-run.com>
On 19/03/2024 11:13, Josua Mayer wrote:
> rfkill-gpio driver supports management of two gpios: reset, shutdown.
> Reset seems to have been missed when bindings were added.
No, you do not add properties just because driver supports them.
Bindings are for hardware, not for drivers.
You now revert all the comments from v1, without actually addressing them.
NAK. Or provide rationale why my previous comments, from adding the
binding, should be reversed/ignored/overruled.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-03-19 10:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 10:13 Josua Mayer
2024-03-19 10:25 ` Krzysztof Kozlowski [this message]
2024-03-19 11:27 ` Josua Mayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d096d9ea-39db-4a15-9c4d-ae228db970cb@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=johannes@sipsolutions.net \
--cc=josua@solid-run.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®