From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Alex Deucher <alexander.deucher@amd.com>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/ttm: add __user annotation in radeon_ttm_vram_read
Date: Thu, 1 Apr 2021 15:09:45 +0200 [thread overview]
Message-ID: <d09f16d8-528e-2815-8f26-ab85c27b1fea@gmail.com> (raw)
In-Reply-To: <20201024004706.24518-1-linux@rasmusvillemoes.dk>
Am 24.10.20 um 02:47 schrieb Rasmus Villemoes:
> Keep sparse happy by preserving the __user annotation when casting.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Reviewed-by: Christian König <christian.koenig@amd.com>
Going over old patches and stumbled over that once.
Alex did you missed to pick it up?
Regards,
Christian.
> ---
>
> kernel test robot has already started spamming me due to 9c5743dff. If
> I don't fix those warnings I'll keep getting those emails for
> months, so let me do the easy ones.
>
>
> drivers/gpu/drm/radeon/radeon_ttm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
> index 36150b7f31a90aa1eece..ecfe88b0a35d8f317712 100644
> --- a/drivers/gpu/drm/radeon/radeon_ttm.c
> +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
> @@ -1005,7 +1005,7 @@ static ssize_t radeon_ttm_vram_read(struct file *f, char __user *buf,
> value = RREG32(RADEON_MM_DATA);
> spin_unlock_irqrestore(&rdev->mmio_idx_lock, flags);
>
> - r = put_user(value, (uint32_t *)buf);
> + r = put_user(value, (uint32_t __user *)buf);
> if (r)
> return r;
>
next prev parent reply other threads:[~2021-04-01 18:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-24 0:47 Rasmus Villemoes
2021-04-01 13:09 ` Christian König [this message]
2021-04-01 21:15 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d09f16d8-528e-2815-8f26-ab85c27b1fea@gmail.com \
--to=ckoenig.leichtzumerken@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®