From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46A02142E83 for ; Mon, 23 Feb 2026 14:17:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771856278; cv=none; b=FvpHfXzSyHm7Dtkv/bwXplQrrTW6Oy64lwUlZGkHYpkcz/t+Lb0cLk6Vdje9JTp5opCn4V+IpnnijcNlrm9BMmNmFCVIfM04RCguGw9EbWaxj9Ktu/dmmwNDW5A1PohXFeXeRrb4g3R4UyPR3SNvQeNHwY796P90Py/LKGOD8GE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771856278; c=relaxed/simple; bh=JWsui+EWFnQrBmHYf1mqBxCA3Tuwor+dau8D8mdOYVA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gyyA0VTvWbzOQNb/8tPvNAoBR4j26UhIs4fxihIc1bqJPFw8pKAcT/QOgy0SwSYG4AiWBoVsgnvPyzoK6bKkakbXlqD1l6LAzWKhu688Qv+j53Eqv3rmwfmjCEuhhHSB2frTXLCKk0kZsEdXxh9HCgXCg0bjdK8vXY/pZwZnXpk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=A1zphGZg; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="A1zphGZg" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771856275; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9nFQ8yLvXH/beCpBhgLReW9OM7l5WZuY8fuKFKXKbMY=; b=A1zphGZgaoQJ17rbBkxrm8X2j/Yibxh/L/iA8CyXt+ctvxRBAwfenyt1RyTZcuQosMrkbq xxgqFN8cQxkO666lwWM5415AVO53xOSHdZ/YRgHhfpqnbTlo+ddOBFVMqCXCn0tDgrYi3l B51ugaX0wm0pXOf26cw6mxF65WLDwmI= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-553-VBDO78dHNviaeI-HvsoW1Q-1; Mon, 23 Feb 2026 09:17:51 -0500 X-MC-Unique: VBDO78dHNviaeI-HvsoW1Q-1 X-Mimecast-MFC-AGG-ID: VBDO78dHNviaeI-HvsoW1Q_1771856270 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 32CD1195605A; Mon, 23 Feb 2026 14:17:50 +0000 (UTC) Received: from [10.44.32.92] (unknown [10.44.32.92]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 956213000C26; Mon, 23 Feb 2026 14:17:47 +0000 (UTC) Message-ID: Date: Mon, 23 Feb 2026 15:17:46 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] dpll: zl3073x: Remove redundant cleanup in devm_dpll_init() To: Felix Gu , Prathosh Satish , Vadim Fedorenko , Arkadiusz Kubalewski , Jiri Pirko , Jakub Kicinski , Przemek Kitszel Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260223-dpll-v1-1-d99f18c12bae@gmail.com> Content-Language: en-US From: Ivan Vecera In-Reply-To: <20260223-dpll-v1-1-d99f18c12bae@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 On 2/23/26 2:20 PM, Felix Gu wrote: > The devm_add_action_or_reset() function already executes the cleanup > action on failure before returning an error, so the explicit goto error > and subsequent zl3073x_dev_dpll_fini() call causes double cleanup. > > Fixes: ebb1031c5137 ("dpll: zl3073x: Refactor DPLL initialization") > Signed-off-by: Felix Gu > --- > drivers/dpll/zl3073x/core.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/dpll/zl3073x/core.c b/drivers/dpll/zl3073x/core.c > index 63bd97181b9e..4ad21caec0e8 100644 > --- a/drivers/dpll/zl3073x/core.c > +++ b/drivers/dpll/zl3073x/core.c > @@ -982,10 +982,8 @@ zl3073x_devm_dpll_init(struct zl3073x_dev *zldev, u8 num_dplls) > > /* Add devres action to release DPLL related resources */ > rc = devm_add_action_or_reset(zldev->dev, zl3073x_dev_dpll_fini, zldev); > - if (rc) > - goto error; > > - return 0; > + return rc; Please use: return devm_add_action_or_reset(...); Otherwise, LGTM. With this change: Reviewed-by: Ivan Vecera