From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E8CF23BD1D for ; Fri, 17 Jul 2026 00:55:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784249753; cv=none; b=LuYHAvyzb5i1IigenwTGq1NTqiQLOH2OsbPOnUGe6fBjAt7ZMawp9mk9p1Xg7Vskly5L2qVYVdZ1CVT7f5lBlKc69py6FTzWR//3VE9maQ9sHC459GEwkBgNoZFFlTfYDwOyewNwYEdt0SNXAMUZ7XtrIyDyjTEkLhZwhYHxYR0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784249753; c=relaxed/simple; bh=Xq34X2noVjeCL+mTpDb/txKUMVnfWZdmoEuJ3aEBHhw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cyBRYlnIeUVZMYC3/uq/enIJg4GHGhdcdlsR7ZHFG00QH5CgshU8HZTtoS9oSXLw8Do+n0lmIa0uTMWQ7EzTjzW8EK/c0YEzQxNJzn0hiSRMr2SbQ/Pq44L2xrtOyDCAT92aEtoIc8/kRhy1sVoo6kiSKdeGYg9S8u8pe8iAK+c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=GTj/Pdxy; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=r7nEvheC; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GTj/Pdxy"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="r7nEvheC" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784249750; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=L/IG5aO0gBvVFr90gKLy67IML5GL+6QNMuZQAkI7UIY=; b=GTj/Pdxy+yrCs7644bf6yJ3pd4XrMk7pGREMnqZMfA1q1l5+tdJ9eFj1aBE5XT4gxLzbQD iEQCUBa7l6HziQ/zwmUyWI2jC+BkVWRNNual5qAZua4E686AwC5rG8VqLiQtir8ZR5wTt4 i7GQqMXPv4xWDbrphUPqZ3s2HIhMakc= Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-672-ks3WLJlINWGvvxYuiAMAbQ-1; Thu, 16 Jul 2026 20:55:48 -0400 X-MC-Unique: ks3WLJlINWGvvxYuiAMAbQ-1 X-Mimecast-MFC-AGG-ID: ks3WLJlINWGvvxYuiAMAbQ_1784249747 Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-388b404eaa4so9546378a91.0 for ; Thu, 16 Jul 2026 17:55:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1784249747; x=1784854547; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=L/IG5aO0gBvVFr90gKLy67IML5GL+6QNMuZQAkI7UIY=; b=r7nEvheCGI8m/D/wT03yT/9rzZAMWdE7+riki87HbtffetUv1fon9BAgsvix+TM5jY ERJp5EDSoX5wVfVEYirpQy19TqSko1cBx9cRyxPWy5nq/dXnv1gmxJsybY8Wl20hqvkZ CErWdk7oJhC90xat+0k9K4N6MmqqPIiietJk2chAwr9MR1ANuOJE/pcHuzhsimwUgWxZ JK85170GnySl7mK2AVK11gduiipFGtL7oB4py4uIFbAdKnTn6rd0mGdeuS/k4rocvM7C GCO6wlZ18Ix04rjHmM7+4TL6iNiNHC30uYbU5pa8buI93jz4C7uRe/2UqC4CaqjLaikv PiLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784249747; x=1784854547; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=L/IG5aO0gBvVFr90gKLy67IML5GL+6QNMuZQAkI7UIY=; b=bDFtCfNYIRgt/VqMHkg3+bn6V27rPHYPTN7vs/Tpk6XKgOmoBRlPOk7pukCERFES+0 +Fw1OJz9yDssW3yJi251iTzJjauVDcibafvw81WcyKujx4Erqd8gVdtrv5uGHaoiy7Vb huHC7cKrvTmep+kh/T3UcwKWiOIqzMjHCi8UzFpExZZnEUdfAB/eTCmrJz1gcuD4u92X dkUyVqP77DmXkBK2FD4fl284hZXBnXL/vLaAfKq2/cpu0CwCXb/LGlvjtAlNH8EgEeqy 8TpNgq67LMEAYChJ0aJBf+JyLb49oOiZqyAl64nvsVemXmuZvEUA3cn6k5d0fLqcHXxJ qruw== X-Forwarded-Encrypted: i=1; AHgh+Rq6Y7Pf3xudV4NYdtMK1a5etz5u8TJpYscuRR+O2/YuVq0OwW+Jt7VnIX+t+6bypM2r9Md9VWfr8jmH20M=@vger.kernel.org X-Gm-Message-State: AOJu0YyPznafMsdlIyqTati+bBy/ebfGYttQ+gCZwBfzaq7uEdO5PN9G GRrJEYPoAQD1jXnjy7mKCTrxlRc5Lyn6L/5nJ+nKbtP/tOckAjyP5F1Ssm+ydNIFmlE/DAfKOy8 QOaU07HmuLgJmC+uzHH0+eWdAR/ik191ML0OhfZP/9SuEQT/nvDrOWQxMZPLwQ10Upw== X-Gm-Gg: AfdE7cn2RelMu1GY+yXDrYJCLuWpX4MlHhlYCRFltoCDX34jEAaYI9eEC7D36IcFCxB sJRyk6G9RT4/deFk0XovlP4fKtctLYxfYeAeHtPAjujXwnW9sT9+2Yz+htNYN9jOSDWJq/Pd+hi JTP6tSa7QiCzv4gCDLzgNaxqpYU/fvEmqWOmvclhCbFGaTHNd+q7GZslh2Vnwb51CECUQPT2gsc i2djGNvqE+OWAtIFTBCbr5agkc+Q5WPQRGLfA8hnFIC9mgJmwompex0L1O7o+EKAVktARYosbxE qKZd7ioUn2lpHtF+OGz4UYXg2KTJe7V9TzL7cvWuEFvF8Jo/66GJsCyJj3FbJpKTKSF3X5/V06n MngOxb3gWTzjQ4szBM+naPDqmv1ymL4rx2jfhah4R55I= X-Received: by 2002:a17:90b:5390:b0:36a:8240:2477 with SMTP id 98e67ed59e1d1-38e4b47be8emr363194a91.19.1784249747387; Thu, 16 Jul 2026 17:55:47 -0700 (PDT) X-Received: by 2002:a17:90b:5390:b0:36a:8240:2477 with SMTP id 98e67ed59e1d1-38e4b47be8emr363174a91.19.1784249746927; Thu, 16 Jul 2026 17:55:46 -0700 (PDT) Received: from [192.168.68.51] (n175-34-8-244.mrk21.qld.optusnet.com.au. [175.34.8.244]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38e4afcc117sm145661a91.3.2026.07.16.17.55.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Jul 2026 17:55:46 -0700 (PDT) Message-ID: Date: Fri, 17 Jul 2026 10:55:40 +1000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 06/11] arm_mpam: Use __ris_msmon_read() for saving MBWU state To: Ben Horgan Cc: james.morse@arm.com, reinette.chatre@intel.com, fenghuay@nvidia.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dave.martin@arm.com, andre.przywara@arm.com References: <20260710115546.29644-1-ben.horgan@arm.com> <20260710115546.29644-7-ben.horgan@arm.com> Content-Language: en-US From: Gavin Shan In-Reply-To: <20260710115546.29644-7-ben.horgan@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/10/26 9:55 PM, Ben Horgan wrote: > mbwu_save_mbwu_state() reads the MBWU counters and adds that to a saved > correction value. However, the type of counter to read is determined by the > RIS rather than the class and overflow is not taken into account. Fix this > and mitigate against further divergence by using the same helper as used > for user reads, __ris_msmon_read(). > > Fixes: 41e8a14950e1 ("arm_mpam: Track bandwidth counter state for power management") > Signed-off-by: Ben Horgan > --- > drivers/resctrl/mpam_devices.c | 33 +++++++++++++++++++++------------ > 1 file changed, 21 insertions(+), 12 deletions(-) > Reviewed-by: Gavin Shan