From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752983AbdEIJ2a (ORCPT ); Tue, 9 May 2017 05:28:30 -0400 Received: from mail-wm0-f45.google.com ([74.125.82.45]:35025 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752395AbdEIJ2Y (ORCPT ); Tue, 9 May 2017 05:28:24 -0400 Subject: Re: [PATCH] clk: meson: gxbb: fix build error without RESET_CONTROLLER To: Tobias Regnery , sboyd@codeaurora.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20170424100542.20226-1-tobias.regnery@gmail.com> <8556c66c-585f-d171-e2a8-1f59d109e9de@baylibre.com> From: Neil Armstrong Organization: Baylibre Message-ID: Date: Tue, 9 May 2017 11:28:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <8556c66c-585f-d171-e2a8-1f59d109e9de@baylibre.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/24/2017 12:10 PM, Neil Armstrong wrote: > On 04/24/2017 12:05 PM, Tobias Regnery wrote: >> With CONFIG_RESET_CONTROLLER=n we see the following link error in the >> meson gxbb clk driver: >> >> drivers/built-in.o: In function 'gxbb_aoclkc_probe': >> drivers/clk/meson/gxbb-aoclk.c:161: undefined reference to 'devm_reset_controller_register' >> >> Fix this by selecting the reset controller subsystem. >> >> Signed-off-by: Tobias Regnery >> --- >> drivers/clk/meson/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/clk/meson/Kconfig b/drivers/clk/meson/Kconfig >> index 19480bcc7046..2f29ee1a4d00 100644 >> --- a/drivers/clk/meson/Kconfig >> +++ b/drivers/clk/meson/Kconfig >> @@ -14,6 +14,7 @@ config COMMON_CLK_MESON8B >> config COMMON_CLK_GXBB >> bool >> depends on COMMON_CLK_AMLOGIC >> + select RESET_CONTROLLER >> help >> Support for the clock controller on AmLogic S905 devices, aka gxbb. >> Say Y if you want peripherals and CPU frequency scaling to work. >> > > Hi Tobias, > > I was going to push this, thanks for the patch ! > > Acked-by: Neil Armstrong > > Neil > Applied on fixes/meson-clk-drivers Thanks, Neil