From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19BFE311946 for ; Thu, 19 Mar 2026 10:22:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773915773; cv=none; b=eebDkoCN34oNSNDOjUWrIm+PvayleX1jHM+hmVxDO5d2NOHMbJfads21i0TIBR+n/9A/S04Nltr67IrohRibWj860rOSFA4GZxIoFUxnHqsnErwW9ude51mMv2XDAER41qLvWXVN9ds83rOWya7ajoe6KwsSykWKH5LJb4ye0tU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773915773; c=relaxed/simple; bh=jI3T4fyaHJI7Z6XuDHJkgpVgH5BlNdf8DNKrN8B7PzA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=STLUhhoxBtmgKEup05hI/rFIIPNF6PkV4QZLPGGhK5aI9062b94SkWvm8y/4f0JdGAOtBLFO8q4Gnu2vETIQDqCu4BJ51ucQyPLU0xeTBTaLTU9dmN4JBcgp27Q16oWuu83MF4Oz9fCqV9gp+C12MPPOYibF3wBhpKNK71PLUrc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=jPnJh2lM; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=iESOMyTY; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="jPnJh2lM"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="iESOMyTY" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773915770; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wR/FecceBEZR/0EE/23yp6rr47owa2Fbfb4UxboXmxo=; b=jPnJh2lMp7kb5lBt5li1r1XHchHOIK4yyPEYvUjvk/64XkzVi5UiJyNf1Naz6BK/UYs/9B n6geLFRdBsK/+lBo3y6o8jXUeaqDHRPM1OkW1v2sbSVL8R/N2+6WYPO1rT/6FOZjG1yql/ yB3zd8hdLQLSXFXtWv9AZdxaEaMvZXg= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-115-O8WGl_L6PLa-DU5hplT3uw-1; Thu, 19 Mar 2026 06:22:49 -0400 X-MC-Unique: O8WGl_L6PLa-DU5hplT3uw-1 X-Mimecast-MFC-AGG-ID: O8WGl_L6PLa-DU5hplT3uw_1773915768 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-486fb142205so4175915e9.1 for ; Thu, 19 Mar 2026 03:22:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1773915768; x=1774520568; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wR/FecceBEZR/0EE/23yp6rr47owa2Fbfb4UxboXmxo=; b=iESOMyTYksoObvFcqstvFxcykWzlrXhnY2Sz5gzqsIEaZciKIBXLMF5hn061STe0xS A7dmjd8GJEHWR1v2Hdz7PMOU1NDZ6LE4mgpe8+NyurKvIlDNr8Z5mHfa9wJLr4iJY/jR Taj4vpBcAboVqvCMTFuJ/Tc6lj0GP5d3QBNRENGLiVTjDiBscKnH9tVYMzCkgD4eNzIo 8IlGVuEwGB4/5uU/L3hb8LvvD/eMC29rCI/E24vSr1P8mmuLMhd3mc0rkwyv1FbnGHLX u9zgLo7W0ZyFM2/pfDf08Ytq6RtJCUrF6PUHm0QuYLtdNn5AETigPTaKfpe0+OGdOQhR vynA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773915768; x=1774520568; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wR/FecceBEZR/0EE/23yp6rr47owa2Fbfb4UxboXmxo=; b=iH8XeeRDukBt7wbn4p2YmnIddnVA1DaDktCjgwl5cB4ZYS3ERh+avaTfxjDZGeiz1Z et5yjLykKgTcoagkogSv8RooWT4Mmw1Fp23bh8O4JmEIll10P2DwRRHo7IW0gcvGydfd NEbKKc++qwgHEYkozOTg87xDjIm30ee/ulHbhwN2PJUl6OTzrmoST/J/I2zJm0TsduJF QwRnOuDttnbKxXmKimUnsLrUcR47We6IUt4DLbUHG/lhJkRPQeG5OGfVF9Zdy8F/SZBh /H38tYYH7BeaZ9CdsabvBmSfb34tv53pcQK3viwmJrx44Qe75cyOxwH/iHYg00SFfeoW 2bOQ== X-Gm-Message-State: AOJu0YxRT4A4V0zVQP/MVRPp52dRNWoVeacfL3Td6pplRHzuVJ67jY2t JT0YfgInlWe9TiZUa9FBhGpWjzUc+dH2khZAAJj6m5s6zg/Oq6VcKPBNTWM0/a+r4W142rzv22y EL9ICkyPxQ5mj5A0nKF3XDKvpgrnMpLSTrNT56iHFiJ6DevnKqU7HGFpqGfmQ8FKw1w== X-Gm-Gg: ATEYQzzbBnSlkShoVQhlef6hPUoBfz5fjK4xDB93ssA1ZSk00imbKJs+VT1yXagPwtq QE3VaAQgDlr3Fjet5U4QmUIZTE8Gdr4bGVrWLKd/tMpgS6PltN4C0hxGivF8RhjTqiVYXlEjvzu fN7r2KtWNt8/aGjCm4/ozQ58kYmJ7BRdSZ1BuEaoW3JUQksMN3hN4abjcGdTqWrkRLiqWxvBCU2 fVQgfQIEv+i9B6Le3jxP75oSFFwelD3KykXdZFZWM9ZZYdBi6QkvhJnWr8zCdK3U98+s1t95OXk EpnU1zJEwE2KepCrFsTGL0f6ZyQmu3COcyQuwiMOmmeesGJu/67c0r8TIngjo657mhLDqpF6KaJ MFQKbSHdryGJaHWSB3XSxq0gI1Lnzu1BuP0x+VpiHAy2bMHC6Q9UBQdjW X-Received: by 2002:a05:600c:4e4a:b0:485:ae14:8192 with SMTP id 5b1f17b1804b1-486f442d3d1mr109792205e9.7.1773915768394; Thu, 19 Mar 2026 03:22:48 -0700 (PDT) X-Received: by 2002:a05:600c:4e4a:b0:485:ae14:8192 with SMTP id 5b1f17b1804b1-486f442d3d1mr109791725e9.7.1773915767939; Thu, 19 Mar 2026 03:22:47 -0700 (PDT) Received: from [192.168.88.32] ([216.128.11.196]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486fbea40c2sm32983445e9.5.2026.03.19.03.22.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Mar 2026 03:22:47 -0700 (PDT) Message-ID: Date: Thu, 19 Mar 2026 11:22:45 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 1/3] selftests: packetdrill: stop pinning rwnd in tcp_ooo_rcv_mss To: Wesley Atwell , netdev@vger.kernel.org, ncardwell@google.com Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, davem@davemloft.net, dsahern@kernel.org, edumazet@google.com, horms@kernel.org, kuba@kernel.org, kuniyu@google.com, shuah@kernel.org References: <20260317065137.1533226-1-atwellwea@gmail.com> <20260317065137.1533226-2-atwellwea@gmail.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20260317065137.1533226-2-atwellwea@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/17/26 7:51 AM, Wesley Atwell wrote: > tcp_ooo_rcv_mss.pkt cares about the OOO SACK state and the resulting > tcpi_rcv_mss update. > > Its exact advertised receive-window value is incidental to that test and > can legitimately move when unrelated rwnd accounting changes adjust the > ACK window. > > Drop the hard-coded win 81 checks and keep only the ACK/SACK shape and > the tcpi_rcv_mss assertion. I think it would be better to keep the test updated with the kernel behavior. Having the pktdrill tests bundled together with the kernel allows for tightly coupling. @Neal: WDYT? /P