From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B952C3DA6B for ; Wed, 31 Aug 2022 01:54:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230502AbiHaBx6 (ORCPT ); Tue, 30 Aug 2022 21:53:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229630AbiHaBxz (ORCPT ); Tue, 30 Aug 2022 21:53:55 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8943DB02A9; Tue, 30 Aug 2022 18:53:54 -0700 (PDT) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4MHRtd2WtszYd10; Wed, 31 Aug 2022 09:49:29 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 31 Aug 2022 09:53:52 +0800 Subject: Re: [PATCH] kvm: x86: mmu: fix memoryleak in kvm_mmu_vendor_module_init() To: "Huang, Kai" , "Christopherson,, Sean" CC: "x86@kernel.org" , "dave.hansen@linux.intel.com" , "hpa@zytor.com" , "mingo@redhat.com" , "tglx@linutronix.de" , "bp@alien8.de" , "kvm@vger.kernel.org" , "pbonzini@redhat.com" , "linux-kernel@vger.kernel.org" References: <20220823063237.47299-1-linmiaohe@huawei.com> From: Miaohe Lin Message-ID: Date: Wed, 31 Aug 2022 09:53:52 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/8/31 6:42, Huang, Kai wrote: > On Tue, 2022-08-30 at 21:40 +0000, Sean Christopherson wrote: >> On Tue, Aug 23, 2022, Miaohe Lin wrote: >>> When register_shrinker() fails, we forgot to release the percpu counter > >>> kvm_total_used_mmu_pages leading to memoryleak. Fix this issue by calling >>> percpu_counter_destroy() when register_shrinker() fails. >>> >>> Fixes: ab271bd4dfd5 ("x86: kvm: propagate register_shrinker return code") >>> Signed-off-by: Miaohe Lin >>> --- >> >> Pushed to branch `for_paolo/6.1` at: >> >> https://github.com/sean-jc/linux.git >> >> Unless you hear otherwise, it will make its way to kvm/queue "soon". >> >> Note, the commit IDs are not guaranteed to be stable. > > Sorry for late reply. > > The commit message has "we". Should we get rid of it? Sean has kindly tweaked the commit message. Many thanks both. BTW: Is it unsuitable to use "we" in the commit message? If so, I will try to not use it in later patches. Thanks, Miaohe Lin