From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA8DA1AB912 for ; Thu, 20 Jun 2024 11:34:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718883249; cv=none; b=Kle1ApJZhIdZQlytq334zoToLBIzUQ6HKtzmzo0smDxiS2eEYMivQ3/lk9NaTMCO9CrI99Rul7m6/5+fvDTUBKZyVd3rU/lnLo+7aMoOc/HlWq8urGa0qssw1dnXtDHz6ynw6BG5Ecul4SNawKjSTO796IwjEA5jEueZ+Ny5WRw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718883249; c=relaxed/simple; bh=mF+bdyjinq6Vn5fzXWPKuTIhkeaBZ0XZIHAmz8B6ojI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lYfzzQ0dPoq22xm/enDg+4rKLxHxZDZ25sv9gs27Drs5a2AlUOXLD+mtv75L1GvTmvDe2W36PLzp4RjNcBUPn8MN5mxlMsRsd0rMqw8zRh8Df3+pUMMHKpOeX6Rfzym9ys1M12gMOiVXLyPHmUYxtyuf87xUoaURmwTNpB4qSgc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=IDjKjWbc; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IDjKjWbc" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718883246; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=48uMSb3XQmRcndFEBSyjvxLuZw9qFtbAeLLtQCpxcKw=; b=IDjKjWbclpImeeM2lokbfvEyCmkIh8NE0p8VKZjZwbFT2m9kMgE9aqsgN1XwAYP9eNEBy1 STgjs9vmw9ehA2c4mSr/6m9CauhZy6pXkPltDBTgo9TqlfAZYxUZik6S6RB/l/+GlL/GCG KLGiN+ao7slpwCpoTT3IqRKnZv/PKOY= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-315-yI-YT4cgP0utr4LzMNrVaQ-1; Thu, 20 Jun 2024 07:34:05 -0400 X-MC-Unique: yI-YT4cgP0utr4LzMNrVaQ-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4247d49a373so4838995e9.1 for ; Thu, 20 Jun 2024 04:34:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718883244; x=1719488044; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=48uMSb3XQmRcndFEBSyjvxLuZw9qFtbAeLLtQCpxcKw=; b=iRUCys0V881cQhEr9uDHb6DjakDGws+u4FOonA6SLAemPolEpsRJQtLfI3oDQF/4Oe LgFN5oQApeviUXLVmO6wMswYKaEzXZRn9i0lw6Qmvti/jxhizPeAv2W2QSNKYQQBIua+ G7DBiZUPEB6wDJ90I0iWmGAWx1+SM40PAfnzNzhg+2U8uHlQjnBRLbCJy9ltNcALj8f5 tY7l/R9jhKRFkctDJnOja58IAgtPq4BeM6QSOhBzxw+1FkxTcFLr8CBXegOliOnWzzab Glw0QwG5Bf+vaNr2F0EY8VfbjaBBG/KOppRNcfj851A6MuIKJKIaHWKYfIyw6r09GjuO lCJA== X-Forwarded-Encrypted: i=1; AJvYcCVbQjfvPS1ES/udkGeJBGYFUdVV1inp2uSg+JF3DhIsMtQP52HXy76LRI8m7T8ioEBo6kHNDQAu7rDUij3m5F+94zehKPYQQR8KIGRI X-Gm-Message-State: AOJu0YyZCAl87W/1+rHgPumARsbCpMecTq7TA9xsvGJg1rxzYnQLc8v0 sSp+Z3PfINGiGNRZfVRi28+x+f3015h1+OGUiQb/dZ8Tjr7hTJziGeKIOzOmIjxu0s5ZevsaB9e E3J7/aUJF0n6d7r4Ih3GVTcG9YuBwjxSEE2I001SnXNf+ZPsa9JvOddNBN0yBFg== X-Received: by 2002:a05:600c:22c9:b0:421:a575:99c9 with SMTP id 5b1f17b1804b1-42475180a22mr35613645e9.20.1718883244490; Thu, 20 Jun 2024 04:34:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG+gxLFhA6YR817ALtxUbcnfky/pm0YRBBStXqXm4QjjI7azdieywTSEVo5C7aQNuyXlKhmNA== X-Received: by 2002:a05:600c:22c9:b0:421:a575:99c9 with SMTP id 5b1f17b1804b1-42475180a22mr35613445e9.20.1718883243982; Thu, 20 Jun 2024 04:34:03 -0700 (PDT) Received: from ?IPV6:2003:cb:c719:5b00:61af:900f:3aef:3af3? (p200300cbc7195b0061af900f3aef3af3.dip0.t-ipconnect.de. [2003:cb:c719:5b00:61af:900f:3aef:3af3]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4247d0b8f37sm22818715e9.1.2024.06.20.04.34.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Jun 2024 04:34:03 -0700 (PDT) Message-ID: Date: Thu, 20 Jun 2024 13:34:02 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests/mm: Introduce a test program to assess swap entry allocation for thp_swapout To: Ryan Roberts , Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, shuah@kernel.org, linux-mm@kvack.org Cc: chrisl@kernel.org, hughd@google.com, kaleshsingh@google.com, kasong@tencent.com, linux-kernel@vger.kernel.org, ying.huang@intel.com, linux-kselftest@vger.kernel.org, Barry Song References: <20240620002648.75204-1-21cnbao@gmail.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 20.06.24 11:04, Ryan Roberts wrote: > On 20/06/2024 01:26, Barry Song wrote: >> From: Barry Song >> >> Both Ryan and Chris have been utilizing the small test program to aid >> in debugging and identifying issues with swap entry allocation. While >> a real or intricate workload might be more suitable for assessing the >> correctness and effectiveness of the swap allocation policy, a small >> test program presents a simpler means of understanding the problem and >> initially verifying the improvements being made. >> >> Let's endeavor to integrate it into the self-test suite. Although it >> presently only accommodates 64KB and 4KB, I'm optimistic that we can >> expand its capabilities to support multiple sizes and simulate more >> complex systems in the future as required. > > I'll try to summarize the thread with Huang Ying by suggesting this test program > is "neccessary but not sufficient" to exhaustively test the mTHP swap-out path. > I've certainly found it useful and think it would be a valuable addition to the > tree. > > That said, I'm not convinced it is a selftest; IMO a selftest should provide a > clear pass/fail result against some criteria and must be able to be run > automatically by (e.g.) a CI system. Likely we should then consider moving other such performance-related thingies out of the selftests? -- Cheers, David / dhildenb