From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15BA021E082 for ; Fri, 25 Apr 2025 21:01:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745614898; cv=none; b=LVT3J7BzyllKcy+d1rTpW1r0luWHwf7VF/pbx2Emkv+0ZMQaq9TlJwf/jy6e3tG3K+EVLqJyw24XhNVoujHG4J/kjDpL9FoU+lddPpK0iXZIqwcGF9mpkbaAREhoE5qirKFCIGB0M380JntWM1U2CanzYhzl60R8dMIgQ5RoTLI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745614898; c=relaxed/simple; bh=bI7Bp9z+dMZ5FzNgBxdPEBaZNV5aEQQUjTMGvshbDcs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Yi/mwAZBXHV0LJDo6ITUyKRu25KJyEFTjtfI1li9ReWFIud/mRoUzGZAnhc8Co1+EkdNfEuunfFY1bCyO/jwH3MTmHtX0/Ks+436kBYZOOjt9Ar/OsE86/ViTGXgz3b7oCRWjTscQvu0OeQxKLUn/Yh+ysHy9TZxcqBj9xcYcbc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=hpX20lYX; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="hpX20lYX" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53PGK17l021809 for ; Fri, 25 Apr 2025 21:01:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= xR1ahgPKwTVUbPyUmCySK93wxhHbaFR928o4V1MJnnA=; b=hpX20lYXYwJQFYLv 65JD6t7WCpXBJnZMIhwIaodfJv4aR4+NFx6yuZpvcSt96lLGThrosMMcbIHz7/Ln 8Z/+OqntQ0Oxy4DycP+hixUSU6Z/GkIjdHOnuEiYMNW/h7huPJjnoZLzxKkRYDpM GSNKiQqhLjC5GL7BjGyHLeg3RYSj6U/6lLWzfcCWJjII/7wL0jPbYVU1JGlPPtW5 cRqlql6WPnY8Wj1fs1EGUBtit0lVhWE1rKBHLNTp+Sj885oA+9mW7ID+ssU5ByFi hYQloyNQWdeJy2BzEBbrrTgcgapjMmalWf/L665F2odrOiY4jDbIeY12dpS7I60K TuU2qg== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 466jh5jasq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 25 Apr 2025 21:01:35 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-476783cbdb8so6136111cf.1 for ; Fri, 25 Apr 2025 14:01:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745614895; x=1746219695; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xR1ahgPKwTVUbPyUmCySK93wxhHbaFR928o4V1MJnnA=; b=eH//p0AbSFrNS2XDSdOHeqdGcWmWROvrFnx0oLLnJNSIUTz1HMEzK6qJ8dawhXMVkn dXW1DWpI6Q9MVpnZhssDww51MXIxV8zbw0SiBFcI+2ITOO/UR3OMf2Z4nkM6EYkyS27A AVSmPUAluxNDFGRIsKlR+EuQi7kq8RtLIGHnHGJ1PYrFe5c6nKh/VqNc6TEIFkE3d4ST 0L0RIp+06sH7/M571upSEFIxpnkhyEiL0sIjjr41XCPWaBj6iQHafHFp9XdbHMtCGCFJ AnYvDj1j0+x99R9dIX/02CvYPkzJb+uFHS+lTkmu8WoRwuydi3eGkVnk3NpkonzmHnlO HHvg== X-Forwarded-Encrypted: i=1; AJvYcCUrYEi7TWZ9XgyK0E0AeB1Z7TP/tcphtAoegYL3CrpKTeQwEO7wVFTieAk+UsXWs8CiS1cUNPSDipkkKZw=@vger.kernel.org X-Gm-Message-State: AOJu0YwXct8EdQ0v0BsFPLjeELswOHCKsqKexjgQP27wQ7tHBK0qzZuk AvMY2z9m2S0+h7zG/ydGjOkKqUOIx+uR9lYwmuMB+LS58novN8B3UpWIT0pWSr+mbquk6eV31jj fWSv5Mk7ncXK2oDz+wxoFt0Okm2mP4erV+zSWcZsLB6jlhDthHxy7x8czdBk7bsg= X-Gm-Gg: ASbGnct0FfXPMrZs2aj2wGKeQo2y4E1YuU+FbiTkvlY1Xn7/IcLcFq5g/kP7uN/Rs20 oI89TCPgx5xk4l3FZkcXTg23lEtBJmoAoHteTDBS6p773PynQGc+bJOl9L5WuoD+9bn8QPOwJub 4eaA2S9KgMwltuWTkwanUgjn/WKreKPi0LTy0eWGVMZCh43GukHoiMGCOUsPReq5l0tep2VzmcE V6PJKaIzFuZjpBAxrtxi9JrBYtKvvW2TEpinfDUOHVIgiv8WtJRHbWnb3fQSpoX+gEnwM4AIS27 VmGryyAEQrM3VdHQIg7qppB0UAzyL1NI5sbB5cuzk0MFdk/NAFHICM6w6EJ/RfH7Ry8= X-Received: by 2002:ac8:5a81:0:b0:476:af54:503f with SMTP id d75a77b69052e-4801c0d6cf0mr17928481cf.2.1745614895008; Fri, 25 Apr 2025 14:01:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHDD4DIsjJW/tCe2Z3iSjgVplvrQe6JD6qbHnxSZ6hgFtwLPBMqeYJtiD8Mox2CAsRHhGa6Sg== X-Received: by 2002:ac8:5a81:0:b0:476:af54:503f with SMTP id d75a77b69052e-4801c0d6cf0mr17928151cf.2.1745614894435; Fri, 25 Apr 2025 14:01:34 -0700 (PDT) Received: from [192.168.65.156] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ace6ed70606sm186518366b.160.2025.04.25.14.01.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Apr 2025 14:01:33 -0700 (PDT) Message-ID: Date: Fri, 25 Apr 2025 23:01:31 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 6/6] arm64: dts: qcom: x1e80100-crd: Define RGB sensor for cci1_i2c1 To: Bryan O'Donoghue , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robert Foss , Todor Tomov , Mauro Carvalho Chehab , Konrad Dybcio Cc: Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org References: <20250417-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v7-0-3fd4124cf35a@linaro.org> <20250417-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v7-6-3fd4124cf35a@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20250417-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v7-6-3fd4124cf35a@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNDI1MDE1MSBTYWx0ZWRfX8YpkTTrUv9Mp PgKJ8rrTR+y+urPfdWwLrRW5uncjsuS6yOZGtyNUWOdojA67NlZGGCJz2+BJSNkN9GceHqSkh3S Cl3gEde45LHvQDU4jXCmHBZqK4DAHXdmXZuG8TyRBQIiBo2XJ+ezPLD1Ln3NYLoWoY25ksquplN I6kjcQkSgFW2f3BIkdnaCH5loJOfEdNrElqSkhF09cl9cv3OsDotzw72ZVGjGNVDWwzlwPf/6FS fgn1ChE9zuJe7hHugByaAAn+fSgBGyN/rLN7l1+Fn6CtSECpqVf/Hh7OcogyykTo526P5QdcDOi /I2RgLElizbFfwq2laB27FPRwrcqxQBJbFFCo6nmHp0Avk6vYqVHXS+nRJFBLDtn6B+d8XXFc0v dFCaDlS3PrXt+3+jhWdY+49LiesyWi7+Dbe9SBX0vP86MRIzEUXlmwLzvyqRDLD6QsO7nTBa X-Proofpoint-GUID: LqySFkAh-F9gSazrMF6NIT6g1JQFPSrw X-Authority-Analysis: v=2.4 cv=B/S50PtM c=1 sm=1 tr=0 ts=680bf82f cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=KKAkSRfTAAAA:8 a=qEq-IjhxTDjyFSs2OvYA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: LqySFkAh-F9gSazrMF6NIT6g1JQFPSrw X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-04-25_06,2025-04-24_02,2025-02-21_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 mlxlogscore=915 lowpriorityscore=0 bulkscore=0 impostorscore=0 suspectscore=0 mlxscore=0 priorityscore=1501 phishscore=0 malwarescore=0 spamscore=0 clxscore=1015 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2504070000 definitions=main-2504250151 On 4/17/25 1:27 PM, Bryan O'Donoghue wrote: > Define ov08x40 on cci1_i2c1. The RGB sensor appears on the AON CCI pins > connected to CSIPHY4 in four lane mode. > > Signed-off-by: Bryan O'Donoghue > --- > arch/arm64/boot/dts/qcom/x1-crd.dtsi | 60 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 60 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/x1-crd.dtsi b/arch/arm64/boot/dts/qcom/x1-crd.dtsi > index 74bf2f48d93522d3f5b7ca990c06519ca664d905..048e49aa805c7239e1a22b59bd784683d1d0da08 100644 > --- a/arch/arm64/boot/dts/qcom/x1-crd.dtsi > +++ b/arch/arm64/boot/dts/qcom/x1-crd.dtsi > @@ -894,6 +894,66 @@ &gpu { > status = "okay"; > }; > > +&camcc { > + status = "okay"; > +}; CAMCC shall be enabled on all boards unconditionally, if only for unused clock cleanup to always take place peacefully > + > +&camss { > + vdd-csiphy-0p8-supply = <&vreg_l2c_0p8>; > + vdd-csiphy-1p2-supply = <&vreg_l1c_1p2>; > + > + status = "okay"; > + > + ports { > + /* > + * port0 => csiphy0 > + * port1 => csiphy1 > + * port2 => csiphy2 > + * port3 => csiphy4 > + */ That's SoC-specific AFIACU > + port@3 { > + csiphy4_ep: endpoint@4 { > + reg = <4>; > + clock-lanes = <7>; > + data-lanes = <0 1 2 3>; > + remote-endpoint = <&ov08x40_ep>; > + }; > + }; > + }; > +}; > + > +&cci1 { > + status = "okay"; > +}; > + > +&cci1_i2c1 { > + camera@36 { > + compatible = "ovti,ov08x40"; > + reg = <0x36>; > + > + reset-gpios = <&tlmm 237 GPIO_ACTIVE_LOW>; > + pinctrl-names = "default"; > + pinctrl-0 = <&cam_rgb_default>; property-n property-names please > + > + clocks = <&camcc CAM_CC_MCLK4_CLK>; > + assigned-clocks = <&camcc CAM_CC_MCLK4_CLK>; > + assigned-clock-rates = <19200000>; > + > + orientation = <0>; /* front facing */ This most definitely needs a dt binding definition instead of a comment Konrad