From: John Hubbard <jhubbard@nvidia.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
Zhi Wang <zhiw@nvidia.com>
Cc: rust-for-linux@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, dakr@kernel.org,
aliceryhl@google.com, bhelgaas@google.com,
kwilczynski@kernel.org, ojeda@kernel.org, alex.gaynor@gmail.com,
boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com,
lossin@kernel.org, a.hindborg@kernel.org, tmgross@umich.edu,
markus.probst@posteo.de, helgaas@kernel.org, cjia@nvidia.com,
smitra@nvidia.com, ankita@nvidia.com, aniketa@nvidia.com,
kwankhede@nvidia.com, targupta@nvidia.com, acourbot@nvidia.com,
joelagnelf@nvidia.com, zhiwang@kernel.org,
daniel.almeida@collabora.com
Subject: Re: [PATCH v10 1/5] rust: devres: style for imports
Date: Wed, 21 Jan 2026 18:24:02 -0800 [thread overview]
Message-ID: <d0b6b17a-1521-4259-a1e1-3270af7f787f@nvidia.com> (raw)
In-Reply-To: <CANiq72kz9a=Hx_tWLpSmmQ82MzO98V8-i+91qSutJvgKU+d-kQ@mail.gmail.com>
On 1/21/26 5:55 PM, Miguel Ojeda wrote:
> On Wed, Jan 21, 2026 at 10:30 AM Zhi Wang <zhiw@nvidia.com> wrote:
>>
>> Sure.I am trying to Cc folks who comments in the patch for crediting
>> their efforts. :)
>
> Ah, I see, thanks.
>
> As far as I understand the docs, Cc: is intended to document in the
> commit message that someone had the chance to discuss the patch.
>
> I can see that, if someone gave feedback in a previous version, then
> it is a way to say that they had the chance to review the new version,
> so that makes sense. Having said that, if we did systematically that,
> the list of explicit Cc's would grow quite a bit...
Yes. But for smaller discussions, this is effectively a convenient way
to implement your guideline below, without having to spend too much time
mentally weighing "which of these replies is from a Real Stakeholder".
So it's reasonable approximate guideline to use in many situations.
In other words, "not quite systematically" seems about right.
>
> Personally, I always understood the tag as meant for key stakeholders
> that you really want to explicitly mention in the commit message as
> having been involved (and that didn't otherwise give another tag at
> the end of the process), versus everyone else that is Cc as usual in
> the email headers.
>
Yes.
> But I have seen it used in different ways in the kernel... :)
Yes, and in particular, there is a mini-trend to include everyone
from scripts/get_maintainer.pl's output, as a Cc, even on v0 of a
series, before any discussion. That can bloat the commit log really
heavily, and people are mildly pushing back against it. I'm glad
we aren't doing that here.
thanks,
--
John Hubbard
next prev parent reply other threads:[~2026-01-22 2:24 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-19 20:22 [PATCH v10 0/5] rust: pci: add config space read/write support Zhi Wang
2026-01-19 20:22 ` [PATCH v10 1/5] rust: devres: style for imports Zhi Wang
2026-01-20 15:26 ` Gary Guo
2026-01-20 16:11 ` Miguel Ojeda
2026-01-21 9:29 ` Zhi Wang
2026-01-22 1:55 ` Miguel Ojeda
2026-01-22 2:24 ` John Hubbard [this message]
2026-01-22 11:43 ` Danilo Krummrich
2026-01-19 20:22 ` [PATCH v10 2/5] rust: io: separate generic I/O helpers from MMIO implementation Zhi Wang
2026-01-20 8:04 ` Alice Ryhl
2026-01-20 10:12 ` Danilo Krummrich
2026-01-20 11:26 ` Alice Ryhl
2026-01-20 12:38 ` Alice Ryhl
2026-01-20 15:59 ` Gary Guo
2026-01-20 16:09 ` Danilo Krummrich
2026-01-20 17:26 ` Zhi Wang
2026-01-20 17:29 ` Danilo Krummrich
2026-01-20 17:35 ` Gary Guo
2026-01-20 13:37 ` kernel test robot
2026-01-20 15:54 ` Gary Guo
2026-01-19 20:22 ` [PATCH v10 3/5] rust: io: factor out MMIO read/write macros Zhi Wang
2026-01-19 20:22 ` [PATCH v10 4/5] rust: pci: add config space read/write support Zhi Wang
2026-01-19 20:22 ` [PATCH v10 5/5] sample: rust: pci: add tests for config space routines Zhi Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0b6b17a-1521-4259-a1e1-3270af7f787f@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=aniketa@nvidia.com \
--cc=ankita@nvidia.com \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=cjia@nvidia.com \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=gary@garyguo.net \
--cc=helgaas@kernel.org \
--cc=joelagnelf@nvidia.com \
--cc=kwankhede@nvidia.com \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=markus.probst@posteo.de \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=smitra@nvidia.com \
--cc=targupta@nvidia.com \
--cc=tmgross@umich.edu \
--cc=zhiw@nvidia.com \
--cc=zhiwang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®