From: Paolo Abeni <pabeni@redhat.com>
To: Stefano Garzarella <sgarzare@redhat.com>, phind.uet@gmail.com
Cc: Bobby Eshleman <bobbyeshleman@meta.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Simon Horman <horms@kernel.org>,
George Zhang <georgezhang@vmware.com>,
Andy King <acking@vmware.com>, Dmitry Torokhov <dtor@vmware.com>,
virtualization@lists.linux.dev, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vsock: reject negative tv_usec in SO_VM_SOCKETS_CONNECT_TIMEOUT
Date: Tue, 3 Nov 2026 15:13:45 +0100 [thread overview]
Message-ID: <d0b6c2ba-34f2-4750-92c3-fb65c82cbc9e@redhat.com> (raw)
In-Reply-To: <auSIGIZctLp1oOhf@sgarzare-redhat>
On 10/30/26 13:09, Stefano Garzarella wrote:
> On Fri, Oct 30, 2026 at 02:43:50PM +0800, phind.uet@gmail.com wrote:
>> From: Nguyen Dinh Phi <phind.uet@gmail.com>
>>
>> The timeval validation checks tv_usec < USEC_PER_SEC but not
>> tv_usec >= 0, so a negative tv_usec makes the timeout computation
>> wrap into a bogus value, later tripping "schedule_timeout: wrong
>> timeout value" instead of being rejected.
>>
>> Fixes: d021c344051a ("VSOCK: Introduce VM Sockets")
>>
>
> This blank line shouldn't be there, maybe it can be fixed when the net
> maintainers apply this patch, so please wait their comments before sending a v2.
No need to repost: I fixed it while applying the patch.
/P
next prev parent reply other threads:[~2026-11-03 14:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-30 6:43 phind.uet
2026-10-30 6:49 ` netdev-bot+sinfo
2026-10-30 12:09 ` Stefano Garzarella
2026-11-03 14:13 ` Paolo Abeni [this message]
2026-10-30 22:07 ` Bobby Eshleman
2026-10-30 22:08 ` Bobby Eshleman
2026-11-03 14:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0b6c2ba-34f2-4750-92c3-fb65c82cbc9e@redhat.com \
--to=pabeni@redhat.com \
--cc=acking@vmware.com \
--cc=bobbyeshleman@meta.com \
--cc=davem@davemloft.net \
--cc=dtor@vmware.com \
--cc=edumazet@kernel.org \
--cc=georgezhang@vmware.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=phind.uet@gmail.com \
--cc=sgarzare@redhat.com \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®