From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 235C5C6FA86 for ; Thu, 22 Sep 2022 09:25:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230103AbiIVJZw (ORCPT ); Thu, 22 Sep 2022 05:25:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230102AbiIVJZr (ORCPT ); Thu, 22 Sep 2022 05:25:47 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01801AA365 for ; Thu, 22 Sep 2022 02:25:47 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 99555B82759 for ; Thu, 22 Sep 2022 09:25:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1D1F0C433C1; Thu, 22 Sep 2022 09:25:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663838744; bh=x9vdgttExkjV7T6N0P/+kIRGf8m3mwiWn87Z26KdTsk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Tr7km3Aj7G9vGv0PNURT0d2Qy39DlZdd3DrPD18cTJP9+bT3ppHNSqNorXg2fkqrz 1wx/kj8wqP4bLiiFxE7jsL0yQGE1SLGC6nFEbQvtDCZJfrSYsbdrPKIYZHUtNlmYDO A86ais2krzvXgzA9NlhhFalotk3LuLJJuwAA1iLqIJtQYI3PTAdeKpYrqAA9iuDQfT Fuw9iKlILDBo9L1EklKnDRLC7vJ1eSiZbVYFhZEsatHUodCjW8IZQH6LqLYTEM3EBG cBeDbApytq6Wm7OeTkQBFMlQXrENcm7MX2u41DBUZbX5RwqgMO45tERKP1T3pIDTVF PiEvwDIJL+Pgw== Message-ID: Date: Thu, 22 Sep 2022 11:25:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] rv/monitor: add __init/__exit annotations to module init/exit funcs To: Xiu Jianfeng Cc: linux-kernel@vger.kernel.org, rostedt@goodmis.org, mingo@redhat.com References: <20220911030418.94609-1-xiujianfeng@huawei.com> Content-Language: en-US From: Daniel Bristot de Oliveira In-Reply-To: <20220911030418.94609-1-xiujianfeng@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Xiu The first char after the subsys: must be capital, i.e., [PATCH] rv/monitor: Add __init/__exit annotations to module init/exit funcs On 9/11/22 05:04, Xiu Jianfeng wrote: > Add missing __init/__exit annotations to module init/exit funcs. Please, also add these tags to the monitor templates here: tools/verification/dot2/dot2k_templates/main_global.c tools/verification/dot2/dot2k_templates/main_per_cpu.c tools/verification/dot2/dot2k_templates/main_per_task.c So the fix is propagated to future monitors. Thanks -- Daniel