From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752011AbeAARxq (ORCPT + 1 other); Mon, 1 Jan 2018 12:53:46 -0500 Received: from mout.web.de ([212.227.15.4]:63352 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751400AbeAARxo (ORCPT ); Mon, 1 Jan 2018 12:53:44 -0500 Subject: [PATCH 1/2] benet: Delete an error message for a failed memory allocation in be_alloc_work() From: SF Markus Elfring To: netdev@vger.kernel.org, Ajit Khaparde , Sathya Perla , Somnath Kotur , Sriharsha Basavapatna Cc: LKML , kernel-janitors@vger.kernel.org References: <86e577a3-77a4-2e74-dd2d-4d63e90ffb72@users.sourceforge.net> Message-ID: Date: Mon, 1 Jan 2018 18:53:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <86e577a3-77a4-2e74-dd2d-4d63e90ffb72@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:nJWpTayZkHwGG31eviqBdN0uaPfGxfBIf69igYv2nxp+9O9Kg6H 9liDjI3pmobnTrVKHO0Lvfjv2+fATJCt8EFgN8XgvjyAY4JgT9mfv8q34s+BXtLuq+GFkTq bgQr2uyXDOuDJpDfKL2NQY4REkA5UQ8VPzcLy9/QaO3ob8ybS09IIdAedZfU386j/dBXl7z hduxg3dyxZd5psuXIPWcQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:xRV8upTecso=:TaYpkrfOSLNvRTcC+zMOxp h1gXs7T9K6bOCFTXDsGb+DUmMGfFji1mt+j7JGJxpD60xDwg9gXJ5+OMVEjT1v3z0bH6jXnWt KIgWen2Vk6ek7EfmAOPsv2rrY6ptUefNbS7JeJgkUknJEgb/y6b4IvTTS7IE1mybNU8tajpLA B6vy3rVpDRsmD69+lbIzTWJLBOnspm7yuNeE3TXl8sVXSBzFiekgQSbxNajKDB7TIDYRKw/FT 51oCCRhQbzfw5/ed9ItV2DmzENTZY/xV5Jd055VVG6QFjRLFHgWm+z7R0EOFReSTU/ln6KPMo hdlHuVpB/6lCLa33g9rmphXqeE45ghpx7yz3t5CI2/ChRrymbz9kEmnqmtUy/PsIanEsCy5mM f01Cl9eCvVmKiHegO4UWlA2dnhHGaKgGS0TgPyJizRcZRXlvwLtIz/hC16oUGYGkvWoM0ZtC6 64veNRsDdHMfr7Uvg8XkauaTAqhA48VaIPpzl1SeWg3hS7WZQLiuG80paD5bWyoNw1Kbg9ol9 hslJ3CLSpV69LaaxI6r85EH+MSp+cM5KMZJaYkNNsEqs/wFC4G2FebAy/V2JzG9m2KyIGl/Pm oRZwdC5faUFGp6+02ZeqX8h++N8vfKTJLQaP8gzIfX7G+fpnWAwwMv40DNC0vDNHVuOeAogWP Mmwz+R7rdWs1INJJUtC/tamqb7SpM9VxQw2AnmA4GG15RTRPaN/r6Bn7AJpUT91edk9TQA1X+ 8Zhd90peG6UCt1+ctqxl7jqFtKfEqK0257yrO5Zy4++BsTMS5pyUr0gwjPukG3eWtxi9m4eLn rlRR0D6u7wVsSiZK9DIbkI5iiupwXdP/uFQQ7Nekjv6CB4TRPg= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: From: Markus Elfring Date: Mon, 1 Jan 2018 18:38:06 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/net/ethernet/emulex/benet/be_main.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c index c6e859a27ee6..475d94762306 100644 --- a/drivers/net/ethernet/emulex/benet/be_main.c +++ b/drivers/net/ethernet/emulex/benet/be_main.c @@ -4930,11 +4930,8 @@ static struct be_cmd_work *be_alloc_work(struct be_adapter *adapter, struct be_cmd_work *work; work = kzalloc(sizeof(*work), GFP_ATOMIC); - if (!work) { - dev_err(&adapter->pdev->dev, - "be_work memory allocation failed\n"); + if (!work) return NULL; - } INIT_WORK(&work->work, func); work->adapter = adapter; -- 2.15.1