From: Shanker Donthineni <sdonthineni@nvidia.com>
To: Thomas Gleixner <tglx@linutronix.de>,
Marc Zyngier <maz@kernel.org>, Michael Walle <michael@walle.cc>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Hans de Goede <hdegoede@redhat.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] genirq: Allocate IRQ descriptors at boot time for !SPARSEIRQ
Date: Tue, 31 Jan 2023 10:41:25 -0600 [thread overview]
Message-ID: <d0cef09a-a440-d61b-b541-d3d040a295cf@nvidia.com> (raw)
In-Reply-To: <87mt5z12t4.ffs@tglx>
On 1/31/23 03:16, Thomas Gleixner wrote:
> External email: Use caution opening links or attachments
>
>
> On Sun, Jan 29 2023 at 18:57, Shanker Donthineni wrote:
>
>> Remove the use of statically allocated arrays for IRQ descriptors.
>> Instead, allocate the necessary NR_IRQ descriptors during the boot
>> time in early_irq_init().
>
> That's not what I meant. I was pondering to remove !SPARSEIRQ
> completely.
>
It's touching many files to drop CONFIG_SPARSE_IRQ=n support. Worried
about removing !SPARSEIRQ without testing on legacy platforms.
Can work on this after moving it to maple tree?
arch/arm/Kconfig | 1 -
arch/arm/include/asm/irq.h | 4 --
arch/arm/kernel/irq.c | 2 -
arch/arm64/Kconfig | 1 -
arch/csky/Kconfig | 1 -
arch/loongarch/Kconfig | 1 -
arch/microblaze/Kconfig | 1 -
arch/nios2/Kconfig | 1 -
arch/openrisc/Kconfig | 1 -
arch/powerpc/Kconfig | 1 -
arch/riscv/Kconfig | 1 -
arch/s390/Kconfig | 1 -
arch/sh/Kconfig | 1 -
arch/sparc/Kconfig | 1 -
arch/x86/Kconfig | 1 -
drivers/irqchip/Kconfig | 5 ---
include/linux/irqdesc.h | 8 ----
kernel/irq/Kconfig | 17 --------
kernel/irq/chip.c | 5 ---
kernel/irq/internals.h | 10 -----
kernel/irq/irqdesc.c | 88 --------------------------------------
kernel/irq/irqdomain.c | 14 +++---
22 files changed, 6 insertions(+), 160 deletions(-)
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 43c7773b89ae..d4fc6c549660 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -134,7 +134,6 @@ config ARM
select PCI_SYSCALL if PCI
select PERF_USE_VMALLOC
select RTC_LIB
- select SPARSE_IRQ if !(ARCH_FOOTBRIDGE || ARCH_RPC)
select SYS_SUPPORTS_APM_EMULATION
select THREAD_INFO_IN_TASK
select TIMER_OF if OF
diff --git a/arch/arm/include/asm/irq.h b/arch/arm/include/asm/irq.h
index a7c2337b0c7d..6d4ff82c40cf 100644
--- a/arch/arm/include/asm/irq.h
+++ b/arch/arm/include/asm/irq.h
@@ -4,11 +4,7 @@
...
-#ifndef CONFIG_SPARSE_IRQ
-#include <mach/irqs.h>
-#else
#define NR_IRQS NR_IRQS_LEGACY
-#endif
...
# Make sparse irq Kconfig switch below available
-config MAY_HAVE_SPARSE_IRQ
- bool
-
# Legacy support, required for itanic
config GENERIC_IRQ_LEGACY
bool
@@ -107,19 +103,6 @@ config GENERIC_IRQ_RESERVATION_MODE
config IRQ_FORCED_THREADING
bool
> That allocation does not buy us much.
>
Agree, not much value other than reducing kernel binary size. I will drop
this patch in v2.
Thanks,
Shanker
next prev parent reply other threads:[~2023-01-31 16:41 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 0:57 [PATCH 0/5] Increase the number of IRQ descriptors for SPARSEIRQ Shanker Donthineni
2023-01-30 0:57 ` [PATCH 1/5] genirq: Use hlist for managing resend handlers Shanker Donthineni
2023-01-31 8:59 ` Thomas Gleixner
2023-01-31 16:17 ` Shanker Donthineni
2023-01-31 17:06 ` Shanker Donthineni
2023-01-30 0:57 ` [PATCH 2/5] genirq: Allocate IRQ descriptors at boot time for !SPARSEIRQ Shanker Donthineni
2023-01-31 9:16 ` Thomas Gleixner
2023-01-31 16:41 ` Shanker Donthineni [this message]
2023-02-07 10:28 ` Thomas Gleixner
2023-01-30 0:57 ` [PATCH 3/5] genirq: Introduce two helper functions Shanker Donthineni
2023-01-31 9:20 ` Thomas Gleixner
2023-01-31 16:42 ` Shanker Donthineni
2023-01-30 0:57 ` [PATCH 4/5] genirq: Use the common function irq_expand_nr_irqs() Shanker Donthineni
2023-01-31 9:35 ` Thomas Gleixner
2023-01-31 16:43 ` Shanker Donthineni
2023-02-07 10:29 ` Thomas Gleixner
2023-01-30 0:57 ` [PATCH 5/5] genirq: Use the maple tree for IRQ descriptors management Shanker Donthineni
2023-01-31 9:52 ` Thomas Gleixner
2023-01-31 16:45 ` Shanker Donthineni
2023-02-01 6:02 ` kernel test robot
2023-02-01 13:27 ` Thomas Gleixner
2023-02-06 14:24 ` Vlastimil Babka
2023-02-06 18:10 ` Thomas Gleixner
2023-02-07 10:30 ` Thomas Gleixner
2023-02-07 14:16 ` mm, slab/slub: Ensure kmem_cache_alloc_bulk() is available early Thomas Gleixner
2023-02-07 14:45 ` Vlastimil Babka
2023-02-07 14:47 ` Vlastimil Babka
2023-02-07 18:20 ` Thomas Gleixner
2023-02-08 9:15 ` Vlastimil Babka
2023-02-08 20:46 ` Thomas Gleixner
2023-02-09 20:28 ` Matthew Wilcox
2023-02-09 23:19 ` Thomas Gleixner
2023-02-08 13:20 ` Hyeonggon Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0cef09a-a440-d61b-b541-d3d040a295cf@nvidia.com \
--to=sdonthineni@nvidia.com \
--cc=bigeasy@linutronix.de \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=michael@walle.cc \
--cc=tglx@linutronix.de \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome