From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87DF91EE006 for ; Tue, 3 Dec 2024 13:52:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733233953; cv=none; b=jm8rWzO+Ubc7hn/UJxjFTtaorfvt8Stah5ou3MHc5UH7ysIApfe3pifrWNNdwToLMsVA3x60Hri0qSA7o6mgBNb/NbXFORBwhA+m+y0eDOIs7FZHBctNJNEU0onkrRMq8uZ7aJEA7CfEZYpRbkIp6jbHVZnh5PJUBCRboo8SqdA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733233953; c=relaxed/simple; bh=vQyNRZyfktd4dZ/VfxPnrD450fKtsTU4U0K5AmvMOA4=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=pOWhpNMRM4sQ8TDijvhXddhphnJ7j8usybx2XVWFzfASK4pHCSlbqqenBcBFPXpcop3cvUpAb6uY4YSACtTa6Abbuc4JEhgF+skuIgxD7I7vH8BeSfc37YmJCM4S34MAxvrLK03f8KgXtcGFKFarhtyweRGZ45x0qHzXA+Vc//o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=qZg3N+y+; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qZg3N+y+" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-434a83c6b01so48743695e9.0 for ; Tue, 03 Dec 2024 05:52:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1733233950; x=1733838750; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=ABkNR+66cga4jI8z0RZ2Hsh7LoVsEWiOT9UTom3Spu8=; b=qZg3N+y+GRR/kFH8MEewLuHAVvQpTuAxENwx9L+wxRu2/O2zN6+SvstcTF8fM0QETO 0HK/6unrkmCwx4xq7HJgig8weVC91HzrRAsc8vJ1IcHD+LgYNZDdk+SQj5dI61XAmqp3 I8ALwMzlwvImrR5RWd/nVBFTJF7USfYMGm49s4nfhHXk2CdwOaMKIHvEq5F7ViY56Eg4 xe00RVnvLV/dG7g8xw32Z2uawtn6USxyP9Jw1guHMVLuqrbsXpeFvukB83ZjVwZ+5VyV bEaC0Xhe3F1qVbuWIo7KlDNWt2x94r9PxMgkouLgVA9WfE/sSV3grz+fFYyY1T7ZrRmq TgGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733233950; x=1733838750; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ABkNR+66cga4jI8z0RZ2Hsh7LoVsEWiOT9UTom3Spu8=; b=SnoTLLxqzh5VGedmi/apqbWH4LaHiuSiWayLs+BdOdYxH7qkvkaj/sSsnPoWX+1t7M 8JuC0P1ixjixr1hKPSuwNDwi7pa4kqJaj0SX4s5/2eLOiDhTm2EdLQqBg+1cgv6kqrK1 Wp4gh3oiX16/GRPKx4/fHYwmbznQtLsH23OTXn/Wznpsesa3jI9gFPZJDfrN6aKhYXYG gKGg9RWubqQ2teSHKuZ06x+DjTZV26jsfLv1ZJ/RHBu+3ILmne7cLDdFwLHq74VIpCx6 WGWTACGLYE59yxaLiz36z1HTN99rB6VxsugxfVLosK2GtokWS4Muh7FmXYAcHN7HHomn Qwqg== X-Forwarded-Encrypted: i=1; AJvYcCXlEyvL4uP5K5Pg8RtJOnVvZ57tH264LPsRsbLXfm/UQ3/vuM2pzJg0HmzKTkvw4gxCoAPa3mOy2bMMzos=@vger.kernel.org X-Gm-Message-State: AOJu0Ywl8lp8PpddjGri/lteyHqrM0SohQ0pGyVL58apHcJnq3MAPXyZ NWMhTEfdkJiLja9WVC1Qez5mRCYOa4G+p61FkXfb1GlCIEidAKhuGLRog3vpkQ4= X-Gm-Gg: ASbGncvPOgUl3ghQoZXMtPzng0NJlKMusY5h/7ixke3JxlPV2ZQHIdmi/yq50iUpU3t 8yt0vA15hwK1BWMe2REb3kH3eglEOo3rGjvjHDfs70hQVQ2zwfXqYRv+xDkqAlOWUy27Q3Vivnx cUBX/YIA4qmbqExPXBmPSFErds8C3jJHohhpfHB55Fs0vau3kwKMPhHQ90WxspF6C7N+PyLKOuw FIlet+p0ytLaHy8Xnc0JqlgcDz0/Au47+Eyero4tIL5WgMzciQhr2PCdLlrzwyOHa+tAA/fFCCh JKkObenYd/n+nV0WCfPE2+zZ X-Google-Smtp-Source: AGHT+IFkJh1EUhfAJne4bE1d9lfMNE+K3tGMuLLZgbRBdMCN+TtCafvJ11ltFQ+c8Zv8qJ9vt2sg9Q== X-Received: by 2002:a5d:47cb:0:b0:385:e8b0:df13 with SMTP id ffacd0b85a97d-385fd437301mr2434207f8f.40.1733233949965; Tue, 03 Dec 2024 05:52:29 -0800 (PST) Received: from ?IPV6:2a01:e0a:982:cbb0:b668:b88:4ecf:c065? ([2a01:e0a:982:cbb0:b668:b88:4ecf:c065]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-385ccd3a710sm15397849f8f.57.2024.12.03.05.52.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Dec 2024 05:52:29 -0800 (PST) Message-ID: Date: Tue, 3 Dec 2024 14:52:28 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: neil.armstrong@linaro.org Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH 7/9] crypto: qce - use __free() for a buffer that's always freed To: Bartosz Golaszewski , Thara Gopinath , Herbert Xu , "David S. Miller" , Stanimir Varbanov Cc: linux-crypto@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski References: <20241203-crypto-qce-refactor-v1-0-c5901d2dd45c@linaro.org> <20241203-crypto-qce-refactor-v1-7-c5901d2dd45c@linaro.org> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20241203-crypto-qce-refactor-v1-7-c5901d2dd45c@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 03/12/2024 10:19, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > The buffer allocated in qce_ahash_hmac_setkey is always freed before > returning to use __free() to automate it. I think you wanted to use "so" instead of "to", otherwise it means nothing ^^ > > Signed-off-by: Bartosz Golaszewski > --- > drivers/crypto/qce/sha.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/crypto/qce/sha.c b/drivers/crypto/qce/sha.c > index fc72af8aa9a72..916908c04b635 100644 > --- a/drivers/crypto/qce/sha.c > +++ b/drivers/crypto/qce/sha.c > @@ -3,6 +3,7 @@ > * Copyright (c) 2010-2014, The Linux Foundation. All rights reserved. > */ > > +#include > #include > #include > #include > @@ -336,7 +337,6 @@ static int qce_ahash_hmac_setkey(struct crypto_ahash *tfm, const u8 *key, > struct scatterlist sg; > unsigned int blocksize; > struct crypto_ahash *ahash_tfm; > - u8 *buf; > int ret; > const char *alg_name; > > @@ -370,7 +370,8 @@ static int qce_ahash_hmac_setkey(struct crypto_ahash *tfm, const u8 *key, > crypto_req_done, &wait); > crypto_ahash_clear_flags(ahash_tfm, ~0); > > - buf = kzalloc(keylen + QCE_MAX_ALIGN_SIZE, GFP_KERNEL); > + u8 *buf __free(kfree) = kzalloc(keylen + QCE_MAX_ALIGN_SIZE, > + GFP_KERNEL); > if (!buf) { > ret = -ENOMEM; > goto err_free_req; > @@ -382,7 +383,6 @@ static int qce_ahash_hmac_setkey(struct crypto_ahash *tfm, const u8 *key, > > ret = crypto_wait_req(crypto_ahash_digest(req), &wait); > > - kfree(buf); > err_free_req: > ahash_request_free(req); > err_free_ahash: > With the typo fixes: Reviewed-by: Neil Armstrong