mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Wadim Egorov <W.Egorov@phytec.de>
To: Jerome Neanne <jneanne@baylibre.com>,
	"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
	"broonie@kernel.org" <broonie@kernel.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"nm@ti.com" <nm@ti.com>, "kristo@kernel.org" <kristo@kernel.org>,
	"dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
	"krzysztof.kozlowski+dt@linaro.org" 
	<krzysztof.kozlowski+dt@linaro.org>,
	"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
	"will@kernel.org" <will@kernel.org>,
	"lee@kernel.org" <lee@kernel.org>,
	"tony@atomide.com" <tony@atomide.com>,
	"vigneshr@ti.com" <vigneshr@ti.com>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"geert+renesas@glider.be" <geert+renesas@glider.be>,
	"dmitry.baryshkov@linaro.org" <dmitry.baryshkov@linaro.org>,
	"marcel.ziswiler@toradex.com" <marcel.ziswiler@toradex.com>,
	"vkoul@kernel.org" <vkoul@kernel.org>,
	"biju.das.jz@bp.renesas.com" <biju.das.jz@bp.renesas.com>,
	"arnd@arndb.de" <arnd@arndb.de>,
	"jeff@labundy.com" <jeff@labundy.com>
Cc: "afd@ti.com" <afd@ti.com>,
	"khilman@baylibre.com" <khilman@baylibre.com>,
	"narmstrong@baylibre.com" <narmstrong@baylibre.com>,
	"msp@baylibre.com" <msp@baylibre.com>,
	"j-keerthy@ti.com" <j-keerthy@ti.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH v7 1/6] DONOTMERGE: arm64: dts: ti: Add TI TPS65219 PMIC support for AM642 SK board.
Date: Thu, 15 Dec 2022 15:09:04 +0000	[thread overview]
Message-ID: <d0d7e315-ce86-0420-8ef5-fe2e4aefd5b4@phytec.de> (raw)
In-Reply-To: <20221104152311.1098603-2-jneanne@baylibre.com>

Hi Jerome,

is this setup working for you on the AM642 SK board?

I am testing your PMIC patches on a AM62 based board with a similar setup and
running into the following error

    VDDSHV5_SDIO: bypassed regulator has no supply!
    VDDSHV5_SDIO: will resolve supply early: ldo1
    VDDSHV5_SDIO: supplied by regulator-dummy
    VDDSHV5_SDIO: failed to get the current voltage: -EINVAL

Have you noticed problems with LDO1 and bypass mode?

Regards,
Wadim

Am 04.11.22 um 16:23 schrieb Jerome Neanne:
> From: Jerome NEANNE <jneanne@baylibre.com>
>
> Add support fot the TI Power Management IC TPS65219
> on the AM642 SKEVM board.
>
> Needed for driver testing but official board support pending.
> TI commitment is required before board upstream kick-off.
>
> Signed-off-by: Jerome NEANNE <jneanne@baylibre.com>
> Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
> ---
>   arch/arm64/boot/dts/ti/k3-am642-sk.dts | 104 +++++++++++++++++++++++++
>   1 file changed, 104 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am642-sk.dts b/arch/arm64/boot/dts/ti/k3-am642-sk.dts
> index 738d0cf6c40a..d0121976491a 100644
> --- a/arch/arm64/boot/dts/ti/k3-am642-sk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am642-sk.dts
> @@ -219,6 +219,20 @@ led-7 {
>   			gpios = <&exp2 7 GPIO_ACTIVE_HIGH>;
>   		};
>   	};
> +
> +	vsel_sd_nddr: gpio-regulator {
> +		compatible = "regulator-gpio";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&vsel_sd_nddr_pins_default>;
> +		regulator-name = "tps65219-LDO1-SEL-SD";
> +		regulator-min-microvolt = <1800000>;
> +		regulator-max-microvolt = <3300000>;
> +		regulator-boot-on;
> +		vin-supply = <&ldo1_reg>;
> +		gpios = <&main_gpio0 45 GPIO_ACTIVE_HIGH>;
> +		states = <1800000 0x0>,
> +			 <3300000 0x1>;
> +	};
>   };
>   
>   &main_pmx0 {
> @@ -250,6 +264,13 @@ AM64X_IOPAD(0x02a8, PIN_OUTPUT, 0) /* (E19) USB0_DRVVBUS */
>   		>;
>   	};
>   
> +	main_i2c0_pins_default: main-i2c0-pins-default {
> +		pinctrl-single,pins = <
> +			AM64X_IOPAD(0x0260, PIN_INPUT_PULLUP, 0) /* (A18) I2C0_SCL */
> +			AM64X_IOPAD(0x0264, PIN_INPUT_PULLUP, 0) /* (B18) I2C0_SDA */
> +		>;
> +	};
> +
>   	main_i2c1_pins_default: main-i2c1-pins-default {
>   		pinctrl-single,pins = <
>   			AM64X_IOPAD(0x0268, PIN_INPUT_PULLUP, 0) /* (C18) I2C1_SCL */
> @@ -336,6 +357,12 @@ main_wlan_pins_default: main-wlan-pins-default {
>   			AM64X_IOPAD(0x00bc, PIN_INPUT, 7) /* (U8) GPIO0_46 */
>   		>;
>   	};
> +
> +	vsel_sd_nddr_pins_default: vsel-sd-nddr-pins-default {
> +		pinctrl-single,pins = <
> +			AM64X_IOPAD(0x00b8, PIN_INPUT, 7) /* (Y7) PRG1_PRU0_GPO0.GPIO0_45 */
> +		>;
> +	};
>   };
>   
>   &mcu_uart0 {
> @@ -384,6 +411,83 @@ &mcu_i2c1 {
>   	status = "disabled";
>   };
>   
> +&main_i2c0 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&main_i2c0_pins_default>;
> +	clock-frequency = <400000>;
> +	status = "okay";
> +
> +	tps65219: pmic@30 {
> +		compatible = "ti,tps65219";
> +		reg = <0x30>;
> +		system-power-controller;
> +
> +		buck1-supply = <&vcc_3v3_sys>;
> +		buck2-supply = <&vcc_3v3_sys>;
> +		buck3-supply = <&vcc_3v3_sys>;
> +		ldo1-supply = <&vcc_3v3_sys>;
> +		ldo2-supply = <&buck2_reg>;
> +		ldo3-supply = <&vcc_3v3_sys>;
> +		ldo4-supply = <&vcc_3v3_sys>;
> +
> +		regulators {
> +			buck1_reg: buck1 {
> +				regulator-name = "VDD_CORE";
> +				regulator-min-microvolt = <750000>;
> +				regulator-max-microvolt = <1000000>;
> +				regulator-boot-on;
> +				regulator-always-on;
> +			};
> +
> +			buck2_reg: buck2 {
> +				regulator-name = "VCC1V8";
> +				regulator-min-microvolt = <1800000>;
> +				regulator-max-microvolt = <1800000>;
> +				regulator-boot-on;
> +				regulator-always-on;
> +			};
> +
> +			buck3_reg: buck3 {
> +				regulator-name = "VDD_LPDDR4";
> +				regulator-min-microvolt = <1100000>;
> +				regulator-max-microvolt = <1100000>;
> +				regulator-boot-on;
> +				regulator-always-on;
> +			};
> +
> +			ldo1_reg: ldo1 {
> +				regulator-name = "VDDSHV_SD_IO_PMIC";
> +				regulator-min-microvolt = <1000000>;
> +				regulator-max-microvolt = <3300000>;
> +				regulator-allow-bypass;
> +			};
> +
> +			ldo2_reg: ldo2 {
> +				regulator-name = "VDDAR_CORE";
> +				regulator-min-microvolt = <850000>;
> +				regulator-max-microvolt = <850000>;
> +				regulator-boot-on;
> +				regulator-always-on;
> +			};
> +
> +			ldo3_reg: ldo3 {
> +				regulator-name = "VDDA_1V8";
> +				regulator-min-microvolt = <1800000>;
> +				regulator-max-microvolt = <1800000>;
> +				regulator-boot-on;
> +				regulator-always-on;
> +			};
> +
> +			ldo4_reg: ldo4 {
> +				regulator-name = "VDD_PHY_2V5";
> +				regulator-min-microvolt = <2500000>;
> +				regulator-max-microvolt = <2500000>;
> +				regulator-boot-on;
> +				regulator-always-on;
> +			};
> +		};
> +	};
> +};
>   &main_i2c1 {
>   	pinctrl-names = "default";
>   	pinctrl-0 = <&main_i2c1_pins_default>;



  reply	other threads:[~2022-12-15 15:09 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-04 15:23 [PATCH v7 0/6] Add support for TI TPS65219 PMIC Jerome Neanne
2022-11-04 15:23 ` [PATCH v7 1/6] DONOTMERGE: arm64: dts: ti: Add TI TPS65219 PMIC support for AM642 SK board Jerome Neanne
2022-12-15 15:09   ` Wadim Egorov [this message]
2022-12-15 15:51     ` jerome Neanne
2022-12-15 16:09       ` Mark Brown
2022-12-15 17:54         ` Nishanth Menon
2022-12-15 18:22           ` Mark Brown
2022-12-15 21:41             ` Nishanth Menon
2022-12-16  6:21               ` Vignesh Raghavendra
2022-12-16  7:28                 ` jerome Neanne
2022-12-16 13:41               ` Mark Brown
2022-12-28 10:16                 ` Wadim Egorov
2022-11-04 15:23 ` [PATCH v7 2/6] DONOTMERGE: arm64: dts: ti: Add pinmux and irq mapping for TPS65219 external interrupts Jerome Neanne
2022-11-04 15:23 ` [PATCH v7 3/6] DONOTMERGE: arm64: dts: ti: k3-am642-sk: Enable tps65219 power-button Jerome Neanne
2022-11-04 15:23 ` [PATCH v7 4/6] mfd: tps65219: Add driver for TI TPS65219 PMIC Jerome Neanne
2022-11-15 22:26   ` Kevin Hilman
2022-11-15 23:14   ` Kevin Hilman
2022-11-16 13:58     ` Lee Jones
2022-11-16 18:11   ` Lee Jones
2022-11-04 15:23 ` [PATCH v7 5/6] Input: Add tps65219 interrupt driven powerbutton Jerome Neanne
2022-11-17 11:53   ` Lee Jones
2022-11-04 15:23 ` [PATCH v7 6/6] arm64: defconfig: Add tps65219 as modules Jerome Neanne
2022-11-15 22:23   ` Kevin Hilman
2022-11-17 16:00     ` Kevin Hilman
2022-12-05 18:08 ` [PATCH v7 0/6] Add support for TI TPS65219 PMIC Francesco Dolcini
2022-12-06 19:22   ` jerome Neanne
2023-05-22 11:57     ` jerome Neanne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d0d7e315-ce86-0420-8ef5-fe2e4aefd5b4@phytec.de \
    --to=w.egorov@phytec.de \
    --cc=afd@ti.com \
    --cc=arnd@arndb.de \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=geert+renesas@glider.be \
    --cc=j-keerthy@ti.com \
    --cc=jeff@labundy.com \
    --cc=jneanne@baylibre.com \
    --cc=khilman@baylibre.com \
    --cc=kristo@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lee@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=marcel.ziswiler@toradex.com \
    --cc=msp@baylibre.com \
    --cc=narmstrong@baylibre.com \
    --cc=nm@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=tony@atomide.com \
    --cc=vigneshr@ti.com \
    --cc=vkoul@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®