From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34384442389 for ; Mon, 14 Sep 2026 11:23:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789384988; cv=none; b=calPiil5MWhhHw3JbtT7wArBB87cGh9K+ZkCvRqGp3AqRui7QuMNvnmOZhyDNPaQnEmUZF3LwiFOnpB0lZm9HB5haZagflZo/U+O6o/vV4FSsJeVQDmXxakrjDtNjoBXDBolQZqAI887LrldNTvILJVojvCcGix9W7ZfKEU+Nng= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789384988; c=relaxed/simple; bh=qB15Tu0wQgvflvACMlEZFwV6PZUUfZT9UV5fY5oJj88=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mQxC7IIS5wnktkYvoegA1MhRWoCxJ73oaaWb+XBDoUVyamGt4iTYCqI23NW4QPJxiup/GIFLuW0qarXjFcmD4q3gpc0HDzhYzQnGqIlHiPfq/WaFGYxdd+yyeCMFO//K2MDfb5mf04bYjhXddly15x0AvI9m/WnZmqb2gLuOqRo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=V6eXEJqa; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=hY+B7KB/; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="V6eXEJqa"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="hY+B7KB/" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68EAmhmM216149 for ; Mon, 14 Sep 2026 11:23:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= htoucfNJ1NBOznj2ucEtPoE5fys137bATrwbrwYNEEg=; b=V6eXEJqaW52sruVW KmAWqHedQKN92ge5YENWkiPjd+G4FUiYoi+rXuXHOXCHct/s2ruBO47fL403iyAH 2SylfxfndayU9tuNs74mBf0Xj12d3kC5/2MhrMELYG8moOkZhHp5DR7YyqO0kNHs 0Lw7qkc35AhQS+AgFCbu3IoOaFGpMQF7HP0nvezpOH9EjkcQG7/eI1EGSaOHqhHE tAFRbnOZo/0zdY6LMW69aKrcmdFxfdNVAuR98oQs9x/NZr3V+VuTPtOnn+xGBeb6 5M5JFDIf2VvoFSBwfEjJixhhuEPdxOYVn7knVSt6iSa8pTvUSJQzCq5yrtQwVTO8 3nO8Vw== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gmy9decyu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 14 Sep 2026 11:23:03 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-9106bb33cdfso7384626d6.2 for ; Mon, 14 Sep 2026 04:23:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789384983; x=1789989783; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=htoucfNJ1NBOznj2ucEtPoE5fys137bATrwbrwYNEEg=; b=hY+B7KB/+ggzP4fC1lvm8VZEE9tLkRz+Pv8Iqc9hzY5wosC/bZre9cqjv2f15Lkv3u P3YMsby6ODJXsG9ukj2PFBvfsOXgGc7IZu3p1qqNVHMdWEZc2A374YiRLRKj5KNj3ust ZZCCiWNsT8Mi5KHbqfTI1a1C7O4/mzKTdRXFfOTDRV9209fwleR7Zm+//QRt64VbI/KT 7csyZvNTzJb2skccEqwcxnDGFpBdviDW402DinhmhnQUOwX7+I16ml9v7hzKxcyWb5DE VeB14tCUpcnJSIWowZIClcxGbMMm4JL2UJ3jvf9+37etkF21OYACs9y76doFN6Fd/meo XYeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789384983; x=1789989783; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=htoucfNJ1NBOznj2ucEtPoE5fys137bATrwbrwYNEEg=; b=cgjVVSK7YTmih2wL55la/2sGybfllImhYO6E/y4hvjUlYBv5PhD6ompYhk8/A/rGlc IU+0hO6631/IpYSexKEEWX5fZ255T5o3raOlygqmfA3b4XKwMUvFPr4qXDCXTVtx7g1U OnSPffj37ktHtt0x7ZFc9cpanEFG2Oam1XCdE93K5pmosbwhPuUztUxxAkOqMLo1QunH cUk7oKuM6GgZf6latVX6Filj+wOgSeZV95jMuuO8uvLMQGHj5n8mPbEeSc9LzcFk0CFw /tfL65V2S/bqGKrlNTR56Twv/t1MCASGoGaJo6awbgnOQNrsk9c+9jJOhRnDJG1Uczcs bkqg== X-Forwarded-Encrypted: i=1; AKwUvBxniEkdmrzd40wObwKY5X0M77WmfKiDb2SvaVxhrmO71pNgjE5eIQXgcJeEZ0HhL84csc+QgvSv+NMAdfo=@vger.kernel.org X-Gm-Message-State: AFuF++l8uq1mo2YI/5afo6CodkD12ml2qkVBid6ZUkkDNuv7XbHAdQ3q wm3q4vju6XP37a0rtaUvrFkAJdwDhDrKldX50/NAN1YSXpP5jyG+JYxQ+vU4BvaV0eU+zM6V/1y 561Fq1Qs5ZuT/pHCJ9LnxYwXniKTOPyKmI/KOfiKomYPr4El2ExBk20I1cIQgftUv3gE= X-Gm-Gg: AYBFou1mHFdvApg45OfjTYJrQ0ktfwwA/fL11/9sUk47N1t4N3hF7KzDipqGyiIpzGJ Q0L4D3XVWWgcyNBj/laVppCrd3ItRw0ZN8YOWdf/DgMch/h94nOMUUVgtnlZG/GfWBLRGMmuucm a6d0hWkyDFHcHy//Wv+AimFH3sedZdeyN3j4HkJiKEq5NJTSD0OsaFGGeajCU9udDLiDKMU6x66 NFTiznwn1U53YFp4lq2Bq+ALE5PTOzmVEq+Uv0K1T9XwAx/a5MJnluBLS8/TmgVkrw+/BjN4RaS U6FYaSZGFFUx5qIp2KtblayNs6DrKAEngD4Brkr9j8aameSFA0gKd5h0J1hYB9gUfhNZNBdY2fj WxZWggPqiZYZgm3660CRWMA== X-Received: by 2002:a05:6214:4883:b0:912:1f0f:b204 with SMTP id 6a1803df08f44-9122e4ccd58mr27340566d6.1.1789384978176; Mon, 14 Sep 2026 04:22:58 -0700 (PDT) X-Received: by 2002:a05:6214:4883:b0:912:1f0f:b204 with SMTP id 6a1803df08f44-9122e4ccd58mr27339976d6.1.1789384977653; Mon, 14 Sep 2026 04:22:57 -0700 (PDT) Received: from [192.168.202.12] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a9b594f0fasm4216719a12.25.2026.09.14.04.22.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Sep 2026 04:22:56 -0700 (PDT) Message-ID: Date: Mon, 14 Sep 2026 13:22:52 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 20/20] arm64: dts: qcom: generalmobile-shamrock: new device To: muzafferkadir@mainlining.org, Bjorn Andersson , Abel Vesa , Stephen Boyd , Brian Masney , Jerome Brunet , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Srinivas Kandagatla , Ulf Hansson , Konrad Dybcio , "Joerg Roedel (AMD)" , Will Deacon , Robin Murphy , Lee Jones , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Robert Marko , Guru Das Srinagesh , Amit Kucheria , Thara Gopinath , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Kees Cook , Tony Luck , "Guilherme G. Piccoli" , Dmitry Torokhov Cc: David Heidelberg , Dang Huynh , phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, iommu@lists.linux.dev, mfd@lists.linux.dev, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Krzysztof Kozlowski , linux-pm@vger.kernel.org, linux-input@vger.kernel.org References: <20260912-msm8952-initial-support-v1-0-0e742578b524@mainlining.org> <20260912-msm8952-initial-support-v1-20-0e742578b524@mainlining.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260912-msm8952-initial-support-v1-20-0e742578b524@mainlining.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE0MDE2MSBTYWx0ZWRfX++/+M/Z/ibb3 GbyE8/HCH3/mIMXcNLR2KkooVJCtbjfv1MBiuWexBFK37l/fLhC766YfDQ0Rid/9jwGjgqfEO2G rQlMcTBsO8Tk/d5GUDXPWWgXWXX9RWalc5h0KXZMNc3WvEXxst1a8aFff5tCkb0+iK2KGE5XBAb fCK2bb/k76zqh8hVNPLJyOs2Hbi9fJZNY+4HRIC4OqSzStm69vnrIpd/rLRZH1fDCcVW9tSIMYI nLqvr48Q/feflaFbp0aHVNxcZWDICnd6hQrSkNfPUdorJtlA7kWGqDxwDlULbQMVB+H8avl6Ccj dPYaEnF0XYxLNnXu/SqWJ0xyel4YG5n5E0Cl+rg5DEwmoQEVlzQGGzW6x5rxi2LUHoDm5LUDNIx KYVem7A2K9+sl9eW1muYMhkB5YuOVzDZtBjAVfQQvRuv7JK+91VuDcmTEjKv3j8yTGCTnbr4U6i OQaVGJICAf2V+cY/aJw== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE0MDE2MSBTYWx0ZWRfX9RLDf/8wyyQ+ qT2TStBRJ5Q9cXreKc95iLEB8uv786e1dt+s8NsOTMeSijSxjmF+DegbemagxPRlujzeZZeYvR/ BxaE03K1KJ5sYY16RdZspdJw2DqAgYc= X-Proofpoint-GUID: 1oBgfS3_CBpvk2N2anb1GMwt04LE2SOc X-Authority-Analysis: v=2.4 cv=OeUNnRTY c=1 sm=1 tr=0 ts=6aa7d917 cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=OuZLqq7tAAAA:8 a=orgwjQpZXFS75ENpSOkA:9 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 a=AKGiAy9iJ-JzxKVHQNES:22 X-Proofpoint-ORIG-GUID: 1oBgfS3_CBpvk2N2anb1GMwt04LE2SOc X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-14_03,2026-09-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 priorityscore=1501 suspectscore=0 impostorscore=0 adultscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609140161 On 9/12/26 10:39 AM, Muzaffer Kadir via B4 Relay wrote: > From: Muzaffer Kadir > > Add General Mobile Shamrock (GM 5 Plus). > Shamrock is designed similar to L9300. > Downstream reference is [1]. Please feel free to wrap your messages at 72 characters, otherwise they are a bit hard to read! :D [...] > +/ { > + model = "General Mobile GM 5 Plus (shamrock)"; It's not any "policy", but other DTs tend to only put the "pretty name" here, without the codename [...] > + framebuffer { > + compatible = "simple-framebuffer"; > + memory-region = <&cont_splash_mem>; > + > + width = <1080>; > + height = <1920>; > + stride = <(1080 * 3)>; > + format = "r8g8b8"; > + > + power-domains = <&gcc MDSS_GDSC>; > + > + clocks = <&gcc GCC_MDSS_AHB_CLK>, > + <&gcc GCC_MDSS_AXI_CLK>, > + <&gcc GCC_MDSS_VSYNC_CLK>, > + <&gcc GCC_MDSS_MDP_CLK>, > + <&gcc GCC_MDSS_BYTE0_CLK>, > + <&gcc GCC_MDSS_PCLK0_CLK>, > + <&gcc GCC_MDSS_ESC0_CLK>; Please align the '<'s, make sure your tab width is set to 8 [...] > + multi-led { > + compatible = "leds-group-multicolor"; > + color = ; > + function = LED_FUNCTION_INDICATOR; > + leds = <&red_status>, <&green_status>, <&blue_status>; > + }; > + > +}; Stray \n above [...] > +&ramoops_mem { > + status = "okay"; > +}; > + > +&adsp { > + status = "okay"; > +}; > + > +&lpass_mem { > + status = "okay"; > +}; Please sort the label references alphabetically > + > +&pm8950_spmi_regulators { > + // PM8950 S5 + S6 = VDD_APC supply Let's use /* C-style comments */ [...] > +&tlmm { > + gpio-reserved-ranges = <20 4>; // Downstream doesn't use 21,22,23. 24 is mdss_te Let's keep a \n between the last property and the following subnode [...] > + tpa6130a2_default: tpa6130a2-default-state { > + pins = "gpio61"; > + function = "gpio"; > + drive-strength = <8>; > + bias-pull-down; > + output-low; Drop this property, the driver will take care of it Konrad