From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A901C433EF for ; Tue, 1 Mar 2022 05:54:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231516AbiCAFzH (ORCPT ); Tue, 1 Mar 2022 00:55:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56658 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229674AbiCAFzB (ORCPT ); Tue, 1 Mar 2022 00:55:01 -0500 Received: from mail-sh.amlogic.com (mail-sh.amlogic.com [58.32.228.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4346849918; Mon, 28 Feb 2022 21:54:21 -0800 (PST) Received: from [10.18.29.173] (10.18.29.173) by mail-sh.amlogic.com (10.18.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Tue, 1 Mar 2022 13:54:18 +0800 Message-ID: Date: Tue, 1 Mar 2022 13:54:18 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [PATCH V7 0/6] Use CCF to describe the UART baud rate clock Content-Language: en-US To: Jerome Brunet , , , , CC: Greg Kroah-Hartman , Jiri Slaby , Neil Armstrong , Kevin Hilman , Martin Blumenstingl References: <20220225073922.3947-1-yu.tu@amlogic.com> <1j8rtvxnkv.fsf@starbuckisacylon.baylibre.com> From: Yu Tu In-Reply-To: <1j8rtvxnkv.fsf@starbuckisacylon.baylibre.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.18.29.173] X-ClientProxiedBy: mail-sh.amlogic.com (10.18.11.5) To mail-sh.amlogic.com (10.18.11.5) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jerome, On 2022/2/28 18:59, Jerome Brunet wrote: > [ EXTERNAL EMAIL ] > > > On Fri 25 Feb 2022 at 15:39, Yu Tu wrote: > >> Using the common Clock code to describe the UART baud rate >> clock makes it easier for the UART driver to be compatible >> with the baud rate requirements of the UART IP on different >> meson chips. Add Meson S4 SoC compatible. >> >> The test method: >> Start the console and run the following commands in turn: >> stty -F /dev/ttyAML0 115200 and stty -F /dev/ttyAML0 921600. >> >> Since most SoCs are too old, I was able to find all the platforms myself >> such as Meson6, Meson8, Meson8b, GXL and so on. I only tested it with >> G12A and S4. > > GXL based board are still very common an easy to come by. > I'm quite surprised that you are unable to test on this SoC family The fact of the matter is that the S4 is our end-2020 chip, the G12A is five years old, and the GXL is seven years old. If you must ask for a test, I will report this problem to the leadership to coordinate resources. > >> >> Yu Tu (6): >> tty: serial: meson: Move request the register region to probe >> tty: serial: meson: Use devm_ioremap_resource to get register mapped >> memory >> tty: serial: meson: Describes the calculation of the UART baud rate >> clock using a clock frame >> tty: serial: meson: Make some bit of the REG5 register writable >> tty: serial: meson: The system stuck when you run the stty command on >> the console to change the baud rate >> tty: serial: meson: Added S4 SOC compatibility >> >> V6 -> V7: To solve the system stuck when you run the stty command on >> the console to change the baud rate. >> V5 -> V6: Change error format as discussed in the email. >> V4 -> V5: Change error format. >> V3 -> V4: Change CCF to describe the UART baud rate clock as discussed >> in the email. >> V2 -> V3: add compatible = "amlogic,meson-gx-uart". Because it must change >> the DTS before it can be deleted >> V1 -> V2: Use CCF to describe the UART baud rate clock.Make some changes as >> discussed in the email >> >> Link:https://lore.kernel.org/linux-amlogic/20220118030911.12815-4-yu.tu@amlogic.com/ >> >> drivers/tty/serial/meson_uart.c | 221 ++++++++++++++++++++++---------- >> 1 file changed, 154 insertions(+), 67 deletions(-) >> >> >> base-commit: a603ca60cebff8589882427a67f870ed946b3fc8 >