From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1CAE22F6569 for ; Fri, 14 Nov 2025 08:57:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763110648; cv=none; b=GO+a2elrpSAqYJz7JGbIM+RY2WLOxdFwo+inX4e4ehALZyBmYq/PA43J+xaGX905sLEYx2YwGxlZGQl9d3SXGO9Xraei7uXzarV+fkvXjMnC7yni3xlfEx3Dw16KC4D98W0LpX0/qFyhGvr42WIny6Rfma7rAMFhbh/qoqcxv6k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763110648; c=relaxed/simple; bh=368XzlnWR8kLrxRUK7EBdCdTiTfQn97LAfR3nFHllPs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qaRCK3kN2PnDW/2G+wi2ppNi3XNfdosKDR50wc2ooWs0NyvG5/xzjgRnt8Wdvkiyqbu6F8gHKCqvMbqgY5RuIlFMLabA5uDcOBZrywIDgFVtphY5CIBouRKdE3oF+mYWfSxR3+K0i7a2RufV98aV+WlwnCmh0dIckkADndETYT8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=To4Kkqr+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="To4Kkqr+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 25FF4C19425; Fri, 14 Nov 2025 08:57:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763110647; bh=368XzlnWR8kLrxRUK7EBdCdTiTfQn97LAfR3nFHllPs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=To4Kkqr+2c95gKtPy4kewCrPBWnMxgCxCbN+A0O1mulYdiy66DHdKldhOj+ltRBSM vqg+MODYMmEezjqVU6DQZuL31nAKYUaaHxN7hTxlzhSYXeQjvun5zrQtiPOa0TdkwE Qb/y/nxowj4bOrSDd3A57psqQgTs/XnbBxGg1GUkm3dzosbZgqqcm1tq4nSeOhcpKy kJ7v2wkTe2IF2fL2N7TPkoBV3ps8A0Fwu4Aplf2MtDCcmAwPMhR/yQButCuDUpZNl5 0W5hoJVIqA5SKv8yGGd9OhoPNiZLmUnWhY6Yxii9AfgzbQzZ9yvOsE9eBNuI5/ZQXq wAvtFXjVPoRvw== Message-ID: Date: Fri, 14 Nov 2025 09:57:23 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] Fix the name of the source file for the "FOLL_WRITE" macro copy To: peng8420.li@gmail.com, linux-mm@kvack.org, akpm@linux-foundation.org Cc: osalvador@suse.de, jgg@ziepe.ca, jhubbard@nvidia.com, peterx@redhat.com, linux-kernel@vger.kernel.org, dan.j.williams@intel.com References: <20251114085038.191031-1-peng8420.li@gmail.com> <20251114085038.191031-2-peng8420.li@gmail.com> From: "David Hildenbrand (Red Hat)" Content-Language: en-US In-Reply-To: <20251114085038.191031-2-peng8420.li@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 14.11.25 09:50, peng8420.li@gmail.com wrote: > From: "peng8420.li" > > The 'FOLL_RITE' of the copied source is located in mm_types. h of mm, not mm. h, so fix it. > > Signed-off-by: peng8420.li > --- > tools/testing/selftests/mm/gup_test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/mm/gup_test.c b/tools/testing/selftests/mm/gup_test.c > index 75f7134d529d..9cdcd10d3f6a 100644 > --- a/tools/testing/selftests/mm/gup_test.c > +++ b/tools/testing/selftests/mm/gup_test.c > @@ -17,7 +17,7 @@ > > #define MB (1UL << 20) > > -/* Just the flags we need, copied from mm.h: */ > +/* Just the flags we need, copied from mm_types.h: */ Can we just avoid the exact name and say "Just the flags we need, copied from the kernel internals." ? -- Cheers David