From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: "roy-cw.yeh" <roy-cw.yeh@mediatek.com>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Chun-Kuang Hu <chunkuang.hu@kernel.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Fabien Parent <fparent@baylibre.com>,
"jason-jh . lin" <jason-jh.lin@mediatek.com>,
daoyuan huang <daoyuan.huang@mediatek.com>,
Ping-Hsun Wu <ping-hsun.wu@mediatek.com>,
Moudy Ho <moudy.ho@mediatek.com>,
"river . cheng" <river.cheng@mediatek.com>,
Yongqiang Niu <yongqiang.niu@mediatek.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v1 3/4] media: platform: mtk-mdp3: Set dma_set_mask_and_coherent
Date: Thu, 21 Oct 2021 12:28:35 +0200 [thread overview]
Message-ID: <d0db66a3-04b4-1b1f-f6bb-8b45154559ff@collabora.com> (raw)
In-Reply-To: <20211021063414.23663-4-roy-cw.yeh@mediatek.com>
Il 21/10/21 08:34, roy-cw.yeh ha scritto:
> From: "Roy-CW.Yeh" <roy-cw.yeh@mediatek.com>
>
> Set dma_set_mask_and_coherent
>
Please explain why you're setting that and why 34 bits in the commit description.
> Signed-off-by: Roy-CW.Yeh <roy-cw.yeh@mediatek.com>
> ---
> drivers/media/platform/mtk-mdp3/mtk-mdp3-core.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/media/platform/mtk-mdp3/mtk-mdp3-core.c b/drivers/media/platform/mtk-mdp3/mtk-mdp3-core.c
> index 1e61ac7ca790..875326afb686 100644
> --- a/drivers/media/platform/mtk-mdp3/mtk-mdp3-core.c
> +++ b/drivers/media/platform/mtk-mdp3/mtk-mdp3-core.c
> @@ -1141,6 +1141,8 @@ static int mdp_probe(struct platform_device *pdev)
> mdp->pdev = pdev;
> mdp->mdp_data = of_device_get_match_data(&pdev->dev);
>
> + dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(34));
> +
> ret = of_property_read_u32(dev->of_node, "mediatek,mdp3-id", &id);
> if (ret) {
> dev_err(dev, "Failed to get mdp-id\n");
>
next parent reply other threads:[~2021-10-21 10:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211021063414.23663-1-roy-cw.yeh@mediatek.com>
[not found] ` <20211021063414.23663-4-roy-cw.yeh@mediatek.com>
2021-10-21 10:28 ` AngeloGioacchino Del Regno [this message]
[not found] ` <20211021063414.23663-5-roy-cw.yeh@mediatek.com>
2021-10-21 10:44 ` [PATCH v1 4/4] media: platform: mtk-mdp3: Set rdma compression reg in each frame AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0db66a3-04b4-1b1f-f6bb-8b45154559ff@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=chunkuang.hu@kernel.org \
--cc=daoyuan.huang@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=fparent@baylibre.com \
--cc=jason-jh.lin@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=moudy.ho@mediatek.com \
--cc=ping-hsun.wu@mediatek.com \
--cc=river.cheng@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=roy-cw.yeh@mediatek.com \
--cc=yongqiang.niu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®