From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 613E837DAA6 for ; Tue, 1 Sep 2026 08:40:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788252043; cv=none; b=RBz3epaADoD6t5cxRTyl0tjiterSJXEg8R4bAZEo0TJdPsqbb4f0KGYHI2QG/mBQh/rKo1ES4dFNBqKVrNhFUBrDgDJ9iSjtIFmmgjw/rE8ZoeDB9gzc8WJTiWe1qnXbZ8VP0yW8SRgNukvCIri58KDbpp/2dZZalQ+uI4TsUws= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788252043; c=relaxed/simple; bh=rTaBtC2Ab9kL3a8HvVSj7rD6WzTL3wiZAMIiWKZuQJI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AaAyqjNW4QdFlmKJj2VWo+FUPADYRq/WVErN5wCaGfS/TMzgOvViRIu1pnqcMYlNO0M6ITpfUmbKf/RgVSVltcF5ZOjV7UPpiK5fIGWEWBFKDjs56TzTlu8iXA3yUUQw0+WAQuPFXa7Nw/1YwY+mziDulP0DXFL/hfGnUSmS82o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=L19RR5hy; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=o+C8w8Q5; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="L19RR5hy"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="o+C8w8Q5" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788252041; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xHSbqtb63+WVJXZL+2bipMbSfoPG86BNGlDDfyVTiGE=; b=L19RR5hy1oViGeESWDcM0AEGHj++fdC/tyl+mDZ8lOnvam4PlZH7Tlfz7qe5b9Zy0aztG+ hTCLxo1yHh1mdvyrCZYaBy0D/SCpbJ399vUdge66xEpXx7TAOLsKd0WCzxtJF5qndaaGQC VJld0DjNi2lrWR/bMccykh7VlRUwwtI= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-205-jC2qDkJhPnKz1nBuZmba6g-1; Tue, 01 Sept 2026 04:40:40 -0400 X-MC-Unique: jC2qDkJhPnKz1nBuZmba6g-1 X-Mimecast-MFC-AGG-ID: jC2qDkJhPnKz1nBuZmba6g_1788252039 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-49cced8309bso4976465e9.3 for ; Tue, 01 Sep 2026 01:40:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1788252039; x=1788856839; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=xHSbqtb63+WVJXZL+2bipMbSfoPG86BNGlDDfyVTiGE=; b=o+C8w8Q5MgTKx9J40fIaeFcaJ8sQ6vCCsY+jnnApI16Ek+Ct1mb/V6MFSvzfeGZSKp rT52bOtrxArFSJjQ6mXXxVNz0/2kPe82nAqiaMeplJ4fjcweuUahMQxtYHAOgq9a37Yx ybwrw5WkjW0rkcM5ZV4uwVfuIxFHq6zdi15XDG6P0qAZJ3pPBJIKczLe3upV5EMnf1Xj TeHXCsbTI6m4JNO+EDqSF6MWI+CKuMHfHDDpuPuipOdqcjTumj/I6KECUBRG30SmChzp Dn5/bDe34uCZgC4QGnv6Jr7FlQOAip+em2tVk5lxzj/xSgiRXRbUFSA+RqFZUl+SoEUD +4LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788252039; x=1788856839; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=xHSbqtb63+WVJXZL+2bipMbSfoPG86BNGlDDfyVTiGE=; b=QfII0Anpinuvny3DMmoSF/WRfyYxearcQlcptz9kZeaoSWzesmZ7xCfXILJmyi/MlB GFCKBkIgCemaJwPnnaVo8GRU02ioFqxqDEqd3fbnNXLPC915aoTITmWPt8fHCZJKTOUA W3I1bKpy65uQ+jxIemlGs/xk8lU0/ps4Rv3c9Lryw5JDIxNNwcqxwtCDobJ/bq6Yb/NJ 9zjfmEzYd/MT7YKHPQbUI+HijVgNX+RdnDErv+bWiOtlnKQVnnHMEaYStU7gBfwxczt2 gXbxcBcxeeAhUlQgvEM0hs8Xs/aiBKie+DieQuyU2vqso/8m4fu0c5oP3NnZqIHT8ghE gWWA== X-Forwarded-Encrypted: i=1; AHgh+RqxGOFbg15FHR8HmZ0cu/BN33DLRd/9JYObviceHWT4EFbXLd8zI81xRrryLCZg8+is3UaMszEbo64XMCU=@vger.kernel.org X-Gm-Message-State: AFuF++mhOYvtl/yS87iuXsiplnQ4X5TB+bebBmCYQbwuf+aDp/VMsGWx BP+g0sPH234Qw3wqMKlqVxmLi1cV1tKtwLCVoEfA0XdI6w5A1CVh5DTK5dtZz7fkYHEwIoATL7H giAZR+Dlan1XWH0OYiH5kNybjjVexW8wo93hvroVvaE770XMN6nrxQGAZv2cYNmWtuw== X-Gm-Gg: AR+sD124B8sjMN3qZVAIIe1gCUrxuLAV2XG4v1XE4zF7MMc8pP2qSfciPe/JU99N/dL usE1ey7+EbZIXkfKhWO8nABHy5OYO4eqvsWPGs7o1OBkxfAsfZf/FiNNZTcQUeL1oQwo38oDyRA jHxMiiU4/gHi+zgnX/5mafcY5LVz+O8fRgD56yHQR5sbZEoUeu6KhmTuiip5D+8jrdBtaOFM6/A gwKB6GsRzGBzp2dtuN8dqp/FoY9ySGWCsiw8VNzD+Eq39upDVwrvUHhytvjHSha15gM1ab1wFlX onTqy9KLxR8Xeqc419TBGs8fz5Tx+UWOypakX+VdzKmkHioqJHI1hRTKREVk5ztY8Jq3QCvbNDZ 8b5W9K9AeDGi3iax2gtIFejqh7pkUnzmPOcQLHmeaPbGFMMdaMtcUq8+oGEi117rBxsjS96Fzbg == X-Received: by 2002:a05:600c:1c13:b0:49c:df2b:15fc with SMTP id 5b1f17b1804b1-49cdf2b179amr60516875e9.8.1788252038379; Tue, 01 Sep 2026 01:40:38 -0700 (PDT) X-Received: by 2002:a05:600c:1c13:b0:49c:df2b:15fc with SMTP id 5b1f17b1804b1-49cdf2b179amr60515525e9.8.1788252037895; Tue, 01 Sep 2026 01:40:37 -0700 (PDT) Received: from [192.168.188.103] (ip245-45-231-195.pool-bba.aruba.it. [195.231.45.245]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49ce18dbae2sm6966555e9.13.2026.09.01.01.40.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Sep 2026 01:40:36 -0700 (PDT) Message-ID: Date: Tue, 1 Sep 2026 10:40:35 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v3 1/2] net: dsa: mt7530: populate lpi_interfaces to fix EEE support To: Aleksei Sviridkin , "Chester A . Unal" , Daniel Golle , Andrew Lunn , Vladimir Oltean , Felix Fietkau , Lorenzo Bianconi , "David S . Miller" , Eric Dumazet , Jakub Kicinski , netdev@vger.kernel.org Cc: Russell King , Qingfang Deng , Matthias Brugger , AngeloGioacchino Del Regno , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20260827211652.63504-1-f@lex.la> <20260827211652.63504-2-f@lex.la> From: Paolo Abeni Content-Language: en-US In-Reply-To: <20260827211652.63504-2-f@lex.la> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/27/26 11:16 PM, Aleksei Sviridkin wrote: > phylink_create() decides once and for all that a MAC supports managed > EEE, and it requires the tx_lpi ops plus non-empty lpi_capabilities and > lpi_interfaces. mt753x_phylink_get_caps() leaves lpi_interfaces empty. > > So ever since the conversion to phylink managed EEE, ethtool has > answered "Not supported" on every mt753x port, and phy_disable_eee() > has locked userspace out of turning EEE on. That undoes what > commit 06dfcd4098cf ("net: dsa: mt7530: fix enabling EEE on MT7531 > switch on all boards") arranged: EEE off by default, but reachable > with ethtool. > > Leave the speeds above 1 Gbps out of both bitmaps. PMCR folds > SPEED_2500 and SPEED_10000 onto PMCR_FORCE_SPEED_1000, so > PMCR_FORCE_EEE1G would govern LPI on such a link, and that is > unvalidated rather than known unsupported: MediaTek's SDK driver sets > the EEE force bits for 100 Mbps and 1 Gbps only, and the unit of the > wakeup timers is undocumented with the port clock at 2.5 times the > rate. > > LPI stays off until userspace enables it, but the EEE advertisement of > a PHY that advertises it out of reset comes back, since phylink stops > force-clearing it. > > Fixes: 9cf21773f535 ("net: dsa: mt7530: convert to phylink managed EEE") > Signed-off-by: Aleksei Sviridkin > --- > > Ports that support neither 100 Mbps nor 1 Gbps are skipped because on > MT7988, EN7581 and AN7583 port 6 is 10 Gbps only and shares > PHY_INTERFACE_MODE_INTERNAL with the user ports, so the interface mask > alone cannot tell them apart. MT7531's internal PHYs keep the > advertisement mt7531_setup() zeroed and EN7528 keeps both bitmaps > empty, so EEE stays fully off there. > > Two pre-existing things this patch makes live, neither addressed here: > > - The unit of LPI_THRESH is still unspecified, as the comment above > lpi_timer_default says. ethtool now reports 30 for a switch port > against 1000 for the SoC MAC, which is a driver constant already in > microseconds, and mtk_eth_soc treats a structurally identical field > as milliseconds. Does anyone have the datasheet answer? Clashiko complains about the above: https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260827211652.63504-1-f%40lex.la @Andrew: WDYT? /P