From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 218B724023A for ; Mon, 13 Jan 2025 16:48:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736786891; cv=none; b=qBKwE/LwePVagrir3q0dFmqrxqLOlNG7ovB40pgVzQwKkIjynn72UtOKpfINUh8GXvAH+HqW2XkdB0zPWuWvGdsCbiiL5TLKwAXbM7iHe6Xow3hzWAhj5aDro78Bln0lfFTJ4qmVBVGcbyLoTMppwhomt73/+bk2aEWt7J+ouTg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736786891; c=relaxed/simple; bh=uawQNnVORCsCtDVNK5OjHXpZvyzfrQp2eZ2UhpxZEaA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NwSIepoKVbRCRQ4wY1AYNi/yPE3m1/xhN/qJDLgT4L/5t3AOh0UBsY1CPGdHFaPH/suZrx1o52ffQK2cyIS8iiZieCyzWqDL7Xq7JRcAIreM0D9zD98OrIey3BHOL1Xj6Hx5yA5P8bb7s+WOsI4Aof8itjB/5C46TcV9gNmdJeo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=yAQmWZCE; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yAQmWZCE" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-436ce2ab251so32769765e9.1 for ; Mon, 13 Jan 2025 08:48:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736786888; x=1737391688; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DCDwiC2ChTMIMuF5sErsTKTOGH/i2ual/aPVMi/EvR4=; b=yAQmWZCE5sXqFIu3g6KT4nV/bF7qOdZuEUvdQ7flwDGivtti2gl3L2/Z1OPiwTY47p VIDVk51mzhw0ozt41pWMNV+PbhQG1aR8ajIl4FnVRuKsryUVVIzAkofs2frBobUMLeDs OQIgnyhKCl8LY7UdPMq1PtMEg+y3M0qQs5Esse9A8Kbdk00hzzUrqfw7l12Decsg19kt KPyUNX3WnELJiNuMA6x/EeSv4HloYckkD3SBJfQ5XsgmN/RFWyCCbQwrdNECu9AqpGtD L6yXuGRQXaSZasXxRYod/rsV65/YLfNOxrPLfivBKGmlKeyZdLkTrJxfh1LDzlOKSKEL rugg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736786888; x=1737391688; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DCDwiC2ChTMIMuF5sErsTKTOGH/i2ual/aPVMi/EvR4=; b=l6GeWarCEmYJh6n4vIXf2S6vVDGSWMT7s3LHGKD23BbcRlk8bSGboZR4Yih7gZAWq+ abbshfRzJgFkjtVzyoD2l+Oz6OhO8L9Vp9oA5fIeiSUlVV95lgad1zHrMB+lawSaRKH3 NtBYHf+C7tEyVEpceX4XED5umClUiU+taPJ41rZnZGnaVMbkGiAZ8w9mSS03SUVowlNa kk1Cz44HVxwQadf9vSoy1UF485iroTatnmI3c2LuAtstzw5lrif7LONAcQFpwJNP1pPo 0DQkIOFbIj/wwJcmm3Fgu9UWqxpouqwH1xdcx2Sds+6NxmOI0e6C+e6aq7A5lYlenDi6 OuiQ== X-Forwarded-Encrypted: i=1; AJvYcCVGURPItNUnLw9VoUf/6kHR22XwPfzRIz/J+Igp6Zc+6esHfEEGVV3LFnxP0K2fHQInWpT6ptePuDDxRig=@vger.kernel.org X-Gm-Message-State: AOJu0YyhOcou++IPezrOr3ZecbqTAU8/uRaaHtgLUOXkl1zXF0vikMBk vH/WAqz8Ma+QZQbN2K3QvbzBsHoQpSbLyDMrp8axYskXAflmiIqv5+4GLPsp9A8= X-Gm-Gg: ASbGncs7/iCNqiEJSJcgqseyp64a7T6LWa+bn7dcqX9Y1boGvns/GdCBhyvfKoSkgeo geTWkbU/pRg4J6fLmbAajBlQJ2tamned4d0wKuRpAiqoHyM7cIQmRCaD+ZnbiBI2GSl2CorWQU3 aoHjWv4bd6rO3iDoj4C33BJVGRXVlzCGK22rZNeZQzvbDU9zLue6rtboPgDjTUAqCIgBVQZLOz7 SWCIw8D79HxIv7KcjYGXS6r24Uw5btHvc2iLfLuW/iJctCOmy7GKOLFKqIh4K6NEkFm X-Google-Smtp-Source: AGHT+IER6KYF6RQvQUMNV9juLdwNdllc6fPKkCHKfac+vsy4zTDSEgoZ/Ee/dPPZGpy7n4GhLF2KjA== X-Received: by 2002:a05:600c:1987:b0:434:a386:6ae with SMTP id 5b1f17b1804b1-436e267850cmr200788085e9.7.1736786888373; Mon, 13 Jan 2025 08:48:08 -0800 (PST) Received: from [192.168.68.163] ([212.105.145.205]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436e9d8fb99sm150640805e9.3.2025.01.13.08.48.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jan 2025 08:48:08 -0800 (PST) Message-ID: Date: Mon, 13 Jan 2025 16:48:06 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/2] perf vendor events arm64: Add N3 events/metrics To: Ian Rogers Cc: John Garry , Will Deacon , Mike Leach , Leo Yan , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Adrian Hunter , Kan Liang , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, Nick Forrington References: <20250110172006.680753-1-irogers@google.com> Content-Language: en-US From: James Clark In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 13/01/2025 3:51 pm, Ian Rogers wrote: > On Mon, Jan 13, 2025 at 4:35 AM James Clark wrote: >> >> >> >> On 10/01/2025 5:20 pm, Ian Rogers wrote: >>> Using the scripts at: >>> https://gitlab.arm.com/telemetry-solution/telemetry-solution/ >>> >>> Generate perf json for neoverse-n3 using the following command: >>> ``` >>> $ telemetry-solution/tools/perf_json_generator/generate.py \ >>> tools/perf/ --telemetry-files \ >>> telemetry-solution/data/pmu/cpu/neoverse/neoverse-n3.json:neoverse-n3 >>> ``` >>> >>> Signed-off-by: Ian Rogers >>> --- >>> .../arm64/arm/neoverse-n3/core-imp-def.json | 930 ++++++++++++++++++ >> >> I assume you got warnings about missing groups, if one is missing that >> results in everything being dumped in core-imp-def.json. I have an >> internal ticket open about it which is why I didn't post N3 and V3 jsons >> yet, I'll check on it again. > > I was testing with JEVENTS_ARCH=all. I'm not sure what the group > warning is, do you have a link? > From the perf_json_generator: $ telemetry-solution/tools/perf_json_generator/generate.py \ tools/perf/ --telemetry-files \ telemetry-solution/data/pmu/cpu/neoverse/neoverse-n3.json:neoverse-n3 Warning: Not writing events which do not have a group (note that the mnemonic printed may differ to the one in the source json if it differs in the common Perf files): IMP_CT_FLUSH: Counts flushes including architectural, microarchitectural, and branch redirects. ... >> Up to you whether you want to continue with it like this and I can send >> a fix up later but there's also a conflict with the recent Fujitsu >> Monaka events. > > I'm happy to let you push the updates. An alternative, that may work > around the group issue, is just to push the event updates. Any chance > on an ETA? > > Thanks, > Ian Can't say on an eta. There was a fix already done but not made live yet, but now it turns out maybe we don't want to put these particular events into Perf because they're not in the TRM. Could be several weeks before anything goes live. It's a bit of a hack but I can regenerate them without these particular events in a V2, and then whatever the outcome is from above will be an incremental change later.