From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76B8A21A435 for ; Fri, 14 Feb 2025 11:15:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739531718; cv=none; b=iHoX5UUvX2JL1T71QqmiwwYNdvgjqZjPJeW91ezeIk6X3JQPm68mL5fhScQGovorRKgzA4HWKVduBh5nX/06OQdNy7oZ8R8dm8C3Df+F4zTzKF6AihXtGgC61em6a5Wz47ZC4uR0ukzxX6dWjbmC477rUCh4gjB5ACBG+ZgJgnQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739531718; c=relaxed/simple; bh=Byc7coW9dudIXZ8IkgWh7fAF1R3OFkHSFllItq8iXtM=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=bYhc0/u4sy1QS9MrpfPtfP/cUajrEOgY6VSBpA0rHcIR1BIhdAJOsFE3nx78zYtnFu7InfOi5tbC4zeHQsHs5Bm33XJqAKuJV4ELMJyG7rCsSi/ZiXFlz1ZiXTmiJuLKhxgUn5SGvyk8BBmuev3xi7alA2TtROrunfBn7ptiKrQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=yx/B4F3N; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yx/B4F3N" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4396424d173so15893495e9.0 for ; Fri, 14 Feb 2025 03:15:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1739531715; x=1740136515; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=QmEs8ouBliGOCMobju3l9AIdN9DwWGs50L/Ux0bkJ98=; b=yx/B4F3Ni1V58MQMZ0MeiyadUjq/XpVfwquVToTEyzdz/O4b0VWt7iNleWjmRrTqc/ FD9Ma5ptv9FVmfFoHHoZ0bZEHupsfCtVGP7/tS9CnbT11ApvOJrROfU5868xG8BQsmU7 XDVe3sp2hi79MC1w7LXlZOaMgPle6/VelUwg7MDCay2d0O3YrcrrXWmSY9Yu01Z6ib7M 4RKRAljD7Zztfmuvsj1KxAPYbNnrBP5gZ3wA6fE7ZWmHCyuVXdbK76+kdZbOeraEG4jZ pc4vh/uYFJENeax8mLdgNUZMES2PNTnJvMItgeftBqJgTwBd5q5ciykGIjEj998w9/OX xZPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739531715; x=1740136515; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=QmEs8ouBliGOCMobju3l9AIdN9DwWGs50L/Ux0bkJ98=; b=Lr7++z4L0s9agJGghf015GyOx+/yfnrKhZ+Z0uYeGjxYyL23/PMP8aoxbvauvf+IGF s2sF2hX4B7I+GCTiwsiEiL75hhBcoc5C8HKXLFU5z6wRgNaZIHw5xLJ7f6QLzGrFVZOU VcJxHTljLQ/jDepkauiDCJ6Y4svH4m1F6BDNz2s01oSn3Uw9VmbxSc47z5JZ+PQOr3k7 BbP51pvKfzG1M3smivVPBNCRdkfac4ULkk5bw1uVB2M8xCdAihkphFs/vy6hNw5V228m e5u7L76BQwh/yqc15yEn8carr3WCLyCgiklyya6oM5H2YG7J/44AmuBIbw35+2N7bCId iZiw== X-Forwarded-Encrypted: i=1; AJvYcCXZM2NFR5GT5kD4FnlURNkbc1ehdC12difKSzi+Kdn/cs9TpF/954jGvhlXfr3EM+zUY3W4ucDPLlLftaw=@vger.kernel.org X-Gm-Message-State: AOJu0Yzxlmdq7Vqz3cPljjWmdyih4NEgzJpc/lFCVCPxlodMTm1Ilfku MIVgXkXK+sy5eONvwISeIsQAzZloduas6/ZDSO9NXtCCYnRBw6D9Ge3F/3Jo/m0= X-Gm-Gg: ASbGncvgQWFyJS23PhEG/+z2PBchP7w0Hl/+nRDTBspDgHGmfYakX644fBqGll+ROXe na8rAUAw4EqhW5037L2nyFrkKwn8nQ95KASJjG0tl6IC8tijigBPjS+izQqif/WbRnvfEZvwiOu kdub5RcU3Kj93y7HaGmAQb3wCxAhcH4+/f3JgRbMqFFMuvUn60y/ug9LpOi6JeGLCvM68SpKVfG k2mhLwccBkBg4RdzMxHmUlxkq1zdc/nprxQcMasNk03pmyVFeiwKa7YFMuANm3n2NxnfgD+sM5x FR4ng+9Byu+3tFJRT848jbeGq3mF86xqyIK5yWhLGl8AcMQ77/gTvHqe7nTR4qQ= X-Google-Smtp-Source: AGHT+IH5QDoLnhR0CwlUWQfd6my7FcGNb6CjS78uJgkB/lJP1TtFLz/ksqBTEmg2Q8Mj2ObQDYbmrg== X-Received: by 2002:a05:600c:783:b0:439:654e:ddf6 with SMTP id 5b1f17b1804b1-439654ede03mr61452765e9.9.1739531714673; Fri, 14 Feb 2025 03:15:14 -0800 (PST) Received: from ?IPV6:2a01:e0a:982:cbb0:1506:c298:390c:8a? ([2a01:e0a:982:cbb0:1506:c298:390c:8a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-439617da91asm42409885e9.2.2025.02.14.03.15.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Feb 2025 03:15:14 -0800 (PST) Message-ID: Date: Fri, 14 Feb 2025 12:15:14 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH] clk: meson: g12a: Fix kernel warnings when no display attached To: Martijn van Deventer , Jerome Brunet , Michael Turquette , Stephen Boyd , Kevin Hilman , Martin Blumenstingl Cc: linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20250213221702.606-1-linux@martijnvandeventer.nl> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20250213221702.606-1-linux@martijnvandeventer.nl> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 13/02/2025 23:17, Martijn van Deventer wrote: > When booting SM1 or G12A boards without a dislay attached to HDMI, > the kernel shows the following warning: > > [CRTC:46:meson_crtc] vblank wait timed out > WARNING: CPU: 2 PID: 265 at drivers/gpu/drm/drm_atomic_helper.c:1682 drm_atomic_helper_wait_for_vblanks.part.0+0x240/0x264 > CPU: 2 UID: 0 PID: 265 Comm: setfont Tainted: G C > Tainted: [C]=CRAP > pstate: 60400009 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) > pc : drm_atomic_helper_wait_for_vblanks.part.0+0x240/0x264 > lr : drm_atomic_helper_wait_for_vblanks.part.0+0x240/0x264 > Call trace: > drm_atomic_helper_wait_for_vblanks.part.0+0x240/0x264 > drm_atomic_helper_commit_tail_rpm+0x84/0xa0 > commit_tail+0xa4/0x18c > drm_atomic_helper_commit+0x164/0x178 > drm_atomic_commit+0xb4/0xec > drm_client_modeset_commit_atomic+0x210/0x270 > drm_client_modeset_commit_locked+0x5c/0x188 > drm_fb_helper_pan_display+0xb8/0x1d4 > fb_pan_display+0x7c/0x120 > bit_update_start+0x20/0x48 > fbcon_switch+0x418/0x54c > el0t_64_sync+0x194/0x198 > > This happens when the kernel disables the unused clocks. > Sometimes this causes the boot to hang. > > By (re)adding the flag CLK_IGNORE_UNUSED to the VCLK2 clocks, these > clocks will not be disabled. > > This partially reverts commit b70cb1a21a54 ("clk: meson: g12a: > make VCLK2 and ENCL clock path configurable by CCF"). > > Fixes: b70cb1a21a54 ("clk: meson: g12a: make VCLK2 and ENCL clock path configurable by CCF"). > Signed-off-by: Martijn van Deventer > --- > drivers/clk/meson/g12a.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/clk/meson/g12a.c b/drivers/clk/meson/g12a.c > index cfffd434e998..1651898658f5 100644 > --- a/drivers/clk/meson/g12a.c > +++ b/drivers/clk/meson/g12a.c > @@ -3234,7 +3234,7 @@ static struct clk_regmap g12a_vclk2_div = { > &g12a_vclk2_input.hw > }, > .num_parents = 1, > - .flags = CLK_SET_RATE_GATE, > + .flags = CLK_SET_RATE_GATE | CLK_IGNORE_UNUSED, > }, > }; > > @@ -3270,7 +3270,7 @@ static struct clk_regmap g12a_vclk2 = { > .ops = &meson_vclk_gate_ops, > .parent_hws = (const struct clk_hw *[]) { &g12a_vclk2_div.hw }, > .num_parents = 1, > - .flags = CLK_SET_RATE_PARENT, > + .flags = CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED, > }, > }; > > @@ -3354,7 +3354,7 @@ static struct clk_regmap g12a_vclk2_div1 = { > .ops = &clk_regmap_gate_ops, > .parent_hws = (const struct clk_hw *[]) { &g12a_vclk2.hw }, > .num_parents = 1, > - .flags = CLK_SET_RATE_PARENT, > + .flags = CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED, > }, > }; > > @@ -3368,7 +3368,7 @@ static struct clk_regmap g12a_vclk2_div2_en = { > .ops = &clk_regmap_gate_ops, > .parent_hws = (const struct clk_hw *[]) { &g12a_vclk2.hw }, > .num_parents = 1, > - .flags = CLK_SET_RATE_PARENT, > + .flags = CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED, > }, > }; > > @@ -3382,7 +3382,7 @@ static struct clk_regmap g12a_vclk2_div4_en = { > .ops = &clk_regmap_gate_ops, > .parent_hws = (const struct clk_hw *[]) { &g12a_vclk2.hw }, > .num_parents = 1, > - .flags = CLK_SET_RATE_PARENT, > + .flags = CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED, > }, > }; > > @@ -3396,7 +3396,7 @@ static struct clk_regmap g12a_vclk2_div6_en = { > .ops = &clk_regmap_gate_ops, > .parent_hws = (const struct clk_hw *[]) { &g12a_vclk2.hw }, > .num_parents = 1, > - .flags = CLK_SET_RATE_PARENT, > + .flags = CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED, > }, > }; > Reviewed-by: Neil Armstrong