From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com [209.85.128.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8C11358387 for ; Wed, 4 Mar 2026 18:25:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772648733; cv=none; b=fOy03lmrltKtr/g3KJGUvlwa9UKFBOXZYLcCsHAujPn3fNu5N81vmcWEhtrmH1SM4PRG6vENyxw5wqei3rscLfuIca1FaoPAuwkd5bHvu6b7gvkWmbSl03Ym33KXGVkdOQOZnjrqtIlRDxSe7XmudcE8i8osr7aN1ZBgg0w3z1k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772648733; c=relaxed/simple; bh=NPqBeiKnoQNdKkDIOfiBxTXQITaXsqB1SliaeYafsRY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QypccAiEN/heghQvh+Y/cTME0g1ec4qduk2ZLYbCF9oWSJ2IOXDYSVBLfzkU/IrVTsBiWDDo9k3m/lqT2KUpxl3fQ51S3BaEdjznN5xXrB2O8D63177Ts7oXSmyWP2bCZ33HNptWdLZR75UmmiGqTnvYGoJhxrIBGX8dlKtDVw4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=60228.dev; spf=pass smtp.mailfrom=60228.dev; dkim=pass (2048-bit key) header.d=60228.dev header.i=@60228.dev header.b=GAARg1kr; arc=none smtp.client-ip=209.85.128.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=60228.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=60228.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=60228.dev header.i=@60228.dev header.b="GAARg1kr" Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-798374d0f44so109272227b3.0 for ; Wed, 04 Mar 2026 10:25:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=60228.dev; s=google; t=1772648731; x=1773253531; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gcMEnbL2iZRqIcSyrGL6+W1oNYGP8pNhj8CwblCdVG4=; b=GAARg1krJjVHGIBHWwM8+ps8I46DIfB4zuWUx76yGYY2/dhAImCkiTUeUvxxqIgMDH FKTYyrXg6dUHvUvIe1HntddX6LE9dFwvgELZY2ceDfGEp/MXZE8g9thHDWXeMUhoCzgH 1faLA3zMC1IR6etJlz0uJl1TzWQUqrqSKb0zlgzqMOzP0mY6gYHNQ5O6+tp1IxeTf8rJ DF0lC0jfd0MGmQtuFFnvqskoRbg73ZVzW72y88KonU+NvekB+7qi/5Ayittp//vVk2Ap QOASuRD5rnDM2cNu3Jgr8FRjIsYLtDAKEhnv8asdp4drK6pSjVn6LQaqgk5Zh+lokPHR NA7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772648731; x=1773253531; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gcMEnbL2iZRqIcSyrGL6+W1oNYGP8pNhj8CwblCdVG4=; b=kuonT0oefqYeubIZgsIgGzYaRwzuT9Zacu1cQqd3fAabVheBij5cHSFTFQW/vpoAXB YWZ/LGnyjw2CsRx9FyNcTA+XIpk3DSPPw+WN4dBd/huliF2jRfjvNE3NXJeWadC/yE3+ lx6n7YlcedJzL5qeai3oZvACR4xIPNE9K1fqu0qccmTjRYALLbEdUZ4gs/DWoxK/N+f5 9Csl7RQQWLs4OXdUZPpK2QxV4mu1QhkSqce0HLcPBOClxud0tlzByjhxopkZeSF8eFZy 2yC9GCKHjx1n6PekzBB+c/v3HCYCg67MxUQ9UWENcXfySnuuekCKO3kvpxtpw3k93MX4 vwRw== X-Forwarded-Encrypted: i=1; AJvYcCVUjLSQWW8GvFHpW+XId/5663eonyzszDON8IsxWY84xnp9FmjFcAhSfsZqTk6eGzns/8rlg/5cdCWp8Ag=@vger.kernel.org X-Gm-Message-State: AOJu0YzI1bfk7DfTVUm8QwH2anwrltFmG7kP0EfsMgKi2cW7nTjpYKd/ 0ndkVnlIF3jzOU5/+2WLf7iE7JAvWlLP9VZ0ZiQeaTZ4oxja4R1WiuvcR0AovqU+/M0= X-Gm-Gg: ATEYQzwvLn0lz3XFWKdJPFaJfdGBT5+S0kZSE2Y+cFHV9DwrzTLRo1ayr0qqOuyU6/5 JuFBgpbfO57+eC/ZJLP1FbETshVP3rDyKoBCpS2fJjXzhHbHTEJGz2ImielxwdjE2rkGgm7vK5A KSp9CVH3xQptABtaEEhitdHahKGVY+OiDrAbn+dgdUmkh1dMuWR6jVG8x6NkCpdaITFxX3uK7FN 3Irt9R5gKbGDZ0jHAMc7P6vyrCww67F8uPN9QXY/4x0o5c1T35UPe4tX/tQZvo95pu4zrgNGxpE HMacNrmZhzMJm9MnjRmuKmznOm5dbFMdOsb8hFgfhH+cMwbNcIv1UiRubptJhqwtmxIZSnz3Bz7 GUsY4+ASgB48zirSnUwTxmCBL90bg905cN+mWmog6pDRJtTWMphpNEbz0fWd4eTJ1ngGge8Hc1t GbJ6j8EkpVseVvNZr+AK4Tn2KpuVJrB2+iwU+aXaBpO1Fk6uYIiyePKfHR3tjU0MvX/Q== X-Received: by 2002:a05:690e:4188:b0:64c:9bf0:3055 with SMTP id 956f58d0204a3-64cfaabb185mr1935952d50.6.1772648730768; Wed, 04 Mar 2026 10:25:30 -0800 (PST) Received: from ?IPV6:2600:1700:2760:3c1f:8653:d57b:8d78:ca9d? ([2600:1700:2760:3c1f:8653:d57b:8d78:ca9d]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-64cb7626e49sm7978563d50.11.2026.03.04.10.25.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Mar 2026 10:25:30 -0800 (PST) Message-ID: Date: Wed, 4 Mar 2026 13:25:29 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] HID: quirks: add quirk to always keep device open To: Benjamin Tissoires Cc: linux-input@vger.kernel.org, Jiri Kosina , linux-kernel@vger.kernel.org References: <20260304033245.445671-1-leo@60228.dev> Content-Language: en-US From: leo vriska In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, > It seems 2/2 is dealing with a USB device. So why not simply make use of > HID_QUIRK_ALWAYS_POLL? It seems like I misunderstood what HID_QUIRK_ALWAYS_POLL did when I was reading the code before writing this patch. Sorry about that! It does seem like a cleaner solution to this problem, and I'll send an updated patch that just enables it for this device. Thanks, leo vriska