From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.216.99 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794981736; b=U46dIMtvEdpISYWGeJRvlidpnM/9bdd169Jz+BQ3+v8xkXcIrihw3h1IeYWpPK5hkCpp 5TyTDttHCn3XgEj9O04TgYjDSyvoqFaKPV7fqRa5q7g4LGVMl8jC0AZXPncjztPA2+OFU piuSST02TkHsV1OgUMZF2j5XWsHRtcHlijU8J/yDnIcCRQkU/PIL/Nfr4EegK/QoUlDnS G0m2RvjjRBegSgrYKdqmNScgJAR9A/9c+/gxffzjNQnQLG1oiHWRkVJUKiAb2Y0tXZPAi zI3gz3AfqGUrQg4vFkftkL2Lvg2rRPCqLcCJADgHZSyZrK4EeK2LU5f/b0uKI0wBhXg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794981736; h=DMARC-Filter:Received:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:Received:X-Relaying-Domain: X-CFilter-Loop:Received:DKIM-Signature:X-Forwarded-Encrypted: X-Received:X-Received:Received:From:To:Cc:Subject:Date:Message-ID: X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding:X-DetectorID-Processed; bh=I0NMn6fHPSVKHVHVNpMiE+ggLiJC/6XmQS3TcCioiGQ=; b=AjXepDRBiWKkEOeNgUQdczyug4TxWb+k/e1kK4tuD0mfCfVZeGxTzj/ky/S2MmRkVyPE GPcztAUs0ATJN+Ft663Namf5lCri253rCP6a6y/oxT03j7HVhBUw/0ZW6Vir3b4qG2cjC l3Z4z5jnkng6uTgc5hgo1x0fUTVSGZr4U13+KxpXQGnb4EB8urFaWRRixPrgFt8MvCbQq 6hm512V+98AyrGn6pgI2YhWqYmgajbJZfFncOCKsO2mzWYAF3R6jdr3zzKIa6zzx9iWaU Cx5nYqLO3nVVAfFtaUNCQZKDGIDTxzFcjOlooZ+6ycKMW6PhPUtlsbYvKAfkRAacCIA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass header.d=broadcom.com header.i=@broadcom.com header.a=rsa-sha256 header.s=google header.b=cQgsmFTw; arc=none smtp.remote-ip=209.85.216.99 Received: from mail-pj1-f99.google.com (mail-pj1-f99.google.com [209.85.216.99]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DFCB606A31C for ; Wed, 18 Nov 2026 06:02:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 8DFCB606A31C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.a=rsa-sha256 header.s=google header.b=cQgsmFTw Received: by mail-pj1-f99.google.com with SMTP id 98e67ed59e1d1-3b3d4d3bba3so223408a91.3 for ; Tue, 17 Nov 2026 22:02:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794981735; x=1795586535; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=I0NMn6fHPSVKHVHVNpMiE+ggLiJC/6XmQS3TcCioiGQ=; b=2JzygzISBhh8M9vWAq+84WwqgfA3N6NZRZ2aJGX9gC14XCaSsysViybud47qguF22A i7oKkkydHH3zb/80b+naOkBPhM9s4DHbcnrhbLGr+Vpg5W1fNlmVFCcG6buUEApei6Ri DPDDmu+sl+FcRFIl+OgLys9MeTDZ+gh4ax69Lq4KngHqN4eTo0RVpgUZlS3PF6Ai/Vcj 0xoW9fG+HrypSI0lfAd0Rco9MyBx39xlJGk1Wpkoe4oxOwB/PfHomzgNX6s2q26jDuFq iZjNz/p4LOxl6fUX0GehpOVL/xzvu/tZgFtm9mgJC/5RsFj76d2GZMUnMa1O90pF4Njr U+Uw== X-Forwarded-Encrypted: i=1; AL+hErFlhjpRfODh2+Xm72pdqncBih2b+QVle1BYIuRZfVRE9SMDIJ6K9qxBXNpGdJN4o+jt/6FrAylT3D/uuW8=@vger.kernel.org X-Gm-Message-State: APuU4Z+7MOP0OMqHvH3WAj4IkYl0iGaYCW7gS+pdDRK1WtdgryKeGvy7 +EdrmqAh7CeoTVU78IOZomJwrIL2SiGZ8y4exVLHzUSiOdzoRjoIILQoTHTOIihVIG+SD5Vt3vM S7M6bbr8qIjoLfShwBAXIlUWVo+OCNHt6NgseYzk55tTfzq3ZOrrAiu5NYWQ8c4HIjmnKwGo8Sh hOfkQrq90bhLlmR5aPfIJhOe3TvYMk6Us40dQX7jcjXp6t31gJvbgJoxgG+tat+/6yCPHHqZPq4 m7n1E1MLGvB+kF6 X-Gm-Gg: AZFdTZe1vDsOPA6mBpr5ZIlFpIEAF4+FU/wJg89loVu/bJAczBUmIInQbWdvleoxwq8 aG2lpGxrYFCVmvk4wcASuBIMdwjulLbyRPUf2UiM5uxxkhh/tfTPcWfCK8P6/WaoYgRQNeTFJ+1 eQkWAyQnayY4+WzW/GSivAd1zdPjUR+bU1qfxladhpESzqS8Mhr9+voEED9pIIUyBfPXE+51MBh 7+GRqo+SBKlha007icATf6UoCnb/v8ARD01LCuFi92LZjiq2Qds+H7jla+C+SM82sUUkNF1FmeI VvDtumKce3gf0yBqGAdnJJaB/MjIiEatjydz0Jy++Q1qaynUyjK0ef1feqPbTZ1cvvCtgWon4CL zjHy1LNmyTlDWPNbR9MLHpyl8oB2FjRZ1oVS/NIwFSmkfsDJ9bZdJkk/Y/Slevi26QZPGTb//nH 7ronOL6kIwKdJc0icBKZStI/xdlj4BgPM9Tqg= X-Received: by 2002:a17:90b:2fc8:b0:3b3:cb3b:1965 with SMTP id 98e67ed59e1d1-3b3d07a203fmr1600194a91.16.1794981734821; Tue, 17 Nov 2026 22:02:14 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-123.dlp.protect.broadcom.com. [144.49.247.123]) by smtp-relay.gmail.com with ESMTPS id 98e67ed59e1d1-3b3d4bf2056sm480553a91.3.2026.11.17.22.02.14 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Nov 2026 22:02:14 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-536778a8137so10295551cf.2 for ; Tue, 17 Nov 2026 22:02:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1794981733; x=1795586533; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=I0NMn6fHPSVKHVHVNpMiE+ggLiJC/6XmQS3TcCioiGQ=; b=cQgsmFTwM5SB2ZM0Bg/gt1/Q0oTnQ18Dwfo8w6L0b7OeC4IbvhvQeJlNoEYqCcs0AV hW2mmnDo8kWHSfl5URHapNgLKex58j5qyzbnBENcpnmmKMTGUbkTX4Ve1W1tc1hz9PXW 6XmOmGtcYLw/kfUQOzxC9p3ETLsrJHwQBJh28= X-Forwarded-Encrypted: i=1; AL+hErGqVFHKSiCBQgWay3LmKaj17I80Na9YiQhs25ujxOeJ+JbFwEvPKNCakN4XfYLn2xmretpl0/V/JTkUJ7s=@vger.kernel.org X-Received: by 2002:a05:622a:551b:b0:55d:1944:a2b9 with SMTP id d75a77b69052e-55d5a5b7756mr24482211cf.51.1794981733039; Tue, 17 Nov 2026 22:02:13 -0800 (PST) X-Received: by 2002:a05:622a:551b:b0:55d:1944:a2b9 with SMTP id d75a77b69052e-55d5a5b7756mr24481831cf.51.1794981732440; Tue, 17 Nov 2026 22:02:12 -0800 (PST) Received: from vertex.localdomain (pool-173-49-113-140.phlapa.fios.verizon.net. [173.49.113.140]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-55d58ff0065sm14886841cf.5.2026.11.17.22.02.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2026 22:02:10 -0800 (PST) From: Zack Rusin To: Andrew Morton , Petr Mladek , Baoquan He , Mike Rapoport , Pasha Tatashin , Pratyush Yadav , Dave Young Cc: Borislav Petkov , Ajay Kaher , Alexey Makhalov , x86@kernel.org, Joel Granados , Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" , virtualization@lists.linux.dev, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, John Ogness , Steven Rostedt , Sergey Senozhatsky , Kees Cook , Jonathan Corbet , Bo Gan , Brennan Lamoreaux , kexec@lists.infradead.org, linux-doc@vger.kernel.org, "Guilherme G. Piccoli" , Maaz Mombasawala , Shuah Khan , Randy Dunlap , Stephen Brennan , Michael Kelley , Ian Forbes , Bradley Morgan Subject: [PATCH v4 4/4] x86/vmware: Report guest crashes after kmsg dumpers Date: Wed, 18 Nov 2026 01:01:51 -0500 Message-ID: X-Mailer: git-send-email 2.53.0 In-Reply-To: References: X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e VMware accepts a structured guest-crash event, but a host configured with backdoor.coredumpOnCrash may terminate the VM before the hypercall returns. Keep this event separate from the log sender, which runs earlier in panic. Register a panic-only kmsg dumper with late_initcall_sync(), after built-in dumpers registered by then. Skip the event while a crash kernel is loaded so the host cannot terminate the guest before kdump saves its vmcore. Issue the event at most once. With CONFIG_PRINTK=n, use a late INT_MIN panic notifier. An unexpected dumper registration failure with printk enabled leaves reporting disabled rather than overtaking working dumpers. Link: https://lore.kernel.org/r/20260309235250.2611115-4-alexey.makhalov@broadcom.com Co-developed-by: Brennan Lamoreaux Signed-off-by: Brennan Lamoreaux Co-developed-by: Alexey Makhalov Signed-off-by: Alexey Makhalov Signed-off-by: Zack Rusin --- v4: No change. v3: Rebase. No code change from v2. arch/x86/include/asm/vmware.h | 1 + arch/x86/kernel/cpu/vmware.c | 62 +++++++++++++++++++++++++++++++++++ 2 files changed, 63 insertions(+) diff --git a/arch/x86/include/asm/vmware.h b/arch/x86/include/asm/vmware.h index dc3cf8123914..6d3c9922c92b 100644 --- a/arch/x86/include/asm/vmware.h +++ b/arch/x86/include/asm/vmware.h @@ -61,6 +61,7 @@ #define VMWARE_CMD_GETHZ 45 #define VMWARE_CMD_GETVCPU_INFO 68 #define VMWARE_CMD_STEALCLOCK 91 +#define VMWARE_CMD_REPORTGUESTCRASH 102 /* * Hypercall command mask: * bits [6:0] command, range [0, 127] diff --git a/arch/x86/kernel/cpu/vmware.c b/arch/x86/kernel/cpu/vmware.c index 8c8b6dd7c3e8..ead9f50cf89e 100644 --- a/arch/x86/kernel/cpu/vmware.c +++ b/arch/x86/kernel/cpu/vmware.c @@ -22,9 +22,12 @@ */ #include +#include +#include #include #include #include +#include #include #include #include @@ -330,6 +333,65 @@ static int __init vmware_panic_log_init(void) } early_initcall(vmware_panic_log_init); +static atomic_t vmware_crash_reported = ATOMIC_INIT(0); + +static void vmware_report_guest_crash(void) +{ + if (kexec_crash_loaded()) + return; + if (atomic_xchg(&vmware_crash_reported, 1)) + return; + + vmware_hypercall1(VMWARE_CMD_REPORTGUESTCRASH, 0); +} + +static void vmware_crash_report_dump(struct kmsg_dumper *dumper, + struct kmsg_dump_detail *detail) +{ + vmware_report_guest_crash(); +} + +static struct kmsg_dumper vmware_crash_report_dumper = { + .dump = vmware_crash_report_dump, + .max_reason = KMSG_DUMP_PANIC, +}; + +static int vmware_crash_report_notify(struct notifier_block *nb, + unsigned long action, void *data) +{ + vmware_report_guest_crash(); + return NOTIFY_DONE; +} + +static struct notifier_block vmware_crash_report_nb = { + .notifier_call = vmware_crash_report_notify, + .priority = INT_MIN, +}; + +static int __init vmware_crash_report_init(void) +{ + int ret; + + if (!hypervisor_is_type(X86_HYPER_VMWARE)) + return 0; + + ret = kmsg_dump_register(&vmware_crash_report_dumper); + if (!ret) + return 0; + if (IS_ENABLED(CONFIG_PRINTK)) { + pr_err("failed to register crash report dumper: %d\n", ret); + return 0; + } + + ret = atomic_notifier_chain_register(&panic_notifier_list, + &vmware_crash_report_nb); + if (ret) + pr_err("failed to register crash report notifier: %d\n", ret); + + return 0; +} +late_initcall_sync(vmware_crash_report_init); + #ifdef CONFIG_PARAVIRT static struct cyc2ns_data vmware_cyc2ns __ro_after_init; static bool vmw_sched_clock __initdata = true;