From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64E5F3C65F8 for ; Tue, 10 Mar 2026 12:47:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773146874; cv=none; b=Y4hs4rGF05DhWR3c81DDkuyVDYdGDcIX3pTDb4XxH5INQXPDDMTjQXuhiVegOMZqL9C25F205Nl4PGAZuYu0Vtd/onqTf8QUpyBLLRbC7BzoSJeGMxdT/n4EJvI37wzvIS8khI7T/t4oOip86769SH7onqyxHpwdlmzbKW6yO74= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773146874; c=relaxed/simple; bh=7B8FkO17fw/pcE0VMVvPgjua2aMjVXiSPKKVedjwZow=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Z1II0S1BL5jD+QlljlvCheFR5fQrcKHfyYL3fpHh5J2n2LN8SsaWoOFWyypmrRUw8NhzPhqNvDPXPJTMYHxdF2c4Af6WdhUFLRByL+Hj8vDLNgdk4/7f1W7AKQXMi2Sd1V9Z6GqtUA4Qh0MOuTaumJwQKLVTF6BJ/IWa5+2GOMs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Y6Yp1auY; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AimCdGMu; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Y6Yp1auY"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AimCdGMu" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62ACaRoa024059 for ; Tue, 10 Mar 2026 12:47:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Z45dGMHmm6Um7jMOSOtmnPjC6jEC5ymM/dDKxJXitKQ=; b=Y6Yp1auYLKi5kyyO xenxYjtUDKt7Vg5SUHkI/UFqqitdSYxYAYXP3G1u3DyvrgtT0hCd3CAHIbWyLjSN vy4YiJZaB2u20rJQglgzibrE7CIx1sRp8KPO2dWzNhZWlT22czRMqbkPAwbCzvg0 4bu7bAvuxpToOS/gvz/hqy39+0e5gTPVcsQq8OkB/ZQ1Fz+vKb5B2zwKK/8tfw9V 6az+6T6ibEz1fAaPHgt78INHW+3YocCBpHamiA25YTXHpCzqc9rXXGB/oKfSZBdo 8JvHQ3gERZsCcrgwk0bwa3Ujx1rmxmHAhDR3t2v5XGchS/2CGRdy5i9bBUl1EDGd jjoADA== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ctg5ngwcn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 10 Mar 2026 12:47:52 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8cd8198fe16so179897385a.2 for ; Tue, 10 Mar 2026 05:47:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773146872; x=1773751672; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Z45dGMHmm6Um7jMOSOtmnPjC6jEC5ymM/dDKxJXitKQ=; b=AimCdGMumJViPKRATM3ja1Brb7QG84QQOtzJBPqhkV+w0/weLtN8t/FBwDOX50KBnc uR3Ry8LSFqfg21Mk8SdR9++t1jU5VXzz+GaQPslHzRkvPuXOyrpWQOLKXLJEtWNFS24D Im5Z/EvEuOnIi5vp+FTpP+JPGmNsxrcgfWTu20Lz2uXPcmyOIuG+4CrFSeTmOpZT1uVG 5mXdJ3hLJElVIT0IyMwdBvXXZYJrm2z6srxeG96JbAXeomi8ciRpt6atgVjZqwe7dH2R WbAR084ZNJ0QV1jWKtupyH68O6fzzJbhq9psr0ZwuRoaVnK6xB3CTfqOsZ4U61vxQIEP CPog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773146872; x=1773751672; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Z45dGMHmm6Um7jMOSOtmnPjC6jEC5ymM/dDKxJXitKQ=; b=pBWYOTtTS8SI5Z+beQFvPSxq6ufkuWoijm9Pnd2Sssmu9RaqnhgWHJ98RMTERVN3tQ xlSJr9Yj6yRMWYiPM38/8O7xuXg7llS+G4Z8oQ/QK+ikTGy00YxP45wTUdjWhFfpJPEN 4N4inhRutCthLyJqtr1TS4KZd+YehGC75JvCn3UI0N9Dx9q6NavlUAWmfHDcQkcoAdOx cLA1rPUpS9gy97fVGO+8W97D98wpXhq5j97xBRxb822FG5fCHkBLeUE0s8rTGqIK/VeV XRcN6tjYot97+2IAxx1oRmuDweTYjm0HJNXDCF4ASxsRagLB6dEtiJbZxFmvwiQFxmz4 iJag== X-Forwarded-Encrypted: i=1; AJvYcCXo8DusD0SWPRsZBPF5NGwspsiU4pa/C5BgPn9l1mT/2CiAIVI8VHr6aTcMVTjM4DHiBMtOfJ3zslBYiMk=@vger.kernel.org X-Gm-Message-State: AOJu0YyaG3bbfmhwwE1v/OHim2BoKSI+bkhj8A4IEXZCPHGjcl2jecei i/mpBnWG3Pw6qDv2GtJ765ubyUjMSwKfagdZtxK1fXNFqUhOncbwZWrcFmfUXnfUAeG6a/pLers Gdmi+tB0SXbdow2jAY/atUdwdBiunwChlZKnqtfiuF2fknnTmXM2xN0SQYLlsW1vtvUc= X-Gm-Gg: ATEYQzy6o3AWn1u5KcUmj0xVfh0WmIBTKmaKx7EvV/qhCfcp+VT1ltt2HXJeNk6D5J2 zdS4GIiQSORHSyrExRpvaxH45Yv1+xuZNhK1OnCCJidXgodQ0qqPVKJHZxH7OQAwPGiiXKgK1n1 wgeHTl66RUFq0gwaQZlLUrHmCkwjYvskNXwWNNET3wauW9Rqqrb41E2DlQ58RAEURiIuQ0O4u9Y /5LTsObCEKqTvG++0E28RF+YwIiiz8MERYZMs0dbeEOn+c9KzdWN2RJgdR6wAlj8YRE4Xr4HABR Q4c94wqWoPV9RW6o1dMq+nHVjCMuj/U55SopNv8V1tRZATtfobC/j0a0sy6g1XUcg2L+Y2F1L4m SPDulzGU7Jr6uMyV7LDX9B8z8ERlYRRgNjhovLaxNZnqIcw+jvIHAkJB1JFpa/qEBT9QNlwi4ef SlxJM= X-Received: by 2002:a05:620a:4151:b0:8cd:86fa:36a0 with SMTP id af79cd13be357-8cd86fa37b1mr741119785a.1.1773146871698; Tue, 10 Mar 2026 05:47:51 -0700 (PDT) X-Received: by 2002:a05:620a:4151:b0:8cd:86fa:36a0 with SMTP id af79cd13be357-8cd86fa37b1mr741117385a.1.1773146871301; Tue, 10 Mar 2026 05:47:51 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b94dad4271esm405879466b.32.2026.03.10.05.47.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Mar 2026 05:47:50 -0700 (PDT) Message-ID: Date: Tue, 10 Mar 2026 13:47:47 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/24] drm/msm/mdss: correct UBWC programming sequences To: Dmitry Baryshkov , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> <20260306-ubwc-rework-v1-1-9cfdff12f2bb@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260306-ubwc-rework-v1-1-9cfdff12f2bb@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: etXkmDiiJAKT2MG3iJ8JI4eY6xcond5M X-Authority-Analysis: v=2.4 cv=ervSD4pX c=1 sm=1 tr=0 ts=69b012f8 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=vSU7WzfE01f-x17di4gA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-ORIG-GUID: etXkmDiiJAKT2MG3iJ8JI4eY6xcond5M X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEwMDExMiBTYWx0ZWRfXyY9Y4CkGU09k sNT0PVRxN26pgMR74fMaLH7a6vgYdAaYTtKLRuw3lDj/uWw7ejMEQVbcPm7/1BRERrBXTKPv256 f3vLodn3K+naCeqbK18HTy2Uwk1DecCUAIykRFn6EPoilukWwiaoNDYUnhzffSC38Nz6CC5xVfQ C4QgIZ1+5h8Vyi3J1gOPxpCuUq+RZvCuYN3JQ+awLOKEQzVtRMmP3B0fYfs+WJIBSOXUJHfNWGM yqWjOH2o2tTIcHih+Y3FUL4JH32f6bVhlN2h6W84v8Ag/lnb1XVzv3Gr7TQYahmVxrDneqBfHkz E3svViQ6Xh7flNrPhR43XD6l+rPjr4/va1wliBCQbtnYNlOKAoHCoroLQDiAGxdlaUCeDGYhSu+ 0AexZbkQHERg4sZqz0gMBHMPRS8hfddacBKmKseYiJQ6xuae0zncSoFsSgf3v2ASfdo6MFNaMyw R4MNjjKi2zvPDe7twMg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-10_02,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 phishscore=0 adultscore=0 priorityscore=1501 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603100112 On 3/6/26 5:47 PM, Dmitry Baryshkov wrote: > The UBWC registers in the MDSS region are not dependent on the UBWC > version (it is an invalid assumption we inherited from the vendor SDE > driver). Instead they are dependent only on the MDSS core revision. > > Rework UBWC programming to follow MDSS revision and to use required (aka > encoder) UBWC version instead of the ubwc_dec_version. > > Fixes: d68db6069a8e ("drm/msm/mdss: convert UBWC setup to use match data") > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/msm_mdss.c | 120 ++++++++++++++++------------------------- > 1 file changed, 45 insertions(+), 75 deletions(-) > > diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c > index 9047e8d9ee89..9f81f43283b9 100644 > --- a/drivers/gpu/drm/msm/msm_mdss.c > +++ b/drivers/gpu/drm/msm/msm_mdss.c > @@ -166,27 +166,27 @@ static int _msm_mdss_irq_domain_add(struct msm_mdss *msm_mdss) > return 0; > } > > -static void msm_mdss_setup_ubwc_dec_20(struct msm_mdss *msm_mdss) > +static void msm_mdss_setup_ubwc_v4(struct msm_mdss *msm_mdss) > { > const struct qcom_ubwc_cfg_data *data = msm_mdss->mdss_data; > - u32 value = MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle) | > + u32 value = MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle & 0x1) | The field takes bit0/1/2 for *enabling* level 1/2/3 swizzling - is this intended? [...] > +static void msm_mdss_setup_ubwc_v5(struct msm_mdss *msm_mdss) > { > const struct qcom_ubwc_cfg_data *data = msm_mdss->mdss_data; > - u32 value = MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle & 0x1) | > + u32 value = MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle) | > MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit - 13); > > + if (data->ubwc_bank_spread) > + value |= MDSS_UBWC_STATIC_UBWC_BANK_SPREAD; 8250 is ubwcv4 (in our catalog anyway) and definitely has a bit for this Konrad