From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Ruoyu Wang <ruoyuw560@gmail.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bus: qcom-ebi2: Fix clock leak on probe failure
Date: Mon, 22 Jun 2026 11:15:23 +0200 [thread overview]
Message-ID: <d104d52e-97a3-479b-8dfd-ddf41a3d05e4@oss.qualcomm.com> (raw)
In-Reply-To: <20260620080406.1970447-1-ruoyuw560@gmail.com>
On 6/20/26 10:04 AM, Ruoyu Wang wrote:
> qcom_ebi2_probe() enables the EBI2X and EBI2 clocks before it walks
> child nodes and populates child devices. If reading a child node's reg
> property fails, or if of_platform_default_populate() fails, probe returns
> without disabling either clock.
>
> Route those failure paths through the existing clock cleanup labels so a
> failed probe does not leave the clocks prepared and enabled.
>
> Fixes: 335a12754808 ("bus: qcom: add EBI2 driver")
> Signed-off-by: Ruoyu Wang <ruoyuw560@gmail.com>
> ---
> This is a minimal error-path fix for a previously reported leak. A broader
> devm_clk_get_enabled() conversion was posted in 2023 and reviewed, and a
> similar cleanup was posted in 2024, but neither appears in current upstream:
> https://lkml.iu.edu/hypermail/linux/kernel/2305.1/00605.html
> https://lkml.iu.edu/2408.2/09536.html
Someone raised an identical patch last week
https://lore.kernel.org/linux-arm-msm/d1882207-4756-4e65-ba30-b47ccc821fd4@oss.qualcomm.com/
Konrad
next prev parent reply other threads:[~2026-06-22 9:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-20 8:04 Ruoyu Wang
2026-06-22 9:15 ` Konrad Dybcio [this message]
2026-06-22 12:40 ` Linus Walleij
2026-07-08 14:56 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d104d52e-97a3-479b-8dfd-ddf41a3d05e4@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=konradybcio@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ruoyuw560@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®