mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Alan Stern <stern@rowland.harvard.edu>,
	Bjorn Helgaas <helgaas@kernel.org>
Cc: Jesse Hathaway <jesse@mbuki-mvuki.org>,
	Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
	Mathias Nyman <mathias.nyman@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org
Subject: Re: Regression causes a hang on boot with a Comtrol PCI card
Date: Tue, 2 Apr 2019 17:49:08 +0300	[thread overview]
Message-ID: <d1070139-5b14-f42a-938f-2fe51779642b@linux.intel.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1904021028110.1562-100000@iolanthe.rowland.org>

On 2.4.2019 17.29, Alan Stern wrote:
> On Mon, 1 Apr 2019, Bjorn Helgaas wrote:
> 
>> [+cc Mathias, Greg, Alan, linux-usb]
>>
>> Beginning of thread: https://lore.kernel.org/linux-pci/CANSNSoWiKd98Dt1N2sSjP9Af8zk1NPV-=3P4VLtFs_cSQG4RUg@mail.gmail.com
>>
>> Synopsis: v5.0 hangs at boot unless the following commits are reverted:
>>
>>    1302fcf0d03e ("PCI: Configure *all* devices, not just hot-added ones")
>>    1c3c5eab1715 ("sched/core: Enable might_sleep() and smp_processor_id() checks early")
>>
>> The hang appears to be in quirk_usb_early_handoff().  With
>> "initcall_debug", we see the call but not the completion:
>>
>> On Fri, Mar 22, 2019 at 03:02:11PM -0500, Jesse Hathaway wrote:
>>>> So apparently the hang happens while we're running the "final" PCI
>>>> fixups.  This happens after all the rest of PCI is initialized.
>>>>
>>>> Can you boot v5.0 vanilla with "initcall_debug"?  Maybe we can narrow
>>>> it down to a specific quirk.
>>>
>>> yup, added the "initcall_debug" output to the ticket:
>>> https://bugzilla.kernel.org/show_bug.cgi?id=202927, here is the tail end
>>>
>>> [   14.896337] NET: Registered protocol family 1
>>> [   14.901314] initcall af_unix_init+0x0/0x4e returned 0 after 4866 usecs
>>> [   14.908694] calling  ipv6_offload_init+0x0/0x7f @ 1
>>> [   14.914238] initcall ipv6_offload_init+0x0/0x7f returned 0 after 1 usecs
>>> [   14.921821] calling  vlan_offload_init+0x0/0x20 @ 1
>>> [   14.927365] initcall vlan_offload_init+0x0/0x20 returned 0 after 0 usecs
>>> [   14.934948] calling  pci_apply_final_quirks+0x0/0x126 @ 1
>>> [   14.941106] pci 0000:00:1a.0: calling  quirk_usb_early_handoff+0x0/0x6a0 @ 1
>>>
>>> thanks, Jesse Hathaway
> 
> Most likely the problem occurs somewhere inside
> quirk_usb_handoff_xhci().  Can Jesse add debugging statements to that
> routine in order to pin down exactly where the problem lies?
> 
> Alan Stern
> 

lspci log from bugzilla shows 0000:00:1a.0 is a EHCI device,
so probably woth adding debugging to quirk_usb_disable_ehci() as well

00:1a.0 USB controller: Intel Corporation C610/X99 series chipset USB Enhanced Host Controller #2 (rev 05) (prog-if 20 [EHCI])

-Mathias

  reply	other threads:[~2019-04-02 14:46 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-13 16:50 Jesse Hathaway
2019-03-13 23:21 ` Bjorn Helgaas
2019-03-14 20:57   ` Jesse Hathaway
2019-03-21 23:23     ` Bjorn Helgaas
2019-03-22 20:02       ` Jesse Hathaway
2019-04-01 19:43         ` Jesse Hathaway
2019-04-01 21:13         ` Bjorn Helgaas
2019-04-02 14:29           ` Alan Stern
2019-04-02 14:49             ` Mathias Nyman [this message]
2019-04-02 18:26               ` Alan Stern
2019-04-04 15:41             ` Jesse Hathaway
2019-04-04 17:16               ` Alan Stern
2019-04-04 17:36                 ` Jesse Hathaway
2019-04-04 19:14                   ` Alan Stern
2019-04-05 21:27                     ` Jesse Hathaway
2019-04-06 15:32                       ` Alan Stern
2019-04-15 21:47                         ` Jesse Hathaway
2019-04-16 15:00                           ` Alan Stern
2019-04-23 20:18                             ` Jesse Hathaway
2019-04-24 14:20                               ` Alan Stern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d1070139-5b14-f42a-938f-2fe51779642b@linux.intel.com \
    --to=mathias.nyman@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=helgaas@kernel.org \
    --cc=jesse@mbuki-mvuki.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®