From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 619DEC28CF6 for ; Fri, 3 Aug 2018 13:06:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 06C5121763 for ; Fri, 3 Aug 2018 13:06:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 06C5121763 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732115AbeHCPCi (ORCPT ); Fri, 3 Aug 2018 11:02:38 -0400 Received: from mga06.intel.com ([134.134.136.31]:65470 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729963AbeHCPCh (ORCPT ); Fri, 3 Aug 2018 11:02:37 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Aug 2018 06:06:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,438,1526367600"; d="scan'208";a="77066685" Received: from ahunter-desktop.fi.intel.com (HELO [10.237.72.153]) ([10.237.72.153]) by fmsmga004.fm.intel.com with ESMTP; 03 Aug 2018 06:06:19 -0700 Subject: Re: [PATCH V8 2/5] mmc: sdhci: Change O2 Host HS200 mode clock frequency to 200MHz To: "Ernest Zhang(WH)" , Ulf Hansson , "linux-mmc@vger.kernel.org" , "linux-kernel@vger.kernel.org" Cc: "Chuanjin Pang (WH)" , "Mike Li (WH)" , "Chevron Li (WH)" , "Shirley Her (SC)" , "Xiaoguang Yu (WH)" , "Bobby Wu (WH)" References: From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: Date: Fri, 3 Aug 2018 16:04:38 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/07/18 19:23, Ernest Zhang(WH) wrote: > O2 SD Host HS200 mode clock frequency current is 208MHz, should be changed to 200MHz to meet specification. > > Signed-off-by: ernest.zhang Acked-by: Adrian Hunter > --- > Change in V8: > The set base clock code comment has been changed in accordance with > code change in V7. > > Change in V7: > Change HS200 mode clock frequency from 208MHz to 200MHz to meet > Specification. > > Change in V1~V6: > N/A > --- > drivers/mmc/host/sdhci-pci-o2micro.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-pci-o2micro.c b/drivers/mmc/host/sdhci-pci-o2micro.c > index ba59db6a126c..9e7bacda4717 100644 > --- a/drivers/mmc/host/sdhci-pci-o2micro.c > +++ b/drivers/mmc/host/sdhci-pci-o2micro.c > @@ -311,9 +311,9 @@ int sdhci_pci_o2_probe(struct sdhci_pci_chip *chip) > > /* Check Whether subId is 0x11 or 0x12 */ > if ((scratch_32 == 0x11) || (scratch_32 == 0x12)) { > - scratch_32 = 0x2c280000; > + scratch_32 = 0x25100000; > > - /* Set Base Clock to 208MZ */ > + /* Set Base Clock to 200MZ */ MZ -> MHz > o2_pci_set_baseclk(chip, scratch_32); > ret = pci_read_config_dword(chip->pdev, > O2_SD_FUNC_REG4, > @@ -406,7 +406,7 @@ int sdhci_pci_o2_probe(struct sdhci_pci_chip *chip) > O2_SD_PLL_SETTING, scratch_32); > } else { > scratch_32 &= 0x0000FFFF; > - scratch_32 |= 0x2c280000; > + scratch_32 |= 0x25100000; > > pci_write_config_dword(chip->pdev, > O2_SD_PLL_SETTING, scratch_32); > -- > 2.17.1 > > > -----邮件原件----- > 发件人: Adrian Hunter > 发送时间: Friday, July 27, 2018 2:58 PM > 收件人: Ernest Zhang(WH) ; Ulf Hansson ; linux-mmc@vger.kernel.org; linux-kernel@vger.kernel.org > 抄送: Chuanjin Pang (WH) ; Mike Li (WH) ; Chevron Li (WH) ; Shirley Her (SC) ; Xiaoguang Yu (WH) ; Bobby Wu (WH) > 主题: Re: [PATCH V7 2/5] mmc: sdhci: Change O2 Host HS200 mode clock frequency to 200MHz > > On 27/07/18 09:49, Ernest Zhang(WH) wrote: >> Hi Adrian, >> Do I need re-submit all 5 patches after fix that and change the version to v8? > > You can reply to this email with PATCH V8 2/5 that has my Ack and the comment fixed. > >> BR >> >> -----Original Message----- >> From: Adrian Hunter [mailto:adrian.hunter@intel.com] >> Sent: 2018年7月25日 15:45 >> To: Ernest Zhang(WH); Ulf Hansson; linux-mmc@vger.kernel.org; >> linux-kernel@vger.kernel.org >> Cc: Chuanjin Pang (WH); Mike Li (WH); Chevron Li (WH); Shirley Her >> (SC); Xiaoguang Yu (WH); Bobby Wu (WH) >> Subject: Re: [PATCH V7 2/5] mmc: sdhci: Change O2 Host HS200 mode >> clock frequency to 200MHz >> >> On 16/07/18 09:26, ernest.zhang wrote: >>> O2 SD Host HS200 mode clock frequency current is 208MHz, should be >>> changed to 200MHz to meet specification. >>> >>> Signed-off-by: ernest.zhang >> >> You left in the misleading comment. Fix that and add: >> >> Acked-by: Adrian Hunter >> >>> --- >>> Change in V7: >>> Change HS200 mode clock frequency from 208MHz to 200MHz to meet >>> Specification. >>> >>> Change in V1~V6: >>> N/A >>> --- >>> drivers/mmc/host/sdhci-pci-o2micro.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/mmc/host/sdhci-pci-o2micro.c >>> b/drivers/mmc/host/sdhci-pci-o2micro.c >>> index ba59db6a126c..94cf3cd75dd3 100644 >>> --- a/drivers/mmc/host/sdhci-pci-o2micro.c >>> +++ b/drivers/mmc/host/sdhci-pci-o2micro.c >>> @@ -311,7 +311,7 @@ int sdhci_pci_o2_probe(struct sdhci_pci_chip >>> *chip) >>> >>> /* Check Whether subId is 0x11 or 0x12 */ >>> if ((scratch_32 == 0x11) || (scratch_32 == 0x12)) { >>> - scratch_32 = 0x2c280000; >>> + scratch_32 = 0x25100000; >>> >>> /* Set Base Clock to 208MZ */ >> >> That comment is misleading now. >> >>> o2_pci_set_baseclk(chip, scratch_32); @@ -406,7 +406,7 @@ int >>> sdhci_pci_o2_probe(struct sdhci_pci_chip *chip) >>> O2_SD_PLL_SETTING, scratch_32); >>> } else { >>> scratch_32 &= 0x0000FFFF; >>> - scratch_32 |= 0x2c280000; >>> + scratch_32 |= 0x25100000; >>> >>> pci_write_config_dword(chip->pdev, >>> O2_SD_PLL_SETTING, scratch_32); >>> >> >