mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jon Hunter <jonathanh@nvidia.com>
To: webgeek1234@gmail.com, Mark Brown <broonie@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Thierry Reding <thierry.reding@kernel.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
	linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
	linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] arm64: tegra: Add iommu and dma properties for Tegra194 QSPI
Date: Tue, 19 May 2026 15:43:57 +0100	[thread overview]
Message-ID: <d10a46b8-2a01-45d8-b1a4-7d003fdb25bd@nvidia.com> (raw)
In-Reply-To: <20260515-tegra194-qspi-iommu-v1-0-57dfb63cd3d6@gmail.com>


On 15/05/2026 21:35, Aaron Kling via B4 Relay wrote:
> The reason for this is to properly support the spi nor chip on the
> Jetson Xavier NX module. Prior to this, it would time out on all
> transfers and sometimes even trigger a cbb fault, locking up the entire
> unit. With this, reading and writing to the flash memory works as
> expected.

What kernel's do you see this on? With the latest mainline/-next I do 
see ...

  tegra-qspi 3270000.spi: cannot use DMA: -19
  tegra-qspi 3270000.spi: falling back to PIO

But I don't see the crash. However, on linux-6.1.y I do see the crash ...

  tegra-qspi 3270000.spi: cannot use DMA: -19
  tegra-qspi 3270000.spi: falling back to PIO
  tegra-qspi 3270000.spi: transfer timeout
  tegra-qspi 3270000.spi: error in transfer, fifo status 0x20400006
  CPU:0, Error: cbb-noc@2300000, irq=15

So I believe recent upstream changes in the Tegra210 QSPI driver have 
fixed this.

This series does fix the issue on linux-6.1.y but I believe that is 
because this is really enabling DMA support and so PIO is still broken. 
Ideally, PIO should work if DMA support is missing in device-tree.

IMO this series simply enables DMA support. May be we should clarify 
this in the commit message, but otherwise, I am fine with these changes.

Jon

-- 
nvpublic


  parent reply	other threads:[~2026-05-19 14:44 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-15 20:35 Aaron Kling via B4 Relay
2026-05-15 20:35 ` [PATCH 1/3] spi: dt-bindings: tegra: Support IOMMU property " Aaron Kling via B4 Relay
2026-05-16 10:13   ` Krzysztof Kozlowski
2026-05-20 11:34   ` Thierry Reding
2026-05-15 20:35 ` [PATCH 2/3] spi: dt-bindings: tegra: Support dma-coherent property for QSPI Aaron Kling via B4 Relay
2026-05-16 10:13   ` Krzysztof Kozlowski
2026-05-20 11:46   ` Thierry Reding
2026-05-15 20:35 ` [PATCH 3/3] arm64: tegra: Add iommu and dma properties for Tegra194 QSPI Aaron Kling via B4 Relay
2026-05-20 11:49   ` Thierry Reding
2026-05-20 17:29     ` Aaron Kling
2026-05-21  7:49       ` Thierry Reding
2026-05-19 14:43 ` Jon Hunter [this message]
2026-05-19 15:50   ` [PATCH 0/3] " Jon Hunter
2026-05-19 16:48     ` Aaron Kling
2026-05-19 18:36       ` Jon Hunter
2026-05-19 19:34       ` Jon Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d10a46b8-2a01-45d8-b1a4-7d003fdb25bd@nvidia.com \
    --to=jonathanh@nvidia.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=thierry.reding@kernel.org \
    --cc=webgeek1234@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®