From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jie Luo <quic_luoj@quicinc.com>,
agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, mturquette@baylibre.com,
sboyd@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
p.zabel@pengutronix.de
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
quic_srichara@quicinc.com
Subject: Re: [PATCH 2/3] dt-bindings: clock: add qca8386/qca8084 clock and reset definitions
Date: Tue, 8 Aug 2023 07:57:19 +0200 [thread overview]
Message-ID: <d1172ed6-ee3b-83b6-1656-c91e35fbc2df@linaro.org> (raw)
In-Reply-To: <cf9788f0-a115-5ff9-1195-f4f302551e04@quicinc.com>
On 08/08/2023 07:19, Jie Luo wrote:
>>> +properties:
>>> + compatible:
>>> + const: qcom,nsscc-qca8k
>>
>> SoC name is before IP block names. See:
>> Documentation/devicetree/bindings/arm/qcom-soc.yaml
>>
>> qca8k is not SoC specific. I don't know what you are documenting here,
>> but if this is a SoC, then follow SoC rules.
>>
>> If this is not SoC, it confuses me a bit to use GCC binding.
>>
>> Anyway, this was not tested, as pointed out by bot... Please test the
>> code before sending.
>>
>> Best regards,
>> Krzysztof
>>
>
> Hi Krzysztof,
>
> Thanks for the review comments.
> qca8383/qca8084 is a network chip that support switch mode and PHY mode,
> the hardware register is accessed by MDIO bus, which is not a SOC.
>
> But it has the self-contained clock controller system, the clock
> framework of qca8386/qca8084 is same as the GCC of ipq platform such as
> ipq9574.
OK
>
> would you help advise whether we can document it with the compatible
> "qcom,qca8k-nsscc"?
For example:
qcom,qca8084-nsscc
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-08-08 18:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 8:53 [PATCH 0/3] add clock controller of qca8386/qca8084 Luo Jie
2023-08-01 8:53 ` [PATCH 1/3] clk: Add the flag CLK_ENABLE_MUTEX_LOCK of enabling clock Luo Jie
2023-08-01 19:18 ` Stephen Boyd
2023-08-02 10:33 ` Jie Luo
2023-08-01 8:53 ` [PATCH 2/3] dt-bindings: clock: add qca8386/qca8084 clock and reset definitions Luo Jie
2023-08-01 9:36 ` Rob Herring
2023-08-07 6:52 ` Krzysztof Kozlowski
2023-08-08 5:19 ` Jie Luo
2023-08-08 5:57 ` Krzysztof Kozlowski [this message]
2023-08-08 6:31 ` Jie Luo
2023-08-08 6:46 ` Krzysztof Kozlowski
2023-08-08 6:59 ` Jie Luo
2023-08-01 8:53 ` [PATCH 3/3] clk: qcom: add clock controller driver for qca8386/qca8084 Luo Jie
2023-08-01 19:16 ` Randy Dunlap
2023-08-02 10:34 ` Jie Luo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1172ed6-ee3b-83b6-1656-c91e35fbc2df@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=quic_luoj@quicinc.com \
--cc=quic_srichara@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®