From: Bart Van Assche <bvanassche@acm.org>
To: Zhong Jinghua <zhongjinghua@huaweicloud.com>,
jejb@linux.ibm.com, martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
zhongjinghua@huaweicloude.com, yi.zhang@huawei.com,
yukuai3@huawei.com
Subject: Re: [PATCH-next v2 Resend] scsi: fix use-after-free problem in scsi_remove_target
Date: Tue, 7 Mar 2023 14:35:09 -0800 [thread overview]
Message-ID: <d119fcba-a323-d0cd-0d36-759ad2fb8252@acm.org> (raw)
In-Reply-To: <20230306121636.3183761-1-zhongjinghua@huaweicloud.com>
On 3/6/23 04:16, Zhong Jinghua wrote:
> + /*
> + * If the reference count is already zero, skip this
> + * target is safe because scsi_target_destroy()
> + * will wait until the host lock has been released
> + * before freeing starget.
> + */
The above comment has grammatical issues and is confusing. I think the
comment that I suggested was much better than the above.
Bart.
next prev parent reply other threads:[~2023-03-07 22:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 12:16 Zhong Jinghua
2023-03-07 22:35 ` Bart Van Assche [this message]
2023-03-08 1:15 ` zhongjinghua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d119fcba-a323-d0cd-0d36-759ad2fb8252@acm.org \
--to=bvanassche@acm.org \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
--cc=zhongjinghua@huaweicloud.com \
--cc=zhongjinghua@huaweicloude.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®