mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Helge Deller <deller@gmx.de>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org,
	Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] video: fbdev: arkfb: Remove the unused function dac_read_reg()
Date: Sun, 25 Sep 2022 13:09:55 +0200	[thread overview]
Message-ID: <d11a981a-1974-3092-5c81-e1f8c998c440@gmx.de> (raw)
In-Reply-To: <20220914102301.87981-3-jiapeng.chong@linux.alibaba.com>

On 9/14/22 12:23, Jiapeng Chong wrote:
> The function dac_read_reg() is defined in the arkfb.c file, but not
> called elsewhere, so delete this unused function.
>
> drivers/video/fbdev/arkfb.c:322:18: warning: unused function 'dac_read_reg'.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2155
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

applied.

Thanks,
Helge

> ---
>   drivers/video/fbdev/arkfb.c | 8 --------
>   1 file changed, 8 deletions(-)
>
> diff --git a/drivers/video/fbdev/arkfb.c b/drivers/video/fbdev/arkfb.c
> index a317d9fe1d67..5f8fec9e5fd4 100644
> --- a/drivers/video/fbdev/arkfb.c
> +++ b/drivers/video/fbdev/arkfb.c
> @@ -318,14 +318,6 @@ struct dac_info
>   	void *data;
>   };
>
> -
> -static inline u8 dac_read_reg(struct dac_info *info, u8 reg)
> -{
> -	u8 code[2] = {reg, 0};
> -	info->dac_read_regs(info->data, code, 1);
> -	return code[1];
> -}
> -
>   static inline void dac_read_regs(struct dac_info *info, u8 *code, int count)
>   {
>   	info->dac_read_regs(info->data, code, count);


  reply	other threads:[~2022-09-25 11:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-14 10:22 [PATCH] video: fbdev: controlfb: Remove the unused function VAR_MATCH() Jiapeng Chong
2022-09-14 10:23 ` [PATCH] video: fbdev: tridentfb: Remove the unused function shadowmode_off() Jiapeng Chong
2022-09-25 11:10   ` Helge Deller
2022-09-14 10:23 ` [PATCH] video: fbdev: arkfb: Remove the unused function dac_read_reg() Jiapeng Chong
2022-09-25 11:09   ` Helge Deller [this message]
2022-09-25 11:11 ` [PATCH] video: fbdev: controlfb: Remove the unused function VAR_MATCH() Helge Deller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d11a981a-1974-3092-5c81-e1f8c998c440@gmx.de \
    --to=deller@gmx.de \
    --cc=abaci@linux.alibaba.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jiapeng.chong@linux.alibaba.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®