mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Antoni Pokusinski <apokusinski01@gmail.com>,
	jdelvare@suse.com, corbet@lwn.net
Cc: linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: (sht3x) add support for SHT85
Date: Tue, 9 Dec 2025 19:09:55 -0800	[thread overview]
Message-ID: <d11e3cf6-3095-46df-a4f2-442d209675b1@roeck-us.net> (raw)
In-Reply-To: <2683b84f-d7d1-4445-b5d3-bed393de34a0@roeck-us.net>

On 12/9/25 13:19, Guenter Roeck wrote:
> On 12/9/25 09:58, Antoni Pokusinski wrote:
>> SHT85 is a temperature and humidity sensor with an interface very
>> similar to SHT3x. However, it does not feature alerts (and therefore
>> limits).
>>
> 
> The datasheet does suggest that the chip supports both temperature and
> humidity tracking alert status, which only makes sense if the chip
> supports alert limits. It does not support an alert _pin_, but that
> doesn't mean that it does not support limits. I'll want to see definite
> confirmation that the chip does not support the limit commands.
> 

Looking closer into the SHT85 datasheet, the sensor chip is actually a SHT35.
Given that, disabling limit attributes and alarms is neither necessary
nor acceptable. It isn't even necessary to add "sht85" to the device ID
table; sht3x works just fine. I don't mind if it is added, but it does
not need a new chip ID (at least until/unless interrupt support is added
to the driver).

Thanks,
Guenter


  reply	other threads:[~2025-12-10  3:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-09 17:58 Antoni Pokusinski
2025-12-09 21:19 ` Guenter Roeck
2025-12-10  3:09   ` Guenter Roeck [this message]
2025-12-10 21:44     ` Antoni Pokusinski
2025-12-10 21:56       ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d11e3cf6-3095-46df-a4f2-442d209675b1@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=apokusinski01@gmail.com \
    --cc=corbet@lwn.net \
    --cc=jdelvare@suse.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®