From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0DBDC433F5 for ; Wed, 16 Feb 2022 15:35:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235530AbiBPPf7 (ORCPT ); Wed, 16 Feb 2022 10:35:59 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:56380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233792AbiBPPf4 (ORCPT ); Wed, 16 Feb 2022 10:35:56 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 85B9A2838E3; Wed, 16 Feb 2022 07:35:44 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1E25FD6E; Wed, 16 Feb 2022 07:35:44 -0800 (PST) Received: from [10.57.13.141] (unknown [10.57.13.141]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CDF8F3F70D; Wed, 16 Feb 2022 07:35:41 -0800 (PST) Subject: Re: [PATCH 1/2] thermal: cooling: Check Energy Model type in cpufreq_cooling and devfreq_cooling To: Matthias Kaehlcke Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, amit.kachhap@gmail.com, daniel.lezcano@linaro.org, viresh.kumar@linaro.org, rafael@kernel.org, amitk@kernel.org, rui.zhang@intel.com, dietmar.eggemann@arm.com, Pierre.Gondois@arm.com, Douglas Anderson , Stephen Boyd , Rajendra Nayak , Bjorn Andersson References: <20220207073036.14901-1-lukasz.luba@arm.com> <20220207073036.14901-2-lukasz.luba@arm.com> <4a7d4e94-1461-5bac-5798-29998af9793a@arm.com> From: Lukasz Luba Message-ID: Date: Wed, 16 Feb 2022 15:35:40 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Matthias, On 2/9/22 10:17 PM, Matthias Kaehlcke wrote: > On Wed, Feb 09, 2022 at 11:16:36AM +0000, Lukasz Luba wrote: >> >> >> On 2/8/22 5:25 PM, Matthias Kaehlcke wrote: >>> On Tue, Feb 08, 2022 at 09:32:28AM +0000, Lukasz Luba wrote: >>>> >>>> [snip] >>>> Could you point me to those devices please? >>> >>> arch/arm64/boot/dts/qcom/sc7180-trogdor-* >>> >>> Though as per above they shouldn't be impacted by your change, since the >>> CPUs always pretend to use milli-Watts. >>> >>> [skipped some questions/answers since sc7180 isn't actually impacted by >>> the change] >> >> Thank you Matthias. I will investigate your setup to get better >> understanding. > > Thanks! > I've checked those DT files and related code. As you already said, this patch is safe for them. So we can apply it IMO. -------------Off-topic------------------ Not in $subject comments: AFAICS based on two files which define thermal zones: sc7180-trogdor-homestar.dtsi sc7180-trogdor-coachz.dtsi only the 'big' cores are used as cooling devices in the 'skin_temp_thermal' - the CPU6 and CPU7. I assume you don't want to model at all the power usage from the Little cluster (which is quite big: 6 CPUs), do you? I can see that the Little CPUs have small dyn-power-coeff ~30% of the big and lower max freq, but still might be worth to add them to IPA. You might give them more 'weight', to make sure they receive more power during power split. You also don't have GPU cooling device in that thermal zone. Based on my experience if your GPU is a power hungry one, e.g. 2-4Watts, you might get better results when you model this 'hot' device (which impacts your temp sensor reported value). Regards, Lukasz