From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Arjan van de Ven <arjan@infradead.org>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [patch 2/4] fix input layer f_ops abuse
Date: Fri, 6 Jan 2006 18:12:08 -0500 [thread overview]
Message-ID: <d120d5000601061512s1b282ee5o259ec3d6e9a730c2@mail.gmail.com> (raw)
In-Reply-To: <1136584073.2940.95.camel@laptopd505.fenrus.org>
On 1/6/06, Arjan van de Ven <arjan@infradead.org> wrote:
> From: Arjan van de Ven <arjan@infradead.org>
>
> The input layer has an assignment to a live ->fops, just after creating the
> fops as a duplicate of another one. Just move this assignment a few lines up to avoid
> the race and the assignment to a live fops
>
I do not understand how it will fix the "race", there is still a split
second between "entry" having default fops and modified one. I'd
prefer you fix the comment to reflect that the only change is because
fops is now constant.
--
Dmitry
next prev parent reply other threads:[~2006-01-06 23:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-06 21:45 [patch 0/4] Series to allow a "const" file_operations struct Arjan van de Ven
2006-01-06 21:46 ` [patch 1/4] fix some f_ops abuse in acpi Arjan van de Ven
2006-01-06 21:47 ` [patch 2/4] fix input layer f_ops abuse Arjan van de Ven
2006-01-06 23:12 ` Dmitry Torokhov [this message]
2006-01-06 21:49 ` [patch 3/4] fix cifs bugs wrt writing to f_ops Arjan van de Ven
2006-01-06 21:51 ` [patch 4/4] Actually make the f_ops field const Arjan van de Ven
2006-01-07 8:00 ` Andrew Morton
2006-01-07 8:13 ` Arjan van de Ven
2006-01-06 21:55 ` [patch 0/4] Series to allow a "const" file_operations struct Arjan van de Ven
2006-01-06 22:46 ` Eric Dumazet
2006-01-07 0:29 ` Andrew Morton
2006-01-07 1:01 ` Arnd Bergmann
2006-01-07 7:40 ` Eric Dumazet
2006-01-07 8:33 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d120d5000601061512s1b282ee5o259ec3d6e9a730c2@mail.gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=dtor_core@ameritech.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®