From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932219AbWDUM4u (ORCPT ); Fri, 21 Apr 2006 08:56:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932292AbWDUM4u (ORCPT ); Fri, 21 Apr 2006 08:56:50 -0400 Received: from nz-out-0102.google.com ([64.233.162.196]:7125 "EHLO nz-out-0102.google.com") by vger.kernel.org with ESMTP id S932206AbWDUM4s convert rfc822-to-8bit (ORCPT ); Fri, 21 Apr 2006 08:56:48 -0400 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=WQvNqAwUmWwF481vXWESjR6B4T1LNdwq4Y79siotA50b4ZTM473FpY2KPF+aCeJ3pQ4EpN6mNSmn8bKTkMOstoJXeVKKHCUmA6Z8JgfAKqNl10VrZ/gP9/9ti1g55IgEYE0nBta12RRb4utLGTNi9RSfZTFADvAFRhEWRBB+yo0= Message-ID: Date: Fri, 21 Apr 2006 08:56:48 -0400 From: "Dmitry Torokhov" Reply-To: dtor_core@ameritech.net To: "Alexey Starikovskiy" Subject: Re: [RFC] [PATCH] Make ACPI button driver an input device Cc: "Xavier Bestel" , "Matthew Garrett" , "Yu, Luming" , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <44489D58.3090209@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Content-Disposition: inline References: <554C5F4C5BA7384EB2B412FD46A3BAD1332980@pdsmsx411.ccr.corp.intel.com> <20060420073713.GA25735@srcf.ucam.org> <4447AA59.8010300@linux.intel.com> <20060420153848.GA29726@srcf.ucam.org> <4447AF4D.7030507@linux.intel.com> <1145549460.23837.156.camel@capoeira> <4447B7D6.4030401@linux.intel.com> <1145563624.14595.5.camel@bip.parateam.prv> <44489D58.3090209@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On 4/21/06, Alexey Starikovskiy wrote: > Xavier Bestel wrote: > > Le jeudi 20 avril 2006 à 15:30 -0400, Dmitry Torokhov a écrit : > >> On 4/20/06, Alexey Starikovskiy wrote: > >>> Xavier Bestel wrote: > >>>> There are keyboards with power/sleep buttons. It makes sense they have > >>>> the same behavior than ACPI buttons. > >>> Agree, make them behave like ACPI buttons -- remove them from input stream, as they do not belong there... > >> What if there is no ACPI? What if I want to remap the button to do > >> something else? Input layer is the proper place for them. > > > > Err .. that's what I meant, sorry I was not clear. Matthew's solution > > looks right. > If there is no ACPI, you don't have ACPI buttons to remap. Remapping power/lid/sleep button is not wise at least, just because you boot once with acpi=off and get unclean shutdown instead of your intended remapped keystroke. > I can see that with power button but lid/sleep should be fine really. And even with power button - "doctor it hurts..." -- Dmitry