From: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>
To: "Jesper Juhl" <jesper.juhl@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH 9/9] -Wshadow: fixes for drivers/char/keyboard.c
Date: Mon, 10 Jul 2006 09:07:30 -0400 [thread overview]
Message-ID: <d120d5000607100607i47980d08w60a85be9aeca348@mail.gmail.com> (raw)
In-Reply-To: <200607101313.42962.jesper.juhl@gmail.com>
On 7/10/06, Jesper Juhl <jesper.juhl@gmail.com> wrote:
>
> -static void kbd_keycode(unsigned int keycode, int down,
> +static void kbd_keycode(unsigned int keycode, int _down,
> int hw_raw, struct pt_regs *regs)
> {
I dont like the "_down" name, feels artificial. If you don't mind I'll
change it to "key_down" before applying.
--
Dmitry
next prev parent reply other threads:[~2006-07-10 13:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-10 11:13 Jesper Juhl
2006-07-10 13:07 ` Dmitry Torokhov [this message]
2006-07-10 13:14 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d120d5000607100607i47980d08w60a85be9aeca348@mail.gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=jesper.juhl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome