From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161047AbWG0NBk (ORCPT ); Thu, 27 Jul 2006 09:01:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1161049AbWG0NBk (ORCPT ); Thu, 27 Jul 2006 09:01:40 -0400 Received: from ug-out-1314.google.com ([66.249.92.169]:10192 "EHLO ug-out-1314.google.com") by vger.kernel.org with ESMTP id S1161047AbWG0NBj (ORCPT ); Thu, 27 Jul 2006 09:01:39 -0400 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=oHu1/A2GEEBIJDCGPmB3bWnVtJcEXiZFjZThvmvK71+lOO+Jer41QJrmq/SGog3kft6yi9RxHA+rMi4RZ18LiFTUTBujJ3dkDgLWKIiILuT27KaPonS7aWgKUtPVPZ/JsxOolNcA5JTqf0jb71uf08FFIxoKKCXWU1YpHdH/Y8c= Message-ID: Date: Thu, 27 Jul 2006 09:01:36 -0400 From: "Dmitry Torokhov" To: "Jeff Garzik" Subject: Re: [PATCH] CCISS: Don't print driver version until we actually find a device Cc: "Arjan van de Ven" , "Jesper Juhl" , "Bjorn Helgaas" , "Andrew Morton" , "Mike Miller" , iss_storagedev@hp.com, linux-kernel@vger.kernel.org In-Reply-To: <44C6F26C.2080203@garzik.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200607251636.42765.bjorn.helgaas@hp.com> <9a8748490607251543w7496864dtd587abc45b93394a@mail.gmail.com> <1153867675.8932.68.camel@laptopd505.fenrus.org> <44C6F26C.2080203@garzik.org> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On 7/26/06, Jeff Garzik wrote: > Arjan van de Ven wrote: > > On Wed, 2006-07-26 at 00:43 +0200, Jesper Juhl wrote: > >> On 26/07/06, Bjorn Helgaas wrote: > >>> If we don't find any devices, we shouldn't print anything. > >>> > >> I disagree. > >> I find it quite nice to be able to see that the driver loaded even if > >> it finds nothing. At least then when there's a problem, I can quickly > >> see that at least it is not because I didn't forget to load the > >> driver, it's something else. Saves time since I can start looking for > >> reasons why the driver didn't find anything without first spending > >> additional time checking if I failed to cause it to load for some > >> reason. > > > > I'll add a second reason: it is a REALLY nice property to be able to see > > which driver is started last in case of a crash/hang, so that the guilty > > party is more obvious.. > > OTOH, it is not a property that scales well at all. > > When you build extra drivers into the kernel, or distros load drivers > you don't need (_every_ distro does this), you wind up with a bunch of > version strings for drivers for hardware you don't have. > Given that boot tracing is best done with initcall_debug and drivers that care about their version string can report it through /sys/modules//version why should version string be printed at load time at all? -- Dmitry