From: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>
To: "Rolf Eike Beer" <eike-kernel@sf-tec.de>
Cc: "Jonathan Corbet" <corbet@lwn.net>,
"Alexey Dobriyan" <adobriyan@gmail.com>,
"Andrew Morton" <akpm@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: cdev documentation (was Drop second arg of unregister_chrdev())
Date: Fri, 18 Aug 2006 08:32:41 -0400 [thread overview]
Message-ID: <d120d5000608180532j453bf0f3l2ee88b0502c20cfd@mail.gmail.com> (raw)
In-Reply-To: <200608180915.28763.eike-kernel@sf-tec.de>
On 8/18/06, Rolf Eike Beer <eike-kernel@sf-tec.de> wrote:
>
> While I was sneaking around in the code I found this drivers/char/tty_io:3093
>
> cdev_init(&driver->cdev, &tty_fops);
> driver->cdev.owner = driver->owner;
> error = cdev_add(&driver->cdev, dev, driver->num);
> if (error) {
> cdev_del(&driver->cdev);
>
> Isn't the call to cdev_del() just wrong here?
>
Yes, itlooks like it shouldjust be removed.
--
Dmitry
next prev parent reply other threads:[~2006-08-18 12:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-15 3:35 [PATCH] Drop second arg of unregister_chrdev() Alexey Dobriyan
2006-08-15 3:48 ` Andrew Morton
2006-08-15 4:18 ` Alexey Dobriyan
2006-08-15 19:52 ` Jonathan Corbet
2006-08-16 7:03 ` Rolf Eike Beer
2006-08-16 15:42 ` Jonathan Corbet
2006-08-17 21:22 ` cdev documentation (was Drop second arg of unregister_chrdev()) Jonathan Corbet
2006-08-18 7:15 ` Rolf Eike Beer
2006-08-18 12:32 ` Dmitry Torokhov [this message]
2006-08-18 12:46 ` [TTY] Remove bogus call to cdev_del() Rolf Eike Beer
2006-08-18 13:02 ` cdev documentation (was Drop second arg of unregister_chrdev()) Jonathan Corbet
2006-08-18 13:49 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d120d5000608180532j453bf0f3l2ee88b0502c20cfd@mail.gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=adobriyan@gmail.com \
--cc=akpm@osdl.org \
--cc=corbet@lwn.net \
--cc=eike-kernel@sf-tec.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome