mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>
To: "Jeff Garzik" <jeff@garzik.org>
Cc: "Andrew Morton" <akpm@osdl.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] input: handle sysfs errors
Date: Tue, 10 Oct 2006 09:58:39 -0400	[thread overview]
Message-ID: <d120d5000610100658l6d80c7c7p84d31da317d457dd@mail.gmail.com> (raw)
In-Reply-To: <20061010064939.GA21385@havoc.gtf.org>

On 10/10/06, Jeff Garzik <jeff@garzik.org> wrote:
>
> -       device_create_file(&serio->dev, &atkbd_attr_extra);
> -       device_create_file(&serio->dev, &atkbd_attr_scroll);
> -       device_create_file(&serio->dev, &atkbd_attr_set);
> -       device_create_file(&serio->dev, &atkbd_attr_softrepeat);
> -       device_create_file(&serio->dev, &atkbd_attr_softraw);
> +       err = device_create_file(&serio->dev, &atkbd_attr_extra);
> +       if (err) goto fail_serio;

I have a patch that converts atkbd to attribute group and also one
that handles errors from input_register_drevice. I will add sysfs
error checks there as well.

-- 
Dmitry

  reply	other threads:[~2006-10-10 13:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-10  6:49 Jeff Garzik
2006-10-10 13:58 ` Dmitry Torokhov [this message]
2006-10-10 13:37 Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d120d5000610100658l6d80c7c7p84d31da317d457dd@mail.gmail.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=akpm@osdl.org \
    --cc=jeff@garzik.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®