From: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>
To: "David Brownell" <david-b@pacbell.net>
Cc: nicolas.ferre@rfo.atmel.com, linux-kernel@vger.kernel.org
Subject: Re: [patch 2.6.20-rc1 3/6] input: ads7846 more compatible with hwmon
Date: Fri, 22 Dec 2006 15:26:01 -0500 [thread overview]
Message-ID: <d120d5000612221226q40ae235ex251c1bc0c55d42a6@mail.gmail.com> (raw)
In-Reply-To: <20061222192322.2BDCA1F0D22@adsl-69-226-248-13.dsl.pltn13.pacbell.net>
On 12/22/06, David Brownell <david-b@pacbell.net> wrote:
> Be more compatible with the hwmon framework:
>
> - Hook up to hwmon
> * show sensor attrubites only if hwmon is present
> * otherwise be just a touchscreen
> - Report voltages per hwmon convention
> * measure in millivolts
> * voltages are named in[0-8]_input (ugh)
> * for 7846 chips, properly range-adjust vBATT/in1_input
There are too many #ifdefs. Please consider creating
ads7846_[un]register_hwmon() and use them in
ads7846_probe()/ads7846_remove(). Split hwmon related attributes into
a separate attribute group and move everything in #ifdef CONFIG_HWMON
block.
> + *
> + * FIXME make external vREF_mV be a module option, and use that as needed...
> */
> +static const unsigned vREF_mV = 2500;
>
Why don't you make it mdule option right away?
--
Dmitry
next prev parent reply other threads:[~2006-12-22 20:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-22 19:23 David Brownell
2006-12-22 20:26 ` Dmitry Torokhov [this message]
2006-12-22 22:06 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d120d5000612221226q40ae235ex251c1bc0c55d42a6@mail.gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@rfo.atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®