From: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>
To: "Tejun Heo" <htejun@gmail.com>
Cc: gregkh@suse.de, cornelia.huck@de.ibm.com, oneukum@suse.de,
rpurdie@rpsys.net, stern@rowland.harvard.edu, maneesh@in.ibm.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHSET 2.6.22-rc2-mm1] sysfs: reduce memory footprint of sysfs_dirent
Date: Tue, 29 May 2007 12:04:30 -0400 [thread overview]
Message-ID: <d120d5000705290904s706763bfj7beb837397f54d86@mail.gmail.com> (raw)
In-Reply-To: <118036944617-git-send-email-htejun@gmail.com>
Hi Tejun,
On 5/28/07, Tejun Heo <htejun@gmail.com> wrote:
> Hello, all.
>
> This patchset reduces the size of sysfs_dirent to 88 byte from 136 on
> 64bit and to 52 from 76 on 32bit. Combined with forthcoming
> reclaimable sysfs directories, this will make sysfs much more scalable
> on very large machines and very small machines.
>
> This patchset contains the following three patches.
>
> #01: move-s_active-functions-to-fs-sysfs-dir-c, prep for #02
> #02: slim-down-sysfs_dirent-s_active
> #03: use-signly-linked-list-for-sysfs_dirent-tree
>
> I'm pretty sure #02 is a good idea but #03 is debatable. The code
> doesn't look much uglier after the conversion tho. Inputs welcome.
>
I think that #3 is a good idea as well - we have a lot of sysfs
objects on any given system and slimming down sysfs benefits everyone.
--
Dmitry
next prev parent reply other threads:[~2007-05-29 16:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-28 16:24 Tejun Heo
2007-05-28 16:24 ` [PATCH 2/3] sysfs: slim down sysfs_dirent->s_active Tejun Heo
2007-05-29 16:13 ` Cornelia Huck
2007-05-28 16:24 ` [PATCH 3/3] sysfs: use singly-linked list for sysfs_dirent tree Tejun Heo
2007-05-28 16:24 ` [PATCH 1/3] sysfs: move s_active functions to fs/sysfs/dir.c Tejun Heo
2007-05-29 16:04 ` Dmitry Torokhov [this message]
2007-05-29 16:17 ` [PATCHSET 2.6.22-rc2-mm1] sysfs: reduce memory footprint of sysfs_dirent Cornelia Huck
2007-05-29 17:23 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d120d5000705290904s706763bfj7beb837397f54d86@mail.gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=cornelia.huck@de.ibm.com \
--cc=gregkh@suse.de \
--cc=htejun@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maneesh@in.ibm.com \
--cc=oneukum@suse.de \
--cc=rpurdie@rpsys.net \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®