From: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>
To: "Richard Purdie" <rpurdie@rpsys.net>
Cc: "Jan Kratochvil" <honza@jikos.cz>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Support for controlling leds on xbox 360 pad.
Date: Wed, 30 May 2007 10:56:28 -0400 [thread overview]
Message-ID: <d120d5000705300756t24d4a58ey1f4130bef22f8309@mail.gmail.com> (raw)
In-Reply-To: <1180474885.5822.94.camel@localhost.localdomain>
On 5/29/07, Richard Purdie <rpurdie@rpsys.net> wrote:
> On Tue, 2007-05-29 at 23:29 +0200, Jan Kratochvil wrote:
> >
> > I have the impression that the led subsystem doesn't actually count with
> > possibility to have more then one device of one type, right? In my case there
> > can by lots of pads, so I made it on my own, using counter. Is it ok?
>
> It leaves it up to the driver concerned. In your case it makes sense so
> counting is fine. Don't put the colon in though, just have it as xpad0
> etc. as the name. Anything after the first colon is defined as an
> optional colour (see Documentation/leds-class.txt).
>
Richard,
Do you think it makes sense to split the driver (and Kconfig options)
between input and leds directories as Jan had done? I know that I
prefer to keep anything input related in input directory because it
makes my life as maintainer easier and I bet you prefer the same but
it does not always work well for multifunction devices or devices
using several subsystems...
--
Dmitry
next prev parent reply other threads:[~2007-05-30 14:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-29 21:11 Jan Kratochvil
2007-05-29 21:29 ` Jan Kratochvil
2007-05-29 21:41 ` Richard Purdie
2007-05-30 3:17 ` Dmitry Torokhov
2007-05-30 14:56 ` Dmitry Torokhov [this message]
2007-05-30 16:32 ` Richard Purdie
2007-05-30 21:37 ` Jan Kratochvil
2007-06-03 18:02 ` Jan Kratochvil
2007-06-03 18:07 ` Jan Kratochvil
2007-06-15 4:15 ` Dmitry Torokhov
2007-06-15 5:06 ` Dmitry Torokhov
2007-05-31 14:07 ` Pavel Machek
2007-05-31 15:53 ` Jan Kratochvil
2007-05-31 16:09 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d120d5000705300756t24d4a58ey1f4130bef22f8309@mail.gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=honza@jikos.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®