From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753492AbXGBTDz (ORCPT ); Mon, 2 Jul 2007 15:03:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753597AbXGBTDp (ORCPT ); Mon, 2 Jul 2007 15:03:45 -0400 Received: from wa-out-1112.google.com ([209.85.146.176]:30399 "EHLO wa-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753535AbXGBTDo (ORCPT ); Mon, 2 Jul 2007 15:03:44 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=GsY6I58qXfE3qlePl9Z1P4k0qreKg0zhAEvEKeQchJvc2JgwFpu9DPv6F1x+JYxuoXVLTL/w8IcEDh/5dGzqWH2bnDyqPHOuYfXG5rTlnUd2GVMFVqABs3kpoFzjyry4CB9vwEiOvL7UcB+AEqJmCMMkZeu0jK2y1AAlbZMSEFY= Message-ID: Date: Mon, 2 Jul 2007 15:03:43 -0400 From: "Dmitry Torokhov" To: "Stephen Hemminger" Subject: Re: blink driver power saving Cc: "Andi Kleen" , "Linus Torvalds" , "Andrew Morton" , linux-kernel@vger.kernel.org In-Reply-To: <20070702105000.73e50500@freepuppy.localdomain.hemminger.net> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20070701125035.3f54d8b0@oldman> <200707012329.52918.ak@suse.de> <200707020159.51200.ak@suse.de> <20070702105000.73e50500@freepuppy.localdomain.hemminger.net> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On 7/2/07, Stephen Hemminger wrote: > > The patch makes sense. You don't need to poll every jiffie to find > out if system has panic. But I agree with Linus, it is the kind > of patch that doesn't belong in the mainline kernel. Every developer > seems to have built up a set of crappy/fragile debug tools, but these > don't belong in the wild. > Stephen, The drivers blinks LEDs when kernel operates normally. During panic the panic_blink() routine in i8042 gets called directly, without involving the blink driver. -- Dmitry